From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.devel Subject: Re: master b2167d9843: Don't fail flymake-tests if `gcc` actually is Clang Date: Sun, 2 Jan 2022 10:11:53 -0500 Message-ID: References: <164112836156.3693.5253778017552372948@vcs2.savannah.gnu.org> <20220102125921.CEC93C0DA1A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14178"; mail-complaints-to="usenet@ciao.gmane.io" To: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Jan 02 16:12:49 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n42XR-0003VA-ED for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jan 2022 16:12:49 +0100 Original-Received: from localhost ([::1]:35556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n42XP-00061r-Cj for ged-emacs-devel@m.gmane-mx.org; Sun, 02 Jan 2022 10:12:47 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46986) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n42Wb-0005Lh-TI for emacs-devel@gnu.org; Sun, 02 Jan 2022 10:11:58 -0500 Original-Received: from [2607:f8b0:4864:20::42b] (port=37560 helo=mail-pf1-x42b.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n42Wa-00024u-En for emacs-devel@gnu.org; Sun, 02 Jan 2022 10:11:57 -0500 Original-Received: by mail-pf1-x42b.google.com with SMTP id 8so27511321pfo.4 for ; Sun, 02 Jan 2022 07:11:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=JB6GGO5swrdZQ0UOXuZZY7VeOV3nHkOqJDg1NaGm0/4=; b=ODI6x91NueRdTbRQDyVcJKB5kWTHHk+zHfaU82IZyytGLIWhV/EVGgJdWvumAxB6HD Jpzq/V+2ARQd+GTH7ljaUuSKH1G86nl4okbaezTOyftN0x/Nx3YBRFBNGD7CS2GAAx5d I7oiZztwhxkK9Bt7BObxn+NJdaPn5ypShIy1NdmQePncn0cIEKdjxKj5zK71vycJqFnM POWHZ/rAedemywUbh5M4uRFthy32uc4fPgVZ4cdm3sEXz/lSwJYnkYB44g6r0VRnKSqn jhmVBK68ZpwEDIyttI1pOpmWdsn0kP8BMn5VvIpvoinlKNMC15Ea3jvi4koecApjj5Eq gp3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=JB6GGO5swrdZQ0UOXuZZY7VeOV3nHkOqJDg1NaGm0/4=; b=D/+WrFvx1xPosq1Ni8YtaIbu6b1OyuoVs5/V1ttbdHrhhjYMUH+PPEpaFhyAClBbhn HIQ+dBbN+cNK2fxRHV9qxhl0vEtINzwEWO09LTlEGPUzTnMomeYvMGERXYZGn6yrFZhC kBHnUbWdTFyvWxd63R8cyaedVwD95765YENTUf4HGLeflId1nAabL5l3c9q43A7t4/RV aHA2GLAbAjdJhJGia1QhzEooUzW4fdfbRHjwyhZDUSFnnAjTAwkAvNdXqvYpivmjPXa8 OLdpK+xmx0t9xTDGUMq3uHpngIMfepmUjjxakykiIixSAiYQeDPy5uPgal5HM5GAsjRO ++7g== X-Gm-Message-State: AOAM530dFMwKD/dfj7FOMGxwS99K3FnlVs0Tzzv5m8GQSFITA68h56mW K9D/D/yIvl4xpPl242QXXE+yk4Mvrye80cE/U6ifcDmd X-Google-Smtp-Source: ABdhPJyHswDhYju8+e0QrtTbO0IPWlirIoIVnxds7lgkc6Lqe7tOFturTdnqPHJI2mWlEUmYF5if5Mp7ivNT02tv27s= X-Received: by 2002:a63:4b42:: with SMTP id k2mr37542071pgl.591.1641136314240; Sun, 02 Jan 2022 07:11:54 -0800 (PST) Original-Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 2 Jan 2022 10:11:53 -0500 In-Reply-To: <20220102125921.CEC93C0DA1A@vcs2.savannah.gnu.org> X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::42b (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=stefankangas@gmail.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283914 Archived-At: Mattias Engdeg=C3=A5rd writes: > +(defun flymake-tests--gcc-is-clang () > + "Whether the `gcc' command actually runs the Clang compiler." > + (string-match "[Cc]lang version " > + (shell-command-to-string "gcc --version"))) We have a similar check in test/lisp/cedet/semantic/bovine/gcc.el (let ((semantic-gcc-test-strings (list (semantic-gcc-query "gcc" "-v")))) ;; Some macOS machines run llvm when you type gcc. (!) ;; We can't even check if it's a symlink; it's a binary placed in ;; "/usr/bin/gcc". So check the output and just skip this test if ;; it looks like that's the case. (unless (string-match "Apple \\(LLVM\\|clang\\)\\|Xcode\\.app" (car semantic-gcc-test-strings)) ...)) Should these tests perhaps be consolidated somehow?