Re: [Emacs-diffs] emacs-25 d7973e8: Document 'default-toplevel-value' and 'set-default-toplevel-value'

Re: [Emacs-diffs] emacs-25 d7973e8: Document 'default-toplevel-value' and 'set-default-toplevel-value'

[Stefan Monnier]

> +  A variable can be let-bound (@pxref{Local Variables}) to a
> +non-default value; in that case, @code{default-value} will return the

Not sure what "non-default" means here, nor why it's needed.

> +value from that binding, not the global value, and @code{set-default}
> +will be prevented from setting the global value.

Not only `set-default` doesn't set the global value, but it will modify
the let binding (the way it's written could be mis-understood to mean
that in those circumstances, `set-default` will just do nothing).

> The following two
> +functions allow to reference the global value even if it's masked by a
> +let-binding.

That looks fine, thank you.

> +@cindex top-level default value
> +@defun default-toplevel-value symbol
> +This function returns the @dfn{top-level} default value of
> +@var{symbol}, which is its value outside of any let-binding.
> +@end defun
[...]
> +@defun set-default-toplevel-value symbol value
> +This function sets the top-level default value of @var{symbol} to the
> +specified @var{value}.  This comes in handy when you want to set the
> +global value of @var{symbol} regardless of whether your code runs in
> +the context of @var{symbol}'s let-binding.
> +@end defun

Perfect, thanks.


        Stefan

Re: [Emacs-diffs] emacs-25 d7973e8: Document 'default-toplevel-value' and 'set-default-toplevel-value'

[Eli Zaretskii]

> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Mon, 26 Dec 2016 20:34:40 -0500
> 
> > +  A variable can be let-bound (@pxref{Local Variables}) to a
> > +non-default value; in that case, @code{default-value} will return the
> 
> Not sure what "non-default" means here, nor why it's needed.
> 
> > +value from that binding, not the global value, and @code{set-default}
> > +will be prevented from setting the global value.
> 
> Not only `set-default` doesn't set the global value, but it will modify
> the let binding (the way it's written could be mis-understood to mean
> that in those circumstances, `set-default` will just do nothing).

Thanks for the review, I fixed the text there.