From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 d7973e8: Document 'default-toplevel-value' and 'set-default-toplevel-value' Date: Tue, 27 Dec 2016 09:11:32 +0200 Message-ID: <83mvfhx2vv.fsf@gnu.org> References: <20161226171154.28694.54038@vcs.savannah.gnu.org> <20161226171155.3FCBE2201C7@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1482822721 2164 195.159.176.226 (27 Dec 2016 07:12:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 27 Dec 2016 07:12:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 27 08:11:54 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cLlvM-000802-Cg for ged-emacs-devel@m.gmane.org; Tue, 27 Dec 2016 08:11:52 +0100 Original-Received: from localhost ([::1]:53023 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLlvR-0006Eu-5t for ged-emacs-devel@m.gmane.org; Tue, 27 Dec 2016 02:11:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLlvG-0006Ep-H0 for emacs-devel@gnu.org; Tue, 27 Dec 2016 02:11:47 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cLlvD-0004Rw-CM for emacs-devel@gnu.org; Tue, 27 Dec 2016 02:11:46 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49324) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cLlvD-0004Rs-8y; Tue, 27 Dec 2016 02:11:43 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1635 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cLlvC-0005dq-H0; Tue, 27 Dec 2016 02:11:42 -0500 In-reply-to: (message from Stefan Monnier on Mon, 26 Dec 2016 20:34:40 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210835 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii > Date: Mon, 26 Dec 2016 20:34:40 -0500 > > > + A variable can be let-bound (@pxref{Local Variables}) to a > > +non-default value; in that case, @code{default-value} will return the > > Not sure what "non-default" means here, nor why it's needed. > > > +value from that binding, not the global value, and @code{set-default} > > +will be prevented from setting the global value. > > Not only `set-default` doesn't set the global value, but it will modify > the let binding (the way it's written could be mis-understood to mean > that in those circumstances, `set-default` will just do nothing). Thanks for the review, I fixed the text there.