From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Byte-compilation of custom themes
Date: Sun, 03 Jun 2018 19:16:59 +0300 [thread overview]
Message-ID: <83lgbvdev8.fsf@gnu.org> (raw)
In-Reply-To: <87y3fvua2x.fsf@tcd.ie> (contovob@tcd.ie)
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Cc: <monnier@iro.umontreal.ca>, <emacs-devel@gnu.org>
> Date: Sun, 03 Jun 2018 17:08:22 +0100
>
> So, if we can't load cl-lib at the top-level of custom.el, and we don't
> load cl-lib in custom-available-themes, then the featurep check says
> "only call cl-assert if some other library has already loaded cl-lib for
> us", which doesn't make sense to me. What is the benefit of
> conditionally calling an assertion at runtime?
In most sessions cl-lib is loaded pretty close to startup, so the
problem doesn't exist in practice, IMO.
> Why wouldn't we want the assertion to be exercised every time
> custom-available-themes is called?
Because it's complicated, and I don't see any reason to justify that
complication?
But this is not a string opinion, so we could just drop the issue and
move on.
Thanks.
> Just to be clear, including any one of the following three top-level
> forms in custom.el breaks 'make bootstrap', irrespective of the NOERROR
> argument passed to require, and even when there is no subsequent mention
> of cl-assert or any other cl-lib feature in custom.el:
>
> (require 'cl-lib)
> (eval-when-compile (require 'cl-lib))
> (when t (require 'cl-lib))
>
> In all three cases, 'make bootstrap' reports the following:
>
> Loading custom (source)...
> Warning: Unknown defun property ‘gv-setter’ in cl-fifth
> Warning: Unknown defun property ‘gv-setter’ in cl-sixth
> Warning: Unknown defun property ‘gv-setter’ in cl-seventh
> Warning: Unknown defun property ‘gv-setter’ in cl-eighth
> Warning: Unknown defun property ‘gv-setter’ in cl-ninth
> Warning: Unknown defun property ‘gv-setter’ in cl-tenth
> Symbol’s function definition is void: gv-define-simple-setter
> Makefile:745: recipe for target 'bootstrap-emacs' failed
Any reason you require cl-lib and not cl-macs?
next prev parent reply other threads:[~2018-06-03 16:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 21:01 Byte-compilation of custom themes Basil L. Contovounesios
2018-01-24 16:16 ` Stefan Monnier
2018-01-30 22:16 ` Basil L. Contovounesios
2018-01-31 2:26 ` Stefan Monnier
2018-02-01 0:45 ` Basil L. Contovounesios
2018-02-02 14:25 ` Stefan Monnier
2018-05-10 2:49 ` Basil L. Contovounesios
2018-05-10 2:54 ` Basil L. Contovounesios
2018-05-11 14:07 ` Eli Zaretskii
2018-05-11 14:02 ` Eli Zaretskii
2018-05-11 15:16 ` Basil L. Contovounesios
2018-05-11 16:03 ` Stefan Monnier
2018-05-11 20:03 ` Basil L. Contovounesios
2018-05-11 17:32 ` Eli Zaretskii
2018-05-11 20:43 ` Basil L. Contovounesios
2018-05-12 7:04 ` Eli Zaretskii
2018-06-01 20:48 ` Basil L. Contovounesios
2018-06-01 21:07 ` Basil L. Contovounesios
2018-06-02 11:24 ` Eli Zaretskii
2018-06-02 18:53 ` Basil L. Contovounesios
2018-06-02 19:32 ` Eli Zaretskii
2018-06-02 20:02 ` Basil L. Contovounesios
2018-06-03 3:52 ` Stefan Monnier
2018-06-03 11:21 ` Basil L. Contovounesios
2018-06-03 15:11 ` Eli Zaretskii
2018-06-03 16:08 ` Basil L. Contovounesios
2018-06-03 16:16 ` Eli Zaretskii [this message]
2018-06-03 17:48 ` Basil L. Contovounesios
2018-06-03 20:22 ` Stefan Monnier
2018-06-04 1:33 ` Basil L. Contovounesios
2018-07-03 7:57 ` Basil L. Contovounesios
2018-07-11 1:40 ` Stefan Monnier
2018-07-11 6:05 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83lgbvdev8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).