From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Byte-compilation of custom themes Date: Sun, 03 Jun 2018 19:16:59 +0300 Message-ID: <83lgbvdev8.fsf@gnu.org> References: <87efmk2qk0.fsf@tcd.ie> <87vafjhu04.fsf@tcd.ie> <87po5po7ul.fsf@tcd.ie> <87o9hoxm0w.fsf@tcd.ie> <83fu2ynvda.fsf@gnu.org> <87zi169q9y.fsf@tcd.ie> <83a7t6nlmf.fsf@gnu.org> <877eo9kjnl.fsf@tcd.ie> <831sehnymt.fsf@gnu.org> <874lim2pyi.fsf@tcd.ie> <83d0x9e8iu.fsf@gnu.org> <87vab110mi.fsf@tcd.ie> <83y3fxc7c4.fsf@gnu.org> <87muwc9kv0.fsf@tcd.ie> <83po17dhwe.fsf@gnu.org> <87y3fvua2x.fsf@tcd.ie> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1528042535 24593 195.159.176.226 (3 Jun 2018 16:15:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2018 16:15:35 +0000 (UTC) Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jun 03 18:15:31 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fPVfH-0006Ho-GT for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2018 18:15:31 +0200 Original-Received: from localhost ([::1]:35854 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPVhO-0001r5-Dv for ged-emacs-devel@m.gmane.org; Sun, 03 Jun 2018 12:17:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPVgg-0001qf-2y for emacs-devel@gnu.org; Sun, 03 Jun 2018 12:16:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fPVgc-00011x-N3 for emacs-devel@gnu.org; Sun, 03 Jun 2018 12:16:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:32919) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fPVgc-00011r-Ip; Sun, 03 Jun 2018 12:16:54 -0400 Original-Received: from [176.228.60.248] (port=4202 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fPVgb-0006l9-TX; Sun, 03 Jun 2018 12:16:54 -0400 In-reply-to: <87y3fvua2x.fsf@tcd.ie> (contovob@tcd.ie) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225963 Archived-At: > From: "Basil L. Contovounesios" > Cc: , > Date: Sun, 03 Jun 2018 17:08:22 +0100 > > So, if we can't load cl-lib at the top-level of custom.el, and we don't > load cl-lib in custom-available-themes, then the featurep check says > "only call cl-assert if some other library has already loaded cl-lib for > us", which doesn't make sense to me. What is the benefit of > conditionally calling an assertion at runtime? In most sessions cl-lib is loaded pretty close to startup, so the problem doesn't exist in practice, IMO. > Why wouldn't we want the assertion to be exercised every time > custom-available-themes is called? Because it's complicated, and I don't see any reason to justify that complication? But this is not a string opinion, so we could just drop the issue and move on. Thanks. > Just to be clear, including any one of the following three top-level > forms in custom.el breaks 'make bootstrap', irrespective of the NOERROR > argument passed to require, and even when there is no subsequent mention > of cl-assert or any other cl-lib feature in custom.el: > > (require 'cl-lib) > (eval-when-compile (require 'cl-lib)) > (when t (require 'cl-lib)) > > In all three cases, 'make bootstrap' reports the following: > > Loading custom (source)... > Warning: Unknown defun property ‘gv-setter’ in cl-fifth > Warning: Unknown defun property ‘gv-setter’ in cl-sixth > Warning: Unknown defun property ‘gv-setter’ in cl-seventh > Warning: Unknown defun property ‘gv-setter’ in cl-eighth > Warning: Unknown defun property ‘gv-setter’ in cl-ninth > Warning: Unknown defun property ‘gv-setter’ in cl-tenth > Symbol’s function definition is void: gv-define-simple-setter > Makefile:745: recipe for target 'bootstrap-emacs' failed Any reason you require cl-lib and not cl-macs?