From: Eli Zaretskii <eliz@gnu.org>
To: "Basil L. Contovounesios" <contovob@tcd.ie>
Cc: monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: Byte-compilation of custom themes
Date: Fri, 11 May 2018 20:32:56 +0300 [thread overview]
Message-ID: <83a7t6nlmf.fsf@gnu.org> (raw)
In-Reply-To: <87zi169q9y.fsf@tcd.ie> (contovob@tcd.ie)
> From: "Basil L. Contovounesios" <contovob@tcd.ie>
> Cc: <monnier@IRO.UMontreal.CA>, <emacs-devel@gnu.org>
> Date: Fri, 11 May 2018 16:16:09 +0100
>
> > The original code carefully verified that the members in
> > custom-theme--load-path are directories, whereas your proposal calls
> > directory-files on each member unconditionally, which will barf if a
> > file is not a directory.
>
> The function custom-theme--load-path already incorporates the
> file-directory-p check, so it is technically redundant here.
> Would you rather it be kept regardless?
We should at least have a comment there that we are relying on
custom-theme--load-path to do the test, and perhaps also an assertion.
> >> - (define-key map "\C-x\C-s" 'custom-theme-write)
> >> - (define-key map "q" 'Custom-buffer-done)
> >> - (define-key map "n" 'widget-forward)
> >> - (define-key map "p" 'widget-backward)
> >> + (define-key map "\C-x\C-s" #'custom-theme-write)
> >> + (define-key map "q" #'Custom-buffer-done)
> >> + (define-key map "n" #'widget-forward)
> >> + (define-key map "p" #'widget-backward)
> >
> > Really? Are we going to switch to #'foo even in key bindings?
>
> Though I personally prefer to consistently #'-quote function symbols in
> my own code, both for the extra byte-compiler check and narrower
> in-buffer completion, I have no strong opinion here; I was simply making
> the change in a sweeping fashion, in line with what I had perceived as a
> welcome style. Out of curiosity, though, what makes key bindings
> special w.r.t. quoting?
Stefan gave one reason (with which I agree). From POV, it's another
stab into my heart of a veteran reader of Emacs Lisp code. I recently
find the code harder and harder to read due to all the new syntax and
unfamiliar functions. You can ignore me on that, though.
Thanks.
next prev parent reply other threads:[~2018-05-11 17:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-20 21:01 Byte-compilation of custom themes Basil L. Contovounesios
2018-01-24 16:16 ` Stefan Monnier
2018-01-30 22:16 ` Basil L. Contovounesios
2018-01-31 2:26 ` Stefan Monnier
2018-02-01 0:45 ` Basil L. Contovounesios
2018-02-02 14:25 ` Stefan Monnier
2018-05-10 2:49 ` Basil L. Contovounesios
2018-05-10 2:54 ` Basil L. Contovounesios
2018-05-11 14:07 ` Eli Zaretskii
2018-05-11 14:02 ` Eli Zaretskii
2018-05-11 15:16 ` Basil L. Contovounesios
2018-05-11 16:03 ` Stefan Monnier
2018-05-11 20:03 ` Basil L. Contovounesios
2018-05-11 17:32 ` Eli Zaretskii [this message]
2018-05-11 20:43 ` Basil L. Contovounesios
2018-05-12 7:04 ` Eli Zaretskii
2018-06-01 20:48 ` Basil L. Contovounesios
2018-06-01 21:07 ` Basil L. Contovounesios
2018-06-02 11:24 ` Eli Zaretskii
2018-06-02 18:53 ` Basil L. Contovounesios
2018-06-02 19:32 ` Eli Zaretskii
2018-06-02 20:02 ` Basil L. Contovounesios
2018-06-03 3:52 ` Stefan Monnier
2018-06-03 11:21 ` Basil L. Contovounesios
2018-06-03 15:11 ` Eli Zaretskii
2018-06-03 16:08 ` Basil L. Contovounesios
2018-06-03 16:16 ` Eli Zaretskii
2018-06-03 17:48 ` Basil L. Contovounesios
2018-06-03 20:22 ` Stefan Monnier
2018-06-04 1:33 ` Basil L. Contovounesios
2018-07-03 7:57 ` Basil L. Contovounesios
2018-07-11 1:40 ` Stefan Monnier
2018-07-11 6:05 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83a7t6nlmf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=contovob@tcd.ie \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).