unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master 506270f: Don't compare arguments that can be nil
       [not found] ` <20171216004037.6240920856@vcs0.savannah.gnu.org>
@ 2017-12-16 21:08   ` Glenn Morris
  2017-12-16 23:13     ` Óscar Fuentes
  0 siblings, 1 reply; 4+ messages in thread
From: Glenn Morris @ 2017-12-16 21:08 UTC (permalink / raw)
  To: emacs-devel; +Cc: Oscar Fuentes

Oscar Fuentes wrote:

> branch: master
> commit 506270f9c80bf9bd7dad35a2f0aa6f477da6490b
[...]
>     * lisp/ses.el (ses--advice-copy-region-as-kill): avoid comparison
>       unless `beg' and `end' are non-nil.

This is https://debbugs.gnu.org/28039, which seems like something to
fix in the emacs-26 branch.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 506270f: Don't compare arguments that can be nil
  2017-12-16 21:08   ` master 506270f: Don't compare arguments that can be nil Glenn Morris
@ 2017-12-16 23:13     ` Óscar Fuentes
  2017-12-17  3:37       ` Eli Zaretskii
  0 siblings, 1 reply; 4+ messages in thread
From: Óscar Fuentes @ 2017-12-16 23:13 UTC (permalink / raw)
  To: Glenn Morris; +Cc: emacs-devel

Glenn Morris <rgm@gnu.org> writes:

> Oscar Fuentes wrote:
>
>> branch: master
>> commit 506270f9c80bf9bd7dad35a2f0aa6f477da6490b
> [...]
>>     * lisp/ses.el (ses--advice-copy-region-as-kill): avoid comparison
>>       unless `beg' and `end' are non-nil.
>
> This is https://debbugs.gnu.org/28039, which seems like something to
> fix in the emacs-26 branch.

Thanks.

AFAIK emacs-26 is open only for documentation and regressions. This bug
existed since the beginning of SES. OTOH, it looks quite safe.

I have no problem about backporting it to emacs-26. Eli?



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 506270f: Don't compare arguments that can be nil
  2017-12-16 23:13     ` Óscar Fuentes
@ 2017-12-17  3:37       ` Eli Zaretskii
  2017-12-18  0:39         ` Dmitry Gutov
  0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2017-12-17  3:37 UTC (permalink / raw)
  To: Óscar Fuentes; +Cc: rgm, emacs-devel

> From: ofv@wanadoo.es (Óscar Fuentes)
> Date: Sun, 17 Dec 2017 00:13:57 +0100
> Cc: emacs-devel@gnu.org
> 
> > This is https://debbugs.gnu.org/28039, which seems like something to
> > fix in the emacs-26 branch.
> 
> Thanks.
> 
> AFAIK emacs-26 is open only for documentation and regressions.

I wish that were the case, but given the fact we wait for the
widen-less stuff to be merged, we are a far cry from there.

> This bug existed since the beginning of SES. OTOH, it looks quite
> safe.
> 
> I have no problem about backporting it to emacs-26. Eli?

Please do, and thanks.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: master 506270f: Don't compare arguments that can be nil
  2017-12-17  3:37       ` Eli Zaretskii
@ 2017-12-18  0:39         ` Dmitry Gutov
  0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Gutov @ 2017-12-18  0:39 UTC (permalink / raw)
  To: Eli Zaretskii, Óscar Fuentes; +Cc: rgm, emacs-devel

On 12/17/17 5:37 AM, Eli Zaretskii wrote:

>> AFAIK emacs-26 is open only for documentation and regressions.
> 
> I wish that were the case, but given the fact we wait for the
> widen-less stuff to be merged, we are a far cry from there.

FWIW, the branch is ready as far as I'm concerned. Waiting only for 
either of the maintainers' approval.

Of course, feedback from Christoph will be welcome too, as well as any 
feedback on the manual edits, from everybody.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2017-12-18  0:39 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20171216004036.16935.43030@vcs0.savannah.gnu.org>
     [not found] ` <20171216004037.6240920856@vcs0.savannah.gnu.org>
2017-12-16 21:08   ` master 506270f: Don't compare arguments that can be nil Glenn Morris
2017-12-16 23:13     ` Óscar Fuentes
2017-12-17  3:37       ` Eli Zaretskii
2017-12-18  0:39         ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).