From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: ofv@wanadoo.es (=?utf-8?Q?=C3=93scar?= Fuentes) Newsgroups: gmane.emacs.devel Subject: Re: master 506270f: Don't compare arguments that can be nil Date: Sun, 17 Dec 2017 00:13:57 +0100 Message-ID: <87mv2i6zbe.fsf@telefonica.net> References: <20171216004036.16935.43030@vcs0.savannah.gnu.org> <20171216004037.6240920856@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1513465939 25145 195.159.176.226 (16 Dec 2017 23:12:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 16 Dec 2017 23:12:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 17 00:12:15 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eQLcs-0006GA-7p for ged-emacs-devel@m.gmane.org; Sun, 17 Dec 2017 00:12:14 +0100 Original-Received: from localhost ([::1]:52478 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQLeq-00022n-2w for ged-emacs-devel@m.gmane.org; Sat, 16 Dec 2017 18:14:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38931) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQLei-00021s-Uz for emacs-devel@gnu.org; Sat, 16 Dec 2017 18:14:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQLef-0005cY-Qo for emacs-devel@gnu.org; Sat, 16 Dec 2017 18:14:08 -0500 Original-Received: from relayout03-redir.e.movistar.es ([86.109.101.203]:63673) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eQLef-0005Qq-JW; Sat, 16 Dec 2017 18:14:05 -0500 Original-Received: from qcore (1.red-88-1-62.dynamicip.rima-tde.net [88.1.62.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 981711563@telefonica.net) by relayout03.e.movistar.es (Postfix) with ESMTPSA id 3yzjm663Y0zMl6g; Sun, 17 Dec 2017 00:13:57 +0100 (CET) In-Reply-To: (Glenn Morris's message of "Sat, 16 Dec 2017 16:08:29 -0500") X-CTCH-Score: 0.000 X-CTCH-ScoreCust: 0.000 X-TnetOut-Country: IP: 88.1.62.1 | Country: ES X-TnetOut-Information: AntiSPAM and AntiVIRUS on relayout03 X-TnetOut-MsgID: 3yzjm663Y0zMl6g.A7AB1 X-TnetOut-SpamCheck: no es spam, Unknown X-TnetOut-From: ofv@wanadoo.es X-TnetOut-Watermark: 1514070839.43616@znjczerU9++U5RseihIYpg X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 86.109.101.203 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221160 Archived-At: Glenn Morris writes: > Oscar Fuentes wrote: > >> branch: master >> commit 506270f9c80bf9bd7dad35a2f0aa6f477da6490b > [...] >> * lisp/ses.el (ses--advice-copy-region-as-kill): avoid comparison >> unless `beg' and `end' are non-nil. > > This is https://debbugs.gnu.org/28039, which seems like something to > fix in the emacs-26 branch. Thanks. AFAIK emacs-26 is open only for documentation and regressions. This bug existed since the beginning of SES. OTOH, it looks quite safe. I have no problem about backporting it to emacs-26. Eli?