[PATCH] lisp/net/browse-url.el allow fragments in file: urls

[PATCH] lisp/net/browse-url.el allow fragments in file: urls

[Tom Gillespie]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

This fixes the current behavior of browse-url--non-html-file-url-p and
makes it possible to open file:// urls that end with a #fragment. The
current behavior results in a nasty side effect where opening a file
with browse-url-emacs that has a fragment causes any invocation of
call-process to fail because the fragment is not handled correctly.

Best!
Tom

[-- Attachment #2: 0001-lisp-net-browse-url.el-allow-fragments-in-file-urls.patch --]
[-- Type: text/x-patch, Size: 987 bytes --]

From a557f1b9ee397f93ca6b56c1fcc36896e6b4fafc Mon Sep 17 00:00:00 2001
From: Tom Gillespie <tgbugs@gmail.com>
Date: Wed, 31 Mar 2021 18:50:49 -0700
Subject: [PATCH] lisp/net/browse-url.el allow fragments in file:// urls

* lisp/net/browse-url.el (browse-url--non-html-file-url-p): Update
regexp to match file:// urls that end in a fragment.
---
 lisp/net/browse-url.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
index 1c98335a20..aef221e9d7 100644
--- a/lisp/net/browse-url.el
+++ b/lisp/net/browse-url.el
@@ -617,7 +617,7 @@ browse-url--browser-kind-browser
 (defun browse-url--non-html-file-url-p (url)
   "Return non-nil if URL is a file:// URL of a non-HTML file."
   (and (string-match-p "\\`file://" url)
-       (not (string-match-p "\\`file://.*\\.html?\\b" url))))
+       (not (string-match-p "\\`file://.*\\.html?\\(#.*\\)?\\b" url))))
 
 ;;;###autoload
 (defvar browse-url-default-handlers
-- 
2.26.3

Re: [PATCH] lisp/net/browse-url.el allow fragments in file: urls

[Eli Zaretskii]

> From: Tom Gillespie <tgbugs@gmail.com>
> Date: Wed, 31 Mar 2021 19:16:32 -0700
> 
> This fixes the current behavior of browse-url--non-html-file-url-p and
> makes it possible to open file:// urls that end with a #fragment. The
> current behavior results in a nasty side effect where opening a file
> with browse-url-emacs that has a fragment causes any invocation of
> call-process to fail because the fragment is not handled correctly.

Thanks, but can you show a test case for this (or, better yet, write a
test for our test suite)?

Re: [PATCH] lisp/net/browse-url.el allow fragments in file: urls

[Tom Gillespie]

Hi Eli,
   I've added a few tests, but in the process discovered that
something strange seems to be going on (possibly of the dynamic
variable kind) so this patch should be put on hold until I understand
what is going wrong. Best!
Tom

Re: [PATCH] lisp/net/browse-url.el allow fragments in file: urls

[Eli Zaretskii]

> From: Tom Gillespie <tgbugs@gmail.com>
> Date: Thu, 1 Apr 2021 17:22:07 -0700
> Cc: emacs-devel@gnu.org
> 
> Hi Eli,
>    I've added a few tests, but in the process discovered that
> something strange seems to be going on (possibly of the dynamic
> variable kind) so this patch should be put on hold until I understand
> what is going wrong. Best!

Thanks.  Please take your time, there's no rush.