From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] lisp/net/browse-url.el allow fragments in file: urls
Date: Thu, 01 Apr 2021 10:20:20 +0300
Message-ID: <83o8eyh3nv.fsf@gnu.org>
References: <CA+G3_PN-vSetiVmtY8Ewj3Cuu1LqhVZrWNP3mFeKLDcmBp-qCQ@mail.gmail.com>
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="21464"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: emacs-devel@gnu.org
To: Tom Gillespie <tgbugs@gmail.com>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 01 09:21:23 2021
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lRrdp-0005QX-PL
	for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Apr 2021 09:21:21 +0200
Original-Received: from localhost ([::1]:35534 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1lRrdo-0002fy-No
	for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Apr 2021 03:21:20 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51804)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>) id 1lRrdL-0002EL-4q
 for emacs-devel@gnu.org; Thu, 01 Apr 2021 03:20:51 -0400
Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49403)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lRrdK-000854-Su; Thu, 01 Apr 2021 03:20:50 -0400
Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1117
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1lRrd6-00084r-Cb; Thu, 01 Apr 2021 03:20:49 -0400
In-Reply-To: <CA+G3_PN-vSetiVmtY8Ewj3Cuu1LqhVZrWNP3mFeKLDcmBp-qCQ@mail.gmail.com>
 (message from Tom Gillespie on Wed, 31 Mar 2021 19:16:32 -0700)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:267238
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/267238>

> From: Tom Gillespie <tgbugs@gmail.com>
> Date: Wed, 31 Mar 2021 19:16:32 -0700
> 
> This fixes the current behavior of browse-url--non-html-file-url-p and
> makes it possible to open file:// urls that end with a #fragment. The
> current behavior results in a nasty side effect where opening a file
> with browse-url-emacs that has a fragment causes any invocation of
> call-process to fail because the fragment is not handled correctly.

Thanks, but can you show a test case for this (or, better yet, write a
test for our test suite)?