From: Eli Zaretskii <eliz@gnu.org>
To: Spencer Baugh <sbaugh@catern.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables
Date: Sun, 04 Apr 2021 10:15:34 +0300 [thread overview]
Message-ID: <83h7kmed0p.fsf@gnu.org> (raw)
In-Reply-To: <87r1jrw0mh.fsf@catern.com> (message from Spencer Baugh on Sat, 03 Apr 2021 16:53:42 -0400)
> From: Spencer Baugh <sbaugh@catern.com>
> Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca
> Date: Sat, 03 Apr 2021 16:53:42 -0400
>
> | Unmodified Emacs | 6.529 |
> | My changes | 6.610 |
> | My changes + no default for bidi_display_reordering | 6.582 |
>
> About a 1-2% slowdown from my changes.
>
> I tried removing the default for bidi_display_reordering; customizing
> bidi-display-reording is explicitly unsupported anyway, so I think
> changing its behavior is reasonable.
>
> That improved performance but unfortunately not enough to fully match an
> unmodified Emacs. Not sure what else to do.
Thanks.
I'm okay with 1-2% slowdown in redisplay, and I don't want to remove
the default value from bidi-display-reordering. Let's hear if someone
else feels that such slowdown in redisplay is a bother; if not, it
sounds like a good tradeoff.
If someone has other good benchmarks before we make the decision,
please speak up.
next prev parent reply other threads:[~2021-04-04 7:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 3:11 [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables Spencer Baugh
2021-03-24 3:11 ` [PATCH 1/7] Add a test for let-binding unwinding Spencer Baugh
2021-03-24 3:11 ` [PATCH 2/7] Assert not local-variable-p after setq in let_default binding Spencer Baugh
2021-03-24 3:11 ` [PATCH 3/7] Stop checking the constant default for enable_multibyte_characters Spencer Baugh
2021-03-24 3:11 ` [PATCH 4/7] Take buffer field name in DEFVAR_PER_BUFFER Spencer Baugh
2021-03-24 3:11 ` [PATCH 5/7] Combine unnecessarily separate loops in buffer.c Spencer Baugh
2021-03-24 3:11 ` [PATCH 6/7] Assert that PER_BUFFER_IDX for Lisp variables is not 0 Spencer Baugh
2021-03-24 3:11 ` [PATCH 7/7] Remove unnecessary Qunbound check Spencer Baugh
2021-03-25 16:46 ` Stefan Monnier
2021-03-24 5:36 ` [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables Eli Zaretskii
2021-03-25 16:48 ` Stefan Monnier
2021-03-25 17:00 ` Eli Zaretskii
2021-04-01 18:13 ` Spencer Baugh
2021-04-01 18:51 ` Eli Zaretskii
2021-04-03 20:53 ` Spencer Baugh
2021-04-04 7:15 ` Eli Zaretskii [this message]
2021-04-01 21:42 ` Stefan Monnier
2021-04-01 23:39 ` Spencer Baugh
2021-04-02 2:55 ` Stefan Monnier
2021-04-02 5:36 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h7kmed0p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=sbaugh@catern.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).