From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 0/7] Cleanups and tests for DEFVAR_PER_BUFFER variables Date: Sun, 04 Apr 2021 10:15:34 +0300 Message-ID: <83h7kmed0p.fsf@gnu.org> References: <87a6qhyish.fsf@catern.com> <83sg49g7n6.fsf@gnu.org> <87r1jrw0mh.fsf@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27706"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Spencer Baugh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 04 09:16:42 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lSwzx-00075k-I9 for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Apr 2021 09:16:41 +0200 Original-Received: from localhost ([::1]:50622 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSwzw-0004ND-JN for ged-emacs-devel@m.gmane-mx.org; Sun, 04 Apr 2021 03:16:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36954) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lSwz2-0003rA-QV for emacs-devel@gnu.org; Sun, 04 Apr 2021 03:15:44 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:37037) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lSwz1-0004Ss-Rp; Sun, 04 Apr 2021 03:15:43 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2131 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lSwz0-0001Hs-R9; Sun, 04 Apr 2021 03:15:43 -0400 In-Reply-To: <87r1jrw0mh.fsf@catern.com> (message from Spencer Baugh on Sat, 03 Apr 2021 16:53:42 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:267380 Archived-At: > From: Spencer Baugh > Cc: emacs-devel@gnu.org, monnier@iro.umontreal.ca > Date: Sat, 03 Apr 2021 16:53:42 -0400 > > | Unmodified Emacs | 6.529 | > | My changes | 6.610 | > | My changes + no default for bidi_display_reordering | 6.582 | > > About a 1-2% slowdown from my changes. > > I tried removing the default for bidi_display_reordering; customizing > bidi-display-reording is explicitly unsupported anyway, so I think > changing its behavior is reasonable. > > That improved performance but unfortunately not enough to fully match an > unmodified Emacs. Not sure what else to do. Thanks. I'm okay with 1-2% slowdown in redisplay, and I don't want to remove the default value from bidi-display-reordering. Let's hear if someone else feels that such slowdown in redisplay is a bother; if not, it sounds like a good tradeoff. If someone has other good benchmarks before we make the decision, please speak up.