unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: "Lars Ingebrigtsen" <larsi@gnus.org>,
	"Rudolf Adamkovič" <salutis@me.com>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp
Date: Sun, 13 Feb 2022 14:19:10 +0200	[thread overview]
Message-ID: <83h793q7r5.fsf@gnu.org> (raw)
In-Reply-To: <87h793yxtm.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun,  13 Feb 2022 09:28:53 +0100)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,  emacs-devel@gnu.org
> Date: Sun, 13 Feb 2022 09:28:53 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > AFAIU, it attempts to show more significant digits when the value is
> > near a round power.
> 
> Looks like it was introduced by this:
> 
> commit 04f33f1ed9cdfed6a3e44a55d333cd19d58424ca
> Author:     Eli Zaretskii <eliz@gnu.org>
> AuthorDate: Sat Apr 9 09:59:26 2011 +0300
> 
>     Produce more accurate results from file-size-human-readable.
>     
>      lisp/files.el (file-size-human-readable): Produce one digit after
>      decimal, like "ls -lh" does.
> 
> But ls -lh does not use a digit after the decimal in this case.  At
> least now -- perhaps it did in 2011?  On Debian/bookworm:
> 
> larsi@giant:~/src/emacs/trunk$ ls -lh /tmp/bytes
> -rw-r--r-- 1 larsi larsi 1006K Feb 12 08:04 /tmp/bytes

Neither does ls-lisp:

  -rw-rw-rw-  1 Zaretskii  1006k 02-13 14:07 test-of-ls.size.txt

I don't think we reproduce the original bug report.  It said:

  -rw-r--r--  1 salutis 1016.1k 12-23 17:05 default

and I don't think we know how many bytes that file actually had.
Rudolf, can you tell us how large was that file in bytes?



  reply	other threads:[~2022-02-13 12:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org>
     [not found] ` <20220212070826.4B772C00895@vcs2.savannah.gnu.org>
2022-02-12 17:25   ` master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Stefan Monnier
2022-02-12 17:33     ` Lars Ingebrigtsen
2022-02-12 18:14       ` Stefan Monnier
2022-02-12 19:03     ` Eli Zaretskii
2022-02-12 19:15       ` Stefan Monnier
2022-02-12 19:38         ` Eli Zaretskii
2022-02-12 19:42           ` Stefan Monnier
2022-02-12 19:53             ` Eli Zaretskii
2022-02-12 20:32               ` Stefan Monnier
2022-02-13  6:24                 ` Eli Zaretskii
2022-02-13  8:28                   ` Lars Ingebrigtsen
2022-02-13 12:19                     ` Eli Zaretskii [this message]
2022-02-13 12:36                       ` Lars Ingebrigtsen
2022-02-13 12:55                         ` Eli Zaretskii
2022-02-13 13:40                           ` Eli Zaretskii
2022-02-14 10:48                             ` Lars Ingebrigtsen
2022-02-14 12:19                               ` Eli Zaretskii
2022-02-14 13:38                                 ` Stefan Monnier
2022-02-14 14:20                                 ` Lars Ingebrigtsen
2022-02-14 17:01                                   ` Eli Zaretskii
2022-02-15 20:05                                     ` Rudolf Adamkovič

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h793q7r5.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).