unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: salutis@me.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp
Date: Mon, 14 Feb 2022 14:19:03 +0200	[thread overview]
Message-ID: <83o839prns.fsf@gnu.org> (raw)
In-Reply-To: <87y22dsoz9.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon,  14 Feb 2022 11:48:42 +0100)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: salutis@me.com,  monnier@iro.umontreal.ca,  emacs-devel@gnu.org
> Date: Mon, 14 Feb 2022 11:48:42 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > So how about the patch below:
> >
> > diff --git a/lisp/files.el b/lisp/files.el
> > index cfa1a59..7e62726 100644
> > --- a/lisp/files.el
> > +++ b/lisp/files.el
> > @@ -1494,7 +1494,8 @@ file-size-human-readable
> >                                 (or unit "B"))
> >                              (concat prefix unit))))
> >        (format (if (and (>= (mod file-size 1.0) 0.05)
> > -                       (< (mod file-size 1.0) 0.95))
> > +                       (< (mod file-size 1.0) 0.95)
> > +                       (< file-size 10))
> 
> Possibly, but it's hard to tell...  perhaps a better test is whether the
> printed representation is longer than 6 characters, and then precision
> should be reduced.

I thought we wanted to mimic what GNU 'ls' does?  AFAICT, it shows the
fractional part only for values whose integral part is less than 10,
i.e. takes just one digit.  So that's what the above change does.

If you run "ls -lh" on a large directory, do you see something
different from my description above?



  reply	other threads:[~2022-02-14 12:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org>
     [not found] ` <20220212070826.4B772C00895@vcs2.savannah.gnu.org>
2022-02-12 17:25   ` master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Stefan Monnier
2022-02-12 17:33     ` Lars Ingebrigtsen
2022-02-12 18:14       ` Stefan Monnier
2022-02-12 19:03     ` Eli Zaretskii
2022-02-12 19:15       ` Stefan Monnier
2022-02-12 19:38         ` Eli Zaretskii
2022-02-12 19:42           ` Stefan Monnier
2022-02-12 19:53             ` Eli Zaretskii
2022-02-12 20:32               ` Stefan Monnier
2022-02-13  6:24                 ` Eli Zaretskii
2022-02-13  8:28                   ` Lars Ingebrigtsen
2022-02-13 12:19                     ` Eli Zaretskii
2022-02-13 12:36                       ` Lars Ingebrigtsen
2022-02-13 12:55                         ` Eli Zaretskii
2022-02-13 13:40                           ` Eli Zaretskii
2022-02-14 10:48                             ` Lars Ingebrigtsen
2022-02-14 12:19                               ` Eli Zaretskii [this message]
2022-02-14 13:38                                 ` Stefan Monnier
2022-02-14 14:20                                 ` Lars Ingebrigtsen
2022-02-14 17:01                                   ` Eli Zaretskii
2022-02-15 20:05                                     ` Rudolf Adamkovič

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o839prns.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=larsi@gnus.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).