From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 2b97e83cc1 2/2: Fix off-by-one file size formatting in ls-lisp Date: Sun, 13 Feb 2022 14:19:10 +0200 Message-ID: <83h793q7r5.fsf@gnu.org> References: <164464970577.18616.16858189491672331595@vcs2.savannah.gnu.org> <20220212070826.4B772C00895@vcs2.savannah.gnu.org> <83y22frjpy.fsf@gnu.org> <83tud3ri2n.fsf@gnu.org> <83r187rhd8.fsf@gnu.org> <83pmnrqo5m.fsf@gnu.org> <87h793yxtm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32150"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Lars Ingebrigtsen , Rudolf =?utf-8?Q?Adamkovi=C4=8D?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Feb 13 13:19:55 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nJDr8-0008Ck-6C for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 13:19:54 +0100 Original-Received: from localhost ([::1]:34848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJDr6-00017b-MX for ged-emacs-devel@m.gmane-mx.org; Sun, 13 Feb 2022 07:19:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJDqV-0000Sn-5o for emacs-devel@gnu.org; Sun, 13 Feb 2022 07:19:15 -0500 Original-Received: from [2001:470:142:3::e] (port=34572 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJDqU-00048S-HS; Sun, 13 Feb 2022 07:19:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=R7FEUFRgnTmk0FU6Ga79t3bfppqKKKcUARtu6QwOSi4=; b=GhRbeo34pM29yl2K2Awq 4kpFM2UxW8xa0ZASwjuGH2mcRdpZzk97fBvyzO508FqAgTuxlY2D2S9q1ulZRspZOr/nxYTJ4bZWu MLXBAIcNPLYoTsuvB5xbsEpolTECalA5Rfvgy/4SZFPD9XeFPpPzqgBUdrTbiIvqFqbbfby7nB4jn g/f+VEhMY+PBUaG9am/AROoYbyFIo6n9gtv8aZcbsEgx+hdE1qN+RWP3haWQATLFKDKTxPhcxN1au hKmDG3t9epEaLcqSZnyJdOpgCKfFYdJyh8HPK2Sw3AvWEilJSnGp6sbNYRUVMd/913rBmpBIRUlOg C+Q9KLi1ZilYPw==; Original-Received: from [87.69.77.57] (port=3660 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJDqU-0002ZC-16; Sun, 13 Feb 2022 07:19:14 -0500 In-Reply-To: <87h793yxtm.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 13 Feb 2022 09:28:53 +0100) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286207 Archived-At: > From: Lars Ingebrigtsen > Cc: Stefan Monnier , emacs-devel@gnu.org > Date: Sun, 13 Feb 2022 09:28:53 +0100 > > Eli Zaretskii writes: > > > AFAIU, it attempts to show more significant digits when the value is > > near a round power. > > Looks like it was introduced by this: > > commit 04f33f1ed9cdfed6a3e44a55d333cd19d58424ca > Author: Eli Zaretskii > AuthorDate: Sat Apr 9 09:59:26 2011 +0300 > > Produce more accurate results from file-size-human-readable. > > lisp/files.el (file-size-human-readable): Produce one digit after > decimal, like "ls -lh" does. > > But ls -lh does not use a digit after the decimal in this case. At > least now -- perhaps it did in 2011? On Debian/bookworm: > > larsi@giant:~/src/emacs/trunk$ ls -lh /tmp/bytes > -rw-r--r-- 1 larsi larsi 1006K Feb 12 08:04 /tmp/bytes Neither does ls-lisp: -rw-rw-rw- 1 Zaretskii 1006k 02-13 14:07 test-of-ls.size.txt I don't think we reproduce the original bug report. It said: -rw-r--r-- 1 salutis 1016.1k 12-23 17:05 default and I don't think we know how many bytes that file actually had. Rudolf, can you tell us how large was that file in bytes?