unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Andy Moreton <andrewjmoreton@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Testing native image scaling
Date: Thu, 28 Mar 2019 22:09:40 +0200	[thread overview]
Message-ID: <83ftr6kbgb.fsf@gnu.org> (raw)
In-Reply-To: <vz1pnqa4x1y.fsf@gmail.com> (message from Andy Moreton on Thu, 28 Mar 2019 19:29:45 +0000)

> From: Andy Moreton <andrewjmoreton@gmail.com>
> Date: Thu, 28 Mar 2019 19:29:45 +0000
> 
> >> Should the <kp-subtract> and <kp-add> bindings for `image-decrease-size'
> >> and `image-increase-size' be adjusted to handle sliced images ?
> >
> > It would be nice, yes.
> 
> A little experimentation shows that changing `image--get-image' as below
> seems to be sufficient to work for normal and sliced images:
> 
> (defun image--get-image ()
>   "Return the image at point."
>   (let ((image (get-char-property (point) 'display))
>         result)
>     (when (consp image)
>       (if (eq (car image) 'image)
>           (setq result image)
>         (dolist (x image)
>           (if (eq (car-safe x) 'image)
>               (setq result x)))))
>     (when (null result)
>       (error "No image under point"))
>     result))

LGTM, thanks.

> >> Is image rotation expected to work on Windows ?
> >
> > Not without ImageMagick, no.  (And not only on Windows, AFAIK.)
> 
> ok, but if ImageMagick is not available it used to complain and now does
> not. It should still report the same error message rather than failing
> silently.

The error message is bogus anyway, as it talks about rescaling,
instead of talking about rotating.  IOW, it's a bug in the message
that should be fixed.



      reply	other threads:[~2019-03-28 20:09 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-19  9:31 Testing native image scaling Eli Zaretskii
2019-01-19 21:45 ` Alan Third
2019-01-20 16:05   ` Eli Zaretskii
2019-01-20 19:26     ` Alan Third
2019-01-20 19:41       ` Eli Zaretskii
2019-01-20 20:19         ` Alan Third
2019-03-27  2:35     ` YAMAMOTO Mitsuharu
2019-03-27 17:09       ` Eli Zaretskii
2019-03-27 18:35         ` Andy Moreton
2019-03-27 18:42           ` Eli Zaretskii
2019-03-27 19:06             ` Andy Moreton
2019-03-27 19:34               ` Andy Moreton
2019-03-28  2:26           ` YAMAMOTO Mitsuharu
2019-03-28 16:02             ` Eli Zaretskii
2019-03-28 18:06               ` Andy Moreton
2019-03-28 18:19                 ` Eli Zaretskii
2019-03-28 19:29                   ` Andy Moreton
2019-03-28 20:09                     ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ftr6kbgb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).