unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andy Moreton <andrewjmoreton@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: Testing native image scaling
Date: Wed, 27 Mar 2019 18:35:09 +0000	[thread overview]
Message-ID: <vz136n8i2si.fsf@gmail.com> (raw)
In-Reply-To: 838sx0kzw9.fsf@gnu.org

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

On Wed 27 Mar 2019, Eli Zaretskii wrote:

>> Date: Wed, 27 Mar 2019 11:35:26 +0900
>> From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
>> Cc: Alan Third <alan@idiocy.org>,
>> 	emacs-devel@gnu.org
>> 
>>   (insert-sliced-image (create-image "splash.png" nil nil :scale 0.5) nil nil 3 5)
>> 
>> Actually, I suspect this does not work on W32 because the comparison
>> with the original image size is made for s->slice.width (or height)
>> rather than s->img->width (or height) as I just did for cairo code.
>> Could you check it on W32?
>
> It seems to work, but maybe I don't know what and how to check.  Can
> you show what I should expect to see with and without the :scale
> attribute, in "emacs -Q"?
>
> Thanks.

I would expect a sliced image to be composed of a grid of tiled images
instead of a single image, but to have the same visual appearance as the
original image. The w32 code does not get this right.


[-- Attachment #2: w32-sliced-image.png --]
[-- Type: image/png, Size: 18415 bytes --]

[-- Attachment #3: Type: text/plain, Size: 182 bytes --]


Adding the ":scale 0.5" argument scales down the tiled array of images
correctly, but they still contain the same display artifacts as the
sliced image without scaling.

    AndyM


  reply	other threads:[~2019-03-27 18:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-19  9:31 Testing native image scaling Eli Zaretskii
2019-01-19 21:45 ` Alan Third
2019-01-20 16:05   ` Eli Zaretskii
2019-01-20 19:26     ` Alan Third
2019-01-20 19:41       ` Eli Zaretskii
2019-01-20 20:19         ` Alan Third
2019-03-27  2:35     ` YAMAMOTO Mitsuharu
2019-03-27 17:09       ` Eli Zaretskii
2019-03-27 18:35         ` Andy Moreton [this message]
2019-03-27 18:42           ` Eli Zaretskii
2019-03-27 19:06             ` Andy Moreton
2019-03-27 19:34               ` Andy Moreton
2019-03-28  2:26           ` YAMAMOTO Mitsuharu
2019-03-28 16:02             ` Eli Zaretskii
2019-03-28 18:06               ` Andy Moreton
2019-03-28 18:19                 ` Eli Zaretskii
2019-03-28 19:29                   ` Andy Moreton
2019-03-28 20:09                     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=vz136n8i2si.fsf@gmail.com \
    --to=andrewjmoreton@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).