From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Testing native image scaling Date: Thu, 28 Mar 2019 22:09:40 +0200 Message-ID: <83ftr6kbgb.fsf@gnu.org> References: <83fttpat8p.fsf@gnu.org> <20190119214543.GA13967@breton.holly.idiocy.org> <834la3b9hd.fsf@gnu.org> <838sx0kzw9.fsf@gnu.org> <83va03j8c0.fsf@gnu.org> <83k1gikgjy.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="222154"; mail-complaints-to="usenet@blaine.gmane.org" Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 28 21:09:50 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h9bLS-000vgx-2F for ged-emacs-devel@m.gmane.org; Thu, 28 Mar 2019 21:09:50 +0100 Original-Received: from localhost ([127.0.0.1]:41454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9bLR-00017S-22 for ged-emacs-devel@m.gmane.org; Thu, 28 Mar 2019 16:09:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9bLK-00017M-5Z for emacs-devel@gnu.org; Thu, 28 Mar 2019 16:09:42 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:43694) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h9bLK-0002LF-0D; Thu, 28 Mar 2019 16:09:42 -0400 Original-Received: from [176.228.60.248] (port=4737 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h9bLJ-0003lj-A2; Thu, 28 Mar 2019 16:09:41 -0400 In-reply-to: (message from Andy Moreton on Thu, 28 Mar 2019 19:29:45 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:234808 Archived-At: > From: Andy Moreton > Date: Thu, 28 Mar 2019 19:29:45 +0000 > > >> Should the and bindings for `image-decrease-size' > >> and `image-increase-size' be adjusted to handle sliced images ? > > > > It would be nice, yes. > > A little experimentation shows that changing `image--get-image' as below > seems to be sufficient to work for normal and sliced images: > > (defun image--get-image () > "Return the image at point." > (let ((image (get-char-property (point) 'display)) > result) > (when (consp image) > (if (eq (car image) 'image) > (setq result image) > (dolist (x image) > (if (eq (car-safe x) 'image) > (setq result x))))) > (when (null result) > (error "No image under point")) > result)) LGTM, thanks. > >> Is image rotation expected to work on Windows ? > > > > Not without ImageMagick, no. (And not only on Windows, AFAIK.) > > ok, but if ImageMagick is not available it used to complain and now does > not. It should still report the same error message rather than failing > silently. The error message is bogus anyway, as it talks about rescaling, instead of talking about rotating. IOW, it's a bug in the message that should be fixed.