Empty tooltips under X

Empty tooltips under X

[martin rudalics]

Dear people

With current master/trunk tooltips under X are broken here.  I get a box
with correct borders/background and correct dimensions but without text.
Can anyone see that?

Tooltips under Windows are not affected.

Thanks, martin

Re: Empty tooltips under X

[Tassilo Horn]

martin rudalics <rudalics@gmx.at> writes:

Hi Martin,

> With current master/trunk tooltips under X are broken here.  I get a
> box with correct borders/background and correct dimensions but without
> text.  Can anyone see that?

I'm on

,----[ C-h v emacs-repository-version RET ]
| emacs-repository-version is a variable defined in ‘version.el’.
| Its value is "9db11fa2d635935318364370f31821023c2501b9"
| 
| Documentation:
| String giving the repository revision from which this Emacs was built.
| Value is nil if Emacs was not built from a repository checkout,
| or if we could not determine the revision.
`----

and (tooltip-show "This is a test tooltip") shows the tip correctly.
Emacs is built with GTK3 support.

Bye,
Tassilo

Re: Empty tooltips under X

[martin rudalics]

 > Hi Martin,
 >
 >> With current master/trunk tooltips under X are broken here.  I get a
 >> box with correct borders/background and correct dimensions but without
 >> text.  Can anyone see that?
 >
 > I'm on
 >
 > ,----[ C-h v emacs-repository-version RET ]
 > | emacs-repository-version is a variable defined in ‘version.el’.
 > | Its value is "9db11fa2d635935318364370f31821023c2501b9"
 > |
 > | Documentation:
 > | String giving the repository revision from which this Emacs was built.
 > | Value is nil if Emacs was not built from a repository checkout,
 > | or if we could not determine the revision.
 > `----
 >
 > and (tooltip-show "This is a test tooltip") shows the tip correctly.
 > Emacs is built with GTK3 support.

Indeed, GTK+ tooltip support still works.  What happens when you set
‘x-gtk-use-system-tooltips’ to nil?

martin

Re: Empty tooltips under X

[Tassilo Horn]

martin rudalics <rudalics@gmx.at> writes:

>>> With current master/trunk tooltips under X are broken here.  I get a
>>> box with correct borders/background and correct dimensions but without
>>> text.  Can anyone see that?
>>
>> I'm on
>>
>> ,----[ C-h v emacs-repository-version RET ]
>> | emacs-repository-version is a variable defined in ‘version.el’.
>> | Its value is "9db11fa2d635935318364370f31821023c2501b9"
>> |
>> | Documentation:
>> | String giving the repository revision from which this Emacs was built.
>> | Value is nil if Emacs was not built from a repository checkout,
>> | or if we could not determine the revision.
>> `----
>>
>> and (tooltip-show "This is a test tooltip") shows the tip correctly.
>> Emacs is built with GTK3 support.
>
> Indeed, GTK+ tooltip support still works.  What happens when you set
> ‘x-gtk-use-system-tooltips’ to nil?

The text is still shown.  Because the tooltips looks identical to the
GTK version, I also stepped thru `x-show-tip' in order to validate we're
really using Emacs' own tooltip code.

Bye,
Tassilo

Re: Empty tooltips under X

[Kaushal Modi]

> With current master/trunk tooltips under X are broken here.  I get a box
> with correct borders/background and correct dimensions but without text.
> Can anyone see that?

The tooltip is working fine for me.

>  (tooltip-show "This is a test tooltip") shows the tip correctly.

Same here.

> What happens when you set ‘x-gtk-use-system-tooltips’ to nil?

OK. So now when I eval the below,

(let (x-gtk-use-system-tooltips)
  (tooltip-show "This is a test tooltip"))

I get an empty tooltip, but with different background color and border
style than when I eval just (tooltip-show "This is a test tooltip")


Built on x86_64-unknown-linux-gnu

Configure options: --prefix=/home/kmodi/usr_local/apps/6/emacs/master
'CPPFLAGS=-fgnu89-inline -I/home/kmodi/usr_local/6/include
-I/usr/include/freetype2 -I/usr/include' 'CFLAGS=-ggdb3 -O0'
'CXXFLAGS=-ggdb3 -O0' 'LDFLAGS=-L/home/kmodi/usr_local/6/lib
-L/home/kmodi/usr_local/6/lib64 -ggdb3'

Features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GCONF
GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE LIBOTF XFT
ZLIB TOOLKIT_SCROLL_BARS GTK2 X11

Re: Empty tooltips under X

[martin rudalics]

 >> Indeed, GTK+ tooltip support still works.  What happens when you set
 >> ‘x-gtk-use-system-tooltips’ to nil?
 >
 > The text is still shown.  Because the tooltips looks identical to the
 > GTK version, I also stepped thru `x-show-tip' in order to validate we're
 > really using Emacs' own tooltip code.

Looks like a Heisenbug.  Sometimes the tooltip is shown for a very short
moment only, sometimes it's shown quite normally, sometimes not at all.

martin

Re: Empty tooltips under X

[martin rudalics]

 > OK. So now when I eval the below,
 >
 > (let (x-gtk-use-system-tooltips)
 >    (tooltip-show "This is a test tooltip"))
 >
 > I get an empty tooltip, but with different background color and border

Because this is the Emacs tooltip where you can customize the
background.  The other one is the tooltip provided by Gtk+ where the
background is theirs.

 > style than when I eval just (tooltip-show "This is a test tooltip")

Can you reproduce that reliably?  With emacs -Q?

martin

Re: Empty tooltips under X

[Kaushal Modi]

My earlier observation was NOT in emacs -Q.

With emacs -Q, I do get the tooltip consistently with
x-gtk-use-system-tooltips set to nil or t.

But with my emacs config, the tooltip shows up consistently only with
the default value of x-gtk-use-system-tooltips (t).

But about,

> Can you reproduce that reliably?

I got the tooltip to show up just once (out of like 10 times) with my
emacs config with x-gtk-use-system-tooltips set to nil.

Re: Empty tooltips under X

[Kaushal Modi]

Oh I emailed too soon. I saw some odd behavior when evaluating the
below in emacs using my config,

(let (x-gtk-use-system-tooltips)
  (tooltip-show "This is a test tooltip"))

The tooltip text does show up but after a delay of about 4-5 seconds.

Re: Empty tooltips under X

[Eli Zaretskii]

> Date: Wed, 28 Oct 2015 20:20:23 +0100
> From: martin rudalics <rudalics@gmx.at>
> 
>  >> Indeed, GTK+ tooltip support still works.  What happens when you set
>  >> ‘x-gtk-use-system-tooltips’ to nil?
>  >
>  > The text is still shown.  Because the tooltips looks identical to the
>  > GTK version, I also stepped thru `x-show-tip' in order to validate we're
>  > really using Emacs' own tooltip code.
> 
> Looks like a Heisenbug.  Sometimes the tooltip is shown for a very short
> moment only, sometimes it's shown quite normally, sometimes not at all.

If you invoke trace-redisplay (after turning off blink-cursor-mode),
then make the tooltip appear several times, do you see different
traces depending on whether you see or don't see the text?

Re: Empty tooltips under X

[martin rudalics]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

  > Looks like a Heisenbug.  Sometimes the tooltip is shown for a very short
  > moment only, sometimes it's shown quite normally, sometimes not at all.

I've been able to trace this back to the following commit:

[9d6ec23f7d4f8fbbfdcea353c4b58e47f76a7342] Update frame title when redisplay scrolls selected window

Any objections against the attached patch?

martin


[-- Attachment #2: xdisp.diff --]
[-- Type: text/plain, Size: 501 bytes --]

--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -11541,9 +11541,10 @@ x_consider_frame_title (Lisp_Object frame)
 {
   struct frame *f = XFRAME (frame);

-  if (FRAME_WINDOW_P (f)
-      || FRAME_MINIBUF_ONLY_P (f)
-      || f->explicit_name)
+  if ((FRAME_WINDOW_P (f)
+       || FRAME_MINIBUF_ONLY_P (f)
+       || f->explicit_name)
+      && NILP (Fframe_parameter (frame, Qtooltip)))
     {
       /* Do we have more than one visible frame on this X display?  */
       Lisp_Object tail, other_frame, fmt;

Re: Empty tooltips under X

[Eli Zaretskii]

> Date: Fri, 06 Nov 2015 19:13:27 +0100
> From: martin rudalics <rudalics@gmx.at>
> 
>   > Looks like a Heisenbug.  Sometimes the tooltip is shown for a very short
>   > moment only, sometimes it's shown quite normally, sometimes not at all.
> 
> I've been able to trace this back to the following commit:
> 
> [9d6ec23f7d4f8fbbfdcea353c4b58e47f76a7342] Update frame title when redisplay scrolls selected window
> 
> Any objections against the attached patch?

None whatsoever.  Thanks.

Re: Empty tooltips under X

[martin rudalics]

>> Any objections against the attached patch?
>
> None whatsoever.  Thanks.

Applied.

martin

Re: Empty tooltips under X

[Kaushal Modi]

> Applied.

Just FYI, this patch fixes the issue for me too. Thanks!