unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: emacs-devel <emacs-devel@gnu.org>, "eliz@gnu.org" <eliz@gnu.org>
Subject: Re: Empty tooltips under X
Date: Fri, 06 Nov 2015 19:13:27 +0100	[thread overview]
Message-ID: <563CEDC7.2060204@gmx.at> (raw)
In-Reply-To: <56311FF7.9070304@gmx.at>

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

  > Looks like a Heisenbug.  Sometimes the tooltip is shown for a very short
  > moment only, sometimes it's shown quite normally, sometimes not at all.

I've been able to trace this back to the following commit:

[9d6ec23f7d4f8fbbfdcea353c4b58e47f76a7342] Update frame title when redisplay scrolls selected window

Any objections against the attached patch?

martin


[-- Attachment #2: xdisp.diff --]
[-- Type: text/plain, Size: 501 bytes --]

--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -11541,9 +11541,10 @@ x_consider_frame_title (Lisp_Object frame)
 {
   struct frame *f = XFRAME (frame);

-  if (FRAME_WINDOW_P (f)
-      || FRAME_MINIBUF_ONLY_P (f)
-      || f->explicit_name)
+  if ((FRAME_WINDOW_P (f)
+       || FRAME_MINIBUF_ONLY_P (f)
+       || f->explicit_name)
+      && NILP (Fframe_parameter (frame, Qtooltip)))
     {
       /* Do we have more than one visible frame on this X display?  */
       Lisp_Object tail, other_frame, fmt;

  parent reply	other threads:[~2015-11-06 18:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 10:01 Empty tooltips under X martin rudalics
2015-10-28 10:21 ` Tassilo Horn
2015-10-28 10:45   ` martin rudalics
2015-10-28 13:23     ` Tassilo Horn
2015-10-28 14:09       ` Kaushal Modi
2015-10-28 19:20         ` martin rudalics
2015-10-28 19:47           ` Kaushal Modi
2015-10-28 19:51             ` Kaushal Modi
2015-10-28 19:20       ` martin rudalics
2015-10-28 20:08         ` Eli Zaretskii
2015-11-06 18:13         ` martin rudalics [this message]
2015-11-06 19:26           ` Eli Zaretskii
2015-11-07 13:26             ` martin rudalics
2015-11-10 19:13               ` Kaushal Modi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563CEDC7.2060204@gmx.at \
    --to=rudalics@gmx.at \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).