From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Testing redisplay code in batch Date: Thu, 24 Sep 2020 21:58:28 +0300 Message-ID: <83blhvt31n.fsf@gnu.org> References: <83zh5ftffa.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6259"; mail-complaints-to="usenet@ciao.gmane.io" Cc: psainty@orcon.net.nz, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 24 21:13:31 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLWgN-0001Xd-8o for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 21:13:31 +0200 Original-Received: from localhost ([::1]:60922 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLWgM-0006QK-Bh for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 15:13:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLWRk-0004Rb-WF for emacs-devel@gnu.org; Thu, 24 Sep 2020 14:58:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39173) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLWRj-0002y4-9X; Thu, 24 Sep 2020 14:58:23 -0400 Original-Received: from [176.228.60.248] (port=3326 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kLWRh-0006y4-6B; Thu, 24 Sep 2020 14:58:22 -0400 In-Reply-To: (message from Stefan Monnier on Thu, 24 Sep 2020 14:31:58 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256400 Archived-At: > From: Stefan Monnier > Cc: psainty@orcon.net.nz, emacs-devel@gnu.org > Date: Thu, 24 Sep 2020 14:31:58 -0400 > > Based on your comments, I assume you consider that this feature is > acceptable for `master` once it's clean. Sure, why not? It looks useful. > /* No actual display to update so the "update" is a nop and > obviously isn't interrupted by pending input. */ > paused_p = false; OK. > Without it I got an assertion failure in xdisp.c:18241 > > if (MINI_WINDOW_P (w)) > { > if (w == XWINDOW (echo_area_window) > && !NILP (echo_area_buffer[0])) > > because XWINDOW complains that `echo_area_window` is not a window. > > Maybe the better fix is to change `init_xdisp` so it also sets > `echo_area_window` when `noninteractive`? Yes, I think so. > Do you think it's otherwise acceptable as-is? I was thinking of only > allowing redisplay in `FRAME_INITIAL_P` under the control of some > special config var. A command-line option, perhaps? I agree that the "normal" -batch should probably continue working as it does now. And yes, I think it's okay to go in. I bet it may not support too many display features, but we can always extend it as we go. > > How about a small NEWS item about this? > > I'll see to it, Thanks.