From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: master 262d0c6: Mark some tests as expensive Date: Sat, 12 Sep 2020 14:24:08 +0300 Message-ID: <837dszdyqv.fsf@gnu.org> References: <20200910182904.20559.25935@vcs0.savannah.gnu.org> <20200910182905.F0E4520A2E@vcs0.savannah.gnu.org> <877dt0is0p.fsf@gmx.de> <83a6xve0vq.fsf@gnu.org> <87a6xv456t.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39170"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefan@marxist.se, emacs-devel@gnu.org, michael.albinus@gmx.de, mardani29@yahoo.es To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 12 13:24:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kH3eB-000A6V-Kx for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 13:24:47 +0200 Original-Received: from localhost ([::1]:40698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH3eA-0001e0-OI for ged-emacs-devel@m.gmane-mx.org; Sat, 12 Sep 2020 07:24:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kH3db-00019p-M9 for emacs-devel@gnu.org; Sat, 12 Sep 2020 07:24:11 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:33467) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kH3db-0006cc-1d; Sat, 12 Sep 2020 07:24:11 -0400 Original-Received: from [176.228.60.248] (port=3179 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kH3da-0008TM-BR; Sat, 12 Sep 2020 07:24:10 -0400 In-Reply-To: <87a6xv456t.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 12 Sep 2020 13:15:06 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255302 Archived-At: > From: Lars Ingebrigtsen > Cc: Daniel Martín , > michael.albinus@gmx.de, > stefan@marxist.se, emacs-devel@gnu.org > Date: Sat, 12 Sep 2020 13:15:06 +0200 > > Eli Zaretskii writes: > > > I also don't understand the more general issue with how long the test > > suite runs. While it runs, you can do something useful on a modern > > system (or just go for a coffee), so why does it matter? > > I appreciate a fast test suite -- I often do a "make check" before > pushing just to see that nothing was inadvertently broken by a > seemingly-innocuous change. How will that work if the change was in Tramp, or was related to Tramp? In my case, for example, it would most probably mean none of the Tramp tests will ever run at all, because they all take more than 1 sec down here. Also, there are some tests with inherent delays (auto-revert tests are one example, but there are others) -- would that mean we don't run these, either? What I do for a "fast test" use case is to run only the tests directly related to the change, usually the FOO-tests.el tests that correspond to the file FOO I've changed. Sometimes, there are related tests in other files as well. A simple "make FOO-tests" command is all that's needed. IOW, I don't think the time to run the tests is a good criterion, at least not if applied globally to the entire suite.