From: Eli Zaretskii <eliz@gnu.org>
To: Yoni Rabkin <yoni@rabkins.net>
Cc: emacs-devel@gnu.org
Subject: Re: eww bookmarks code naming for interactive functions
Date: Wed, 24 May 2023 19:45:54 +0300 [thread overview]
Message-ID: <835y8hoeyl.fsf@gnu.org> (raw)
In-Reply-To: <875y8hsng3.fsf@rabkins.net> (message from Yoni Rabkin on Wed, 24 May 2023 12:29:00 -0400)
> From: Yoni Rabkin <yoni@rabkins.net>
> Date: Wed, 24 May 2023 12:29:00 -0400
>
> Would y'all accept a patch which changes function names such as
> `eww-bookmark-kill' to `eww-kill-bookmark'?
These commands exist since Emacs 28, AFAICT, so simply renaming them
now is not possible anymore. But we can provide aliases by the new
names, which then will make this acceptable.
There's another aspect to this: renaming these will make some commands
harder to complete. For example, there's already eww-browse, so
having eww-browse-bookmark will make eww-browse slightly harder to
invoke. And for eww-next/previous-bookmark, I think having
eww-bookmark-next/previous instead would make awkward names.
Something to consider as a certain downside of your suggestion, I
guess.
Thanks.
prev parent reply other threads:[~2023-05-24 16:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 16:29 eww bookmarks code naming for interactive functions Yoni Rabkin
2023-05-24 16:45 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y8hoeyl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=yoni@rabkins.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).