From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: eww bookmarks code naming for interactive functions Date: Wed, 24 May 2023 19:45:54 +0300 Message-ID: <835y8hoeyl.fsf@gnu.org> References: <875y8hsng3.fsf@rabkins.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33844"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yoni Rabkin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 24 18:46:57 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q1rdZ-0008aY-L5 for ged-emacs-devel@m.gmane-mx.org; Wed, 24 May 2023 18:46:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q1rcm-0006Ix-Dd; Wed, 24 May 2023 12:46:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1rcb-0006IF-EV for emacs-devel@gnu.org; Wed, 24 May 2023 12:45:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1rca-0006J5-Sb; Wed, 24 May 2023 12:45:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Z+UECezX0gpnCTzP7mQbY/IuZllToofxWyZjkgoRjwc=; b=UtPeC2Ti8lR5 4zbyOsmQy7fvGzX43IJTEZzF/z1S92Uk7BSm+O77QoZYcgDTD2UcjlZmYASSdnF32tina2M5NUbQb DH8AKP9SMDBwdG3uhBSUjjH8OpliMcEjcJ9D90tyuREl9rwSIj3zcB+wcPtgv+tdz/Fv7de7C3Ajv p2kCVFfI8EhMWfVLm+R2qcWbEPMHLIiiMCV+kOuGLUFmc4lPDKgHygoetaxXATLobNDDVAxy6jlPY FPsDe6pLLqOtfYa0ZNnuON6e9t5vqYipSOzpzICbYL5d9ZU0hx4r+QdHTUMbpHa8sqvvWEI4ZNg+D y/DmEcj1ElOAWJJ13CtFwQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q1rc6-0005Z2-Nf; Wed, 24 May 2023 12:45:54 -0400 In-Reply-To: <875y8hsng3.fsf@rabkins.net> (message from Yoni Rabkin on Wed, 24 May 2023 12:29:00 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306304 Archived-At: > From: Yoni Rabkin > Date: Wed, 24 May 2023 12:29:00 -0400 > > Would y'all accept a patch which changes function names such as > `eww-bookmark-kill' to `eww-kill-bookmark'? These commands exist since Emacs 28, AFAICT, so simply renaming them now is not possible anymore. But we can provide aliases by the new names, which then will make this acceptable. There's another aspect to this: renaming these will make some commands harder to complete. For example, there's already eww-browse, so having eww-browse-bookmark will make eww-browse slightly harder to invoke. And for eww-next/previous-bookmark, I think having eww-bookmark-next/previous instead would make awkward names. Something to consider as a certain downside of your suggestion, I guess. Thanks.