* master e3b8ddd: Speed up by storing frame faces in hash tables instead of alists
@ 2021-07-22 8:07 Eli Zaretskii
0 siblings, 0 replies; only message in thread
From: Eli Zaretskii @ 2021-07-22 8:07 UTC (permalink / raw)
To: Lars Ingebrigtsen, Jashank Jeremy; +Cc: emacs-devel
Thanks for working on this important improvement.
However, this changeset removes the variable face-new-frame-defaults,
so code which references it will now signal an error. (The variable
is declared obsolete, but that has no effect since the variable itself
doesn't exist.) I don't think we can remove such a variable without
proper deprecation period. So please add some code to compute that
variable at startup and whenever the faces are updated; we must keep
that variable and its supporting code until we actually remove the
variable.
Also, the C counterpart of face--new-frame-defaults should be changed
from Vface_new_frame_defaults to Vface__new_frame_defaults, and the
commentary before init_xfaces should be updated to that effect (it
currently still mentions the deleted variable
face-new-frame-defaults).
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-07-22 8:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 8:07 master e3b8ddd: Speed up by storing frame faces in hash tables instead of alists Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).