From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: master e3b8ddd: Speed up by storing frame faces in hash tables instead of alists Date: Thu, 22 Jul 2021 11:07:22 +0300 Message-ID: <834kcm4vr9.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24032"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen , Jashank Jeremy Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jul 22 10:08:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6Tku-00067g-0j for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Jul 2021 10:08:32 +0200 Original-Received: from localhost ([::1]:50190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Tks-0001TE-Tp for ged-emacs-devel@m.gmane-mx.org; Thu, 22 Jul 2021 04:08:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54388) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6TkA-0000eo-UD for emacs-devel@gnu.org; Thu, 22 Jul 2021 04:07:46 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:44706) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m6Tk8-0001yi-4F; Thu, 22 Jul 2021 04:07:44 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3483 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m6Tk7-0000OO-DE; Thu, 22 Jul 2021 04:07:43 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271455 Archived-At: Thanks for working on this important improvement. However, this changeset removes the variable face-new-frame-defaults, so code which references it will now signal an error. (The variable is declared obsolete, but that has no effect since the variable itself doesn't exist.) I don't think we can remove such a variable without proper deprecation period. So please add some code to compute that variable at startup and whenever the faces are updated; we must keep that variable and its supporting code until we actually remove the variable. Also, the C counterpart of face--new-frame-defaults should be changed from Vface_new_frame_defaults to Vface__new_frame_defaults, and the commentary before init_xfaces should be updated to that effect (it currently still mentions the deleted variable face-new-frame-defaults).