* Re: [Emacs-diffs] master d43af7b: * lisp/vc/vc.el (vc-diff-mergebase, vc-log-mergebase): New commands. [not found] ` <20190325214537.ECCC520406@vcs0.savannah.gnu.org> @ 2019-04-01 23:26 ` Dmitry Gutov 0 siblings, 0 replies; only message in thread From: Dmitry Gutov @ 2019-04-01 23:26 UTC (permalink / raw) To: emacs-devel, Juri Linkov On 25.03.2019 23:45, Juri Linkov wrote: > +(defun vc-git-mergebase (rev1 &optional rev2) > + (unless rev2 (setq rev2 "HEAD")) > + (string-trim-right (vc-git--run-command-string nil "merge-base" rev1 rev2))) vc-git--rev-parse returns the same kind of value, but trims the string differently. We should use either one of the approaches in both. ^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-04-01 23:26 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190325214537.7605.26562@vcs0.savannah.gnu.org>
[not found] ` <20190325214537.ECCC520406@vcs0.savannah.gnu.org>
2019-04-01 23:26 ` [Emacs-diffs] master d43af7b: * lisp/vc/vc.el (vc-diff-mergebase, vc-log-mergebase): New commands Dmitry Gutov
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).