From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, Juri Linkov <juri@linkov.net>
Subject: Re: [Emacs-diffs] master d43af7b: * lisp/vc/vc.el (vc-diff-mergebase, vc-log-mergebase): New commands.
Date: Tue, 2 Apr 2019 02:26:18 +0300 [thread overview]
Message-ID: <6d47a90b-dd0c-87e5-d174-d1fd9b0e31de@yandex.ru> (raw)
In-Reply-To: <20190325214537.ECCC520406@vcs0.savannah.gnu.org>
On 25.03.2019 23:45, Juri Linkov wrote:
> +(defun vc-git-mergebase (rev1 &optional rev2)
> + (unless rev2 (setq rev2 "HEAD"))
> + (string-trim-right (vc-git--run-command-string nil "merge-base" rev1 rev2)))
vc-git--rev-parse returns the same kind of value, but trims the string
differently. We should use either one of the approaches in both.
parent reply other threads:[~2019-04-01 23:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20190325214537.ECCC520406@vcs0.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d47a90b-dd0c-87e5-d174-d1fd9b0e31de@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).