From: "Mattias Engdegård" <mattiase@acm.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Glenn Morris <rgm@gnu.org>, emacs-devel@gnu.org
Subject: Re: Emacs is not reproducible
Date: Thu, 27 May 2021 14:24:01 +0200 [thread overview]
Message-ID: <68D4CF9A-C5F9-4665-9306-A6D0A6258260@acm.org> (raw)
In-Reply-To: <jwvr1htmdh6.fsf-monnier+emacs@gnu.org>
26 maj 2021 kl. 22.58 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
> Matthias, could you try and see where byte-opt.el should let-bind
> `byte-optimize--lexvars` to nil to avoid this problem?
> I guess we could add it to `byte-compile-top-level`, but it would be
> better if we could do it somewhere in `byte-opt.el`.
Oh dear, I can't really find any good place to bind the variable either, but ended up doing it in `byte-compile-inline-expand` on the grounds that it's the only place we re-enter the compiler from the optimiser.
It would probably be better if we had a single entry for `byte-optimize-form` that wasn't used recursively; then it could be done there.
Anyway, feel free to improve. Writing the test was what took most of the time anyway!
next prev parent reply other threads:[~2021-05-27 12:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 15:28 Emacs is not reproducible Bone Baboon
2021-05-17 15:45 ` Alan Mackenzie
2021-05-17 15:55 ` Achim Gratz
2021-05-17 15:54 ` Eli Zaretskii
2021-05-17 16:40 ` Stefan Monnier
2021-05-23 3:31 ` Stefan Monnier
2021-05-23 23:52 ` Glenn Morris
2021-05-25 17:41 ` Stefan Monnier
2021-05-25 17:52 ` T.V Raman
2021-05-25 18:03 ` Glenn Morris
2021-05-26 20:58 ` Stefan Monnier
2021-05-27 12:24 ` Mattias Engdegård [this message]
2021-05-27 21:33 ` Stefan Monnier
2021-05-25 18:27 ` Basil L. Contovounesios
2021-05-27 21:32 ` Stefan Monnier
2021-05-28 9:00 ` Basil L. Contovounesios
2021-06-05 16:26 ` Warning in tramp.el (was: Emacs is not reproducible) Stefan Monnier
2021-06-06 6:42 ` Warning in tramp.el Michael Albinus
2021-06-06 17:48 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68D4CF9A-C5F9-4665-9306-A6D0A6258260@acm.org \
--to=mattiase@acm.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).