From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bone Baboon <bone.baboon@disroot.org>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs is not reproducible
Date: Mon, 17 May 2021 12:40:39 -0400 [thread overview]
Message-ID: <jwvk0nxs4er.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87lf8dcrcd.fsf@disroot.org> (Bone Baboon's message of "Mon, 17 May 2021 11:28:18 -0400")
> Is there currently any work underway to make Emacs reproducible?
There has been changes made in the past to fix some problems.
I have a pending patch in bug#46502 (see below) which aims to fix some
more of those problems, but still haven't heard confirmation that it
helps.
Stefan
diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el
index e0feb95a46..06c925b7bf 100644
--- a/lisp/emacs-lisp/byte-opt.el
+++ b/lisp/emacs-lisp/byte-opt.el
@@ -268,32 +269,16 @@ byte-compile-inline-expand
;; The byte-code will be really inlined in byte-compile-unfold-bcf.
`(,fn ,@(cdr form)))
((or `(lambda . ,_) `(closure . ,_))
- (if (not (or (eq fn localfn) ;From the same file => same mode.
- (eq (car fn) ;Same mode.
- (if lexical-binding 'closure 'lambda))))
- ;; While byte-compile-unfold-bcf can inline dynbind byte-code into
- ;; letbind byte-code (or any other combination for that matter), we
- ;; can only inline dynbind source into dynbind source or letbind
- ;; source into letbind source.
- (progn
- ;; We can of course byte-compile the inlined function
- ;; first, and then inline its byte-code.
- (byte-compile name)
- `(,(symbol-function name) ,@(cdr form)))
- (let ((newfn (if (eq fn localfn)
- ;; If `fn' is from the same file, it has already
- ;; been preprocessed!
- `(function ,fn)
- ;; Try and process it "in its original environment".
- (let ((byte-compile-bound-variables nil))
- (byte-compile-preprocess
- (byte-compile--reify-function fn))))))
- (if (eq (car-safe newfn) 'function)
- (macroexp--unfold-lambda `(,(cadr newfn) ,@(cdr form)))
- ;; This can happen because of macroexp-warn-and-return &co.
- (byte-compile-warn
- "Inlining closure %S failed" name)
- form))))
+ (if (eq fn localfn) ;From the same file => same mode.
+ (macroexp--unfold-lambda `(,fn ,@(cdr form)))
+ ;; While byte-compile-unfold-bcf can inline dynbind byte-code into
+ ;; letbind byte-code (or any other combination for that matter), we
+ ;; can only inline dynbind source into dynbind source or letbind
+ ;; source into letbind source.
+ ;; We can of course byte-compile the inlined function
+ ;; first, and then inline its byte-code.
+ (byte-compile name)
+ `(,(symbol-function name) ,@(cdr form))))
(_ ;; Give up on inlining.
form))))
next prev parent reply other threads:[~2021-05-17 16:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 15:28 Emacs is not reproducible Bone Baboon
2021-05-17 15:45 ` Alan Mackenzie
2021-05-17 15:55 ` Achim Gratz
2021-05-17 15:54 ` Eli Zaretskii
2021-05-17 16:40 ` Stefan Monnier [this message]
2021-05-23 3:31 ` Stefan Monnier
2021-05-23 23:52 ` Glenn Morris
2021-05-25 17:41 ` Stefan Monnier
2021-05-25 17:52 ` T.V Raman
2021-05-25 18:03 ` Glenn Morris
2021-05-26 20:58 ` Stefan Monnier
2021-05-27 12:24 ` Mattias Engdegård
2021-05-27 21:33 ` Stefan Monnier
2021-05-25 18:27 ` Basil L. Contovounesios
2021-05-27 21:32 ` Stefan Monnier
2021-05-28 9:00 ` Basil L. Contovounesios
2021-06-05 16:26 ` Warning in tramp.el (was: Emacs is not reproducible) Stefan Monnier
2021-06-06 6:42 ` Warning in tramp.el Michael Albinus
2021-06-06 17:48 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvk0nxs4er.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=bone.baboon@disroot.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).