unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: storm@cua.dk (Kim F. Storm)
Cc: storm@cua.dk (Kim F. Storm),
	rms@gnu.org, miles@lsi.nec.co.jp,
	monnier+gnu/emacs@rum.cs.yale.edu, emacs-devel@gnu.org,
	emacs-pretest-bug@gnu.org
Subject: Re: info invisible changes
Date: 14 Nov 2002 00:31:16 +0100	[thread overview]
Message-ID: <5x4ralcaij.fsf@kfs2.cua.dk> (raw)
In-Reply-To: <200211121849.gACInHA08073@rum.cs.yale.edu>

"Stefan Monnier" <monnier+gnu/emacs/pretest@rum.cs.yale.edu> writes:

> > 1) it doesn't test for 'invisible properties, so it happily processes
> >    invisible text when deciding the (visible) width of the lines,
> 
> Are you sure ?  It uses current-column which does pay attention
> to `invisible' properties.

It works in relation to fill, yes.

But in general, the behaviour of current-column is "questionable" when
the buffer contains invisible newlines.  Consider the following code:

(let ((b (get-buffer-create "current-column test")))
   (set-buffer b)
   (erase-buffer)
   (insert "abc\ndef\nghi")
   (add-text-properties 4 5 '(invisible t))
   (add-text-properties 8 9 '(invisible t))
   ;; buffer now displays as one line: abcdefghi
   ;; position on the `h'
   (goto-char 10)
   (current-column))

It creates a buffer with the following data line (where # indicates an
invisible newline):

        abc#
        def#
        ghi

I.e. the visible result is:

        abcdefghi

Here, current-column claims that `h' is in column 1.

This is because current_column_1 uses scan_newline to find the
line start, but scan_newline doesn't skip over invisible newlines...


> 
> > 3) when the fill code inserts a newline to wrap the text, it may
> >    insert that newline in an invisible part of the buffer, so it has
> >    no visible effect (i.e. displaying one very long line rather than
> >    two normal width lines).
> 
> You can fix this easily.  See fill-nobreak-predicate.

Thanks.  I learn something new every day.

++kfs

  reply	other threads:[~2002-11-13 23:31 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-11-01  8:04 info invisible changes Miles Bader
     [not found] ` <200211011623.gA1GNAL03601@rum.cs.yale.edu>
2002-11-05  4:08   ` Miles Bader
2002-11-05 18:49     ` Stefan Monnier
2002-11-07  4:49       ` Richard Stallman
2002-11-05 23:57     ` Kim F. Storm
2002-11-06  9:51       ` Miles Bader
2002-11-06 12:46         ` Kim F. Storm
2002-11-06 12:30           ` Miles Bader
2002-11-06 15:11         ` Stefan Monnier
2002-11-06 16:32           ` Miles Bader
2002-11-07 15:08           ` Richard Stallman
2002-11-12 10:11             ` Kim F. Storm
2002-11-12  9:22               ` Miles Bader
2002-11-12 10:59                 ` Kim F. Storm
2002-11-12 17:28                   ` Robert J. Chassell
2002-11-13 14:37                     ` Kim F. Storm
2002-11-13 18:20                       ` Robert J. Chassell
2002-11-14 12:17                         ` Richard Stallman
2002-11-14 21:38                           ` Kim F. Storm
2002-11-12 18:49               ` Stefan Monnier
2002-11-13 23:31                 ` Kim F. Storm [this message]
2002-11-14  0:39                 ` Kim F. Storm
2002-11-14  4:09               ` Richard Stallman
  -- strict thread matches above, loose matches on Subject: below --
2002-11-14 13:57 Karl Berry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5x4ralcaij.fsf@kfs2.cua.dk \
    --to=storm@cua.dk \
    --cc=emacs-devel@gnu.org \
    --cc=emacs-pretest-bug@gnu.org \
    --cc=miles@lsi.nec.co.jp \
    --cc=monnier+gnu/emacs@rum.cs.yale.edu \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).