* master c14eab2: Fix dumping on GNU/Linux ppc64le
@ 2018-11-12 11:38 Eivind Fonn
2018-11-12 13:34 ` martin rudalics
2018-11-12 16:47 ` Paul Eggert
0 siblings, 2 replies; 8+ messages in thread
From: Eivind Fonn @ 2018-11-12 11:38 UTC (permalink / raw)
To: emacs-devel
Hello,
This commit seems to break the build on Windows, at
least our appveyor CI, see for example
https://ci.appveyor.com/project/tarsius/libegit2/builds/20227754/job/dlthdcmoe06iipfs#L486
The function maybe_disable_address_randomization
is declared with two different signatures, failing when
the void version is used because the return value is
assigned.
Eivind
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master c14eab2: Fix dumping on GNU/Linux ppc64le
2018-11-12 11:38 master c14eab2: Fix dumping on GNU/Linux ppc64le Eivind Fonn
@ 2018-11-12 13:34 ` martin rudalics
2018-11-12 15:58 ` Eli Zaretskii
2018-11-12 16:47 ` Paul Eggert
1 sibling, 1 reply; 8+ messages in thread
From: martin rudalics @ 2018-11-12 13:34 UTC (permalink / raw)
To: Eivind Fonn, emacs-devel
> https://ci.appveyor.com/project/tarsius/libegit2/builds/20227754/job/dlthdcmoe06iipfs#L486
Unrelated to your problem, but this one is a mystery to me:
frame.c: In function 'Fx_parse_geometry':
frame.c:5204:20: warning: 'y' may be used uninitialized in this function [-Wmaybe-uninitialized]
int geometry, x, y;
^
martin
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: master c14eab2: Fix dumping on GNU/Linux ppc64le
2018-11-12 13:34 ` martin rudalics
@ 2018-11-12 15:58 ` Eli Zaretskii
2018-11-12 18:54 ` martin rudalics
0 siblings, 1 reply; 8+ messages in thread
From: Eli Zaretskii @ 2018-11-12 15:58 UTC (permalink / raw)
To: martin rudalics; +Cc: evfonn, emacs-devel
> Date: Mon, 12 Nov 2018 14:34:24 +0100
> From: martin rudalics <rudalics@gmx.at>
>
> Unrelated to your problem, but this one is a mystery to me:
>
> frame.c: In function 'Fx_parse_geometry':
> frame.c:5204:20: warning: 'y' may be used uninitialized in this function [-Wmaybe-uninitialized]
> int geometry, x, y;
> ^
Look at what XParseGeometry does, and it will cease being a mystery, I
think.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master c14eab2: Fix dumping on GNU/Linux ppc64le
2018-11-12 15:58 ` Eli Zaretskii
@ 2018-11-12 18:54 ` martin rudalics
2018-11-12 19:57 ` Eli Zaretskii
0 siblings, 1 reply; 8+ messages in thread
From: martin rudalics @ 2018-11-12 18:54 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: evfonn, emacs-devel
> Look at what XParseGeometry does, and it will cease being a mystery, I
> think.
Sorry, I'm too silly to see anything special. Why 'y'? Aren't 'x',
'width' and 'height' in the same boat?
martin
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master c14eab2: Fix dumping on GNU/Linux ppc64le
2018-11-12 18:54 ` martin rudalics
@ 2018-11-12 19:57 ` Eli Zaretskii
0 siblings, 0 replies; 8+ messages in thread
From: Eli Zaretskii @ 2018-11-12 19:57 UTC (permalink / raw)
To: martin rudalics; +Cc: evfonn, emacs-devel
> Date: Mon, 12 Nov 2018 19:54:41 +0100
> From: martin rudalics <rudalics@gmx.at>
> CC: evfonn@gmail.com, emacs-devel@gnu.org
>
> > Look at what XParseGeometry does, and it will cease being a mystery, I
> > think.
>
> Sorry, I'm too silly to see anything special. Why 'y'? Aren't 'x',
> 'width' and 'height' in the same boat?
Who knows? Compiler bugs are tricky that way.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: master c14eab2: Fix dumping on GNU/Linux ppc64le
2018-11-12 11:38 master c14eab2: Fix dumping on GNU/Linux ppc64le Eivind Fonn
2018-11-12 13:34 ` martin rudalics
@ 2018-11-12 16:47 ` Paul Eggert
1 sibling, 0 replies; 8+ messages in thread
From: Paul Eggert @ 2018-11-12 16:47 UTC (permalink / raw)
To: Eivind Fonn, emacs-devel
Eivind Fonn wrote:
> This commit seems to break the build on Windows, at
> least our appveyor CI, see for example
Sorry about that; I see that Sam Steingold already fixed it. Thanks, Sam.
^ permalink raw reply [flat|nested] 8+ messages in thread
* master c14eab2: Fix dumping on GNU/Linux ppc64le
@ 2018-11-12 9:51 Eivind Fonn
2018-11-12 13:38 ` Filipp Gunbin
0 siblings, 1 reply; 8+ messages in thread
From: Eivind Fonn @ 2018-11-12 9:51 UTC (permalink / raw)
To: emacs-devel
Hello,
This commit seems to break the build on Windows, at
least our appveyor CI, see for example
https://ci.appveyor.com/project/tarsius/libegit2/builds/20225833/job/uio10kqtx44kwf6w
The function maybe_disable_address_randomization
is declared with two different signatures, failing when
the void version is used because the return value is
assigned.
Eivind
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-11-12 19:57 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-12 11:38 master c14eab2: Fix dumping on GNU/Linux ppc64le Eivind Fonn
2018-11-12 13:34 ` martin rudalics
2018-11-12 15:58 ` Eli Zaretskii
2018-11-12 18:54 ` martin rudalics
2018-11-12 19:57 ` Eli Zaretskii
2018-11-12 16:47 ` Paul Eggert
-- strict thread matches above, loose matches on Subject: below --
2018-11-12 9:51 Eivind Fonn
2018-11-12 13:38 ` Filipp Gunbin
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).