* Re: [Emacs-diffs] emacs-24 r117079: * minibuf.c (read_minibuf): Avoid C99ism in previous patch.
[not found] <E1Wi7Vk-00059Q-En@vcs.savannah.gnu.org>
@ 2014-05-08 0:41 ` Stefan Monnier
2014-05-08 1:24 ` Paul Eggert
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2014-05-08 0:41 UTC (permalink / raw)
To: Paul Eggert; +Cc: emacs-devel
> + Lisp_Object histval;
> Lisp_Object empty_minibuf;
> Lisp_Object dummy, frame;
> @@ -536,11 +537,12 @@
> Vminibuffer_completing_file_name = Qlambda;
> /* If variable is unbound, make it nil. */
> - Lisp_Object histval = find_symbol_value (Vminibuffer_history_variable);
> - if (EQ (histval, Qunbound)) {
> - Fset (Vminibuffer_history_variable, Qnil);
> - histval = Qnil;
> - }
> + histval = find_symbol_value (Vminibuffer_history_variable);
Please keep the initialization together with the declaration
whenever possible (such as here).
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] emacs-24 r117079: * minibuf.c (read_minibuf): Avoid C99ism in previous patch.
2014-05-08 0:41 ` [Emacs-diffs] emacs-24 r117079: * minibuf.c (read_minibuf): Avoid C99ism in previous patch Stefan Monnier
@ 2014-05-08 1:24 ` Paul Eggert
0 siblings, 0 replies; 2+ messages in thread
From: Paul Eggert @ 2014-05-08 1:24 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Stefan Monnier wrote:
> Please keep the initialization together with the declaration
> whenever possible (such as here).
I'll try to do that in the future. For this particular case I was
unsure due to the boatload of intervening code with GCPROs and whatnot,
so I played it safe.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-05-08 1:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <E1Wi7Vk-00059Q-En@vcs.savannah.gnu.org>
2014-05-08 0:41 ` [Emacs-diffs] emacs-24 r117079: * minibuf.c (read_minibuf): Avoid C99ism in previous patch Stefan Monnier
2014-05-08 1:24 ` Paul Eggert
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).