From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] emacs-24 r117079: * minibuf.c (read_minibuf): Avoid C99ism in previous patch.
Date: Wed, 07 May 2014 20:41:54 -0400 [thread overview]
Message-ID: <jwvmwetf6fp.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <E1Wi7Vk-00059Q-En@vcs.savannah.gnu.org> (Paul Eggert's message of "Wed, 07 May 2014 19:28:12 +0000")
> + Lisp_Object histval;
> Lisp_Object empty_minibuf;
> Lisp_Object dummy, frame;
> @@ -536,11 +537,12 @@
> Vminibuffer_completing_file_name = Qlambda;
> /* If variable is unbound, make it nil. */
> - Lisp_Object histval = find_symbol_value (Vminibuffer_history_variable);
> - if (EQ (histval, Qunbound)) {
> - Fset (Vminibuffer_history_variable, Qnil);
> - histval = Qnil;
> - }
> + histval = find_symbol_value (Vminibuffer_history_variable);
Please keep the initialization together with the declaration
whenever possible (such as here).
Stefan
next parent reply other threads:[~2014-05-08 0:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Wi7Vk-00059Q-En@vcs.savannah.gnu.org>
2014-05-08 0:41 ` Stefan Monnier [this message]
2014-05-08 1:24 ` [Emacs-diffs] emacs-24 r117079: * minibuf.c (read_minibuf): Avoid C99ism in previous patch Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvmwetf6fp.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).