From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: cl-defstruct-based package.el, now with ert tests and no external tar! Date: Thu, 27 Jun 2013 13:38:54 +0400 Message-ID: <51CC082E.7010907@yandex.ru> References: <87y5cx0wh7.fsf@yandex.ru> <87ppy7e5ke.fsf@lifelogs.com> <87k3lnvr7c.fsf@yandex.ru> <51C8D889.5000404@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1372325971 18590 80.91.229.3 (27 Jun 2013 09:39:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 27 Jun 2013 09:39:31 +0000 (UTC) Cc: Stefan Monnier , Emacs development discussions To: Daniel Hackney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 27 11:39:32 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Us8fn-0000Hh-T0 for ged-emacs-devel@m.gmane.org; Thu, 27 Jun 2013 11:39:28 +0200 Original-Received: from localhost ([::1]:46394 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Us8fn-0007NS-Hy for ged-emacs-devel@m.gmane.org; Thu, 27 Jun 2013 05:39:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42403) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Us8fX-0007M2-8H for emacs-devel@gnu.org; Thu, 27 Jun 2013 05:39:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Us8fJ-0008Jz-E4 for emacs-devel@gnu.org; Thu, 27 Jun 2013 05:39:11 -0400 Original-Received: from mail-la0-x22b.google.com ([2a00:1450:4010:c03::22b]:54850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Us8fJ-0008JF-4C for emacs-devel@gnu.org; Thu, 27 Jun 2013 05:38:57 -0400 Original-Received: by mail-la0-f43.google.com with SMTP id gw10so555863lab.16 for ; Thu, 27 Jun 2013 02:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding :x-antivirus:x-antivirus-status; bh=I9in8p9Ay74JZb0x4LFrJzxP4zjK4K78W208BrvA7NE=; b=iLIG3L+NMmbqXmmGAQq+BGB0XlMwuaig6pxo0gEDrU0Ptx8ehkVI51BUAIYHpwp66E 9w2jPNdwEzjjjuInBByd8d4HTd9P7nHbI4dBodjFD92sCaRxqDwqbj6SBdYiBUnZd14N k53egKz+2v8NuI0QPGihTn2xyaKVmbMbTox+gSyzdfd8o7aav/GRZbakG5tD2xeIrxoO 7AR0CkJZd3lSsEbhsm7GDsdKF7FRs5ZE73Np4qNqIWV+OlPxVBq7bXOgSBczqhN3oyEE VgoqhprdDGfjqx8qhMvI+N0g+kwx4Ls9Cj8/79orqi4j+KyuK9aLPRbnjq00QZgVX9pq SDlg== X-Received: by 10.152.21.131 with SMTP id v3mr3821356lae.50.1372325935809; Thu, 27 Jun 2013 02:38:55 -0700 (PDT) Original-Received: from [127.0.0.1] ([178.252.98.87]) by mx.google.com with ESMTPSA id p10sm696072lap.8.2013.06.27.02.38.54 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Jun 2013 02:38:55 -0700 (PDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 In-Reply-To: X-Antivirus: avast! (VPS 130626-1, 27.06.2013), Outbound message X-Antivirus-Status: Clean X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:161133 Archived-At: I've checked in the tests, along with some tweaks and previously discussed simplifications. I've also taken the liberty to change the commentary, because the test suite hasn't eaten my package dir even once so far, and let-binding `package-alist' around the body of the big scary macro seems to make sure that the list of installed packages is also kept intact. Thanks for your work, even though it hasn't been adopted in its entirety. If you feel strongly about some feature that hasn't been taken in, it should be easier to make a smaller, targeted patch now. Comments and suggestions welcome, especially of the "why do the tests have to do that thing to make things work?" variety.