From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: /srv/bzr/emacs/trunk r111061: Fix for bad test in ruby-mode-tests.el. Date: Mon, 03 Dec 2012 22:45:15 +0400 Message-ID: <50BCF33B.4080809@yandex.ru> References: <878v9groov.fsf@yandex.ru> <87ehj7hiy7.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1354560334 16223 80.91.229.3 (3 Dec 2012 18:45:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Dec 2012 18:45:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Dec 03 19:45:46 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tfb1T-0006sZ-2k for ged-emacs-devel@m.gmane.org; Mon, 03 Dec 2012 19:45:43 +0100 Original-Received: from localhost ([::1]:51307 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tfb1H-0005Wy-Cd for ged-emacs-devel@m.gmane.org; Mon, 03 Dec 2012 13:45:31 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:51086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tfb1E-0005Wt-L0 for emacs-devel@gnu.org; Mon, 03 Dec 2012 13:45:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tfb1A-0003hB-QI for emacs-devel@gnu.org; Mon, 03 Dec 2012 13:45:28 -0500 Original-Received: from mail-la0-f41.google.com ([209.85.215.41]:61506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tfb15-0003gN-PX; Mon, 03 Dec 2012 13:45:19 -0500 Original-Received: by mail-la0-f41.google.com with SMTP id m15so2721849lah.0 for ; Mon, 03 Dec 2012 10:45:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=cr+rbG0fw+5HZCi2PnyFDBxNSu1WgDfDOi3Vg5Hsvss=; b=EYguXzx0zhvVOyplupCais8GIrM4BuctqIcNlFKCM9DOSqhyHWOGnFqlf89RYKnCO0 q3qD7WALij8qHaq+1so6/WVN5fCMuZEM8XndfYt2YOU3NdSLqf0SGoNNyoKP6eGGMTQm l14SC5y0sszgPUBTfIYqjZ51dzDUplRhEU7IfHmMJQSQqXP+cWZ2XCZY5rkz/KK6RNAR B/UcyOA7SltKJTLDhu5QwU0/y4GLBhvgyb3rV2X13N7xhgih7yJu8xfslFKJCRSeu498 3QYTbpH5CZomaPzFS7mhfZK8JKUmGm5ghyWLbBdNfKz7grpGpPa6e0wsQx00NygL97yD E03w== Original-Received: by 10.152.46.161 with SMTP id w1mr10407920lam.27.1354560316982; Mon, 03 Dec 2012 10:45:16 -0800 (PST) Original-Received: from [192.168.1.5] ([178.252.98.87]) by mx.google.com with ESMTPS id sx3sm5720276lab.9.2012.12.03.10.45.14 (version=SSLv3 cipher=OTHER); Mon, 03 Dec 2012 10:45:15 -0800 (PST) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121026 Thunderbird/16.0.2 In-Reply-To: <87ehj7hiy7.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.215.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:155200 Archived-At: On 03.12.2012 8:13, Chong Yidong wrote: > Dmitry Gutov writes: > >> Is there some way to run all tests in automated fashion (which I >> broke)? > > Do `make check' from the top level of the tree. > >> Would it have been better if I 'require'd cl-lib and used the prefixed >> version of the macro? > > Sure, that would probably have worked too. Thanks for the answers. What about the third question? Last time I've seen a discussion about whitespace style in Emacs codebase, I think it was somewhat of a consensus that spaces > tabs (which is also my preference), but doing whitespace-only commits was declared verboten, so I can't just revert that part of the change.