Re: discoverability, better defaults and which-key in Emacs

[Dmitry Gutov <dmitry@gutov.dev>]

On 08/02/2024 15:27, Dmitry Gutov wrote:
> On 08/02/2024 15:25, Po Lu wrote:
>> Dmitry Gutov<dmitry@gutov.dev>  writes:
>>
>>> +  if (echo_keystrokes_help)
>>> +    {
>>> +      AUTO_STRING (help, " (\\`C-h' for help)");
>>> +      kset_echo_string (current_kboard,
>>> +            concat2 (KVAR (current_kboard, echo_string),
>>> +                 calln (Qsubstitute_command_keys, help)));
>>> +    }
>> Just for the record, calling functions defined in Lisp with automatic
>> variables as arguments will give rise to mysterious crashes down the
>> line.  Strings constructed by AUTO_STRING must never be returned,
>> provided to Lisp, or referenced after moving out of scope, as its name
>> suggests.
> 
> It was used with 'concat' here to construct a new string.
> 
> Is that still a problem?

Ah, I passed it to Lisp function first. Gotcha. Thanks.