From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: discoverability, better defaults and which-key in Emacs Date: Thu, 8 Feb 2024 15:36:23 +0200 Message-ID: <4961a7e0-80df-4865-b269-3385ef765726@gutov.dev> References: <874jetaxri.fsf@jeremybryant.net> <87le84oqbd.fsf@yahoo.com> <87plxdpsxw.fsf@posteo.net> <87r0hridvr.fsf@posteo.net> <5dd3d04c-c0eb-43fe-b7c2-957f80261ea3@gutov.dev> <87eddqiw84.fsf@posteo.net> <32071337-c91d-46ad-bb9b-10b8d0c83965@gutov.dev> <86h6ikzc38.fsf@gnu.org> <1056a72d-af5c-487e-be33-67522fe47d17@gutov.dev> <87o7cr2imp.fsf@yahoo.com> <2786f0a4-0740-44b9-a853-d8db85ceed16@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5749"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Eli Zaretskii , justin@burkett.cc, philipk@posteo.net, jb@jeremybryant.net, emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 08 14:37:24 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rY4ae-00018V-L7 for ged-emacs-devel@m.gmane-mx.org; Thu, 08 Feb 2024 14:37:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rY4Zv-0000tR-Eh; Thu, 08 Feb 2024 08:36:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rY4Zr-0000st-Oa for emacs-devel@gnu.org; Thu, 08 Feb 2024 08:36:31 -0500 Original-Received: from wout1-smtp.messagingengine.com ([64.147.123.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rY4Zq-0005Qc-0w; Thu, 08 Feb 2024 08:36:31 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 827853200A04; Thu, 8 Feb 2024 08:36:26 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 08 Feb 2024 08:36:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707399386; x=1707485786; bh=iz9arsqfrc9ziBrC6+kAi/2oIWzz2QofaKMYVahg4tA=; b= A5r26ikOd5loy5ZR1p7D8vp2jz/uD2FAn814ZlV7oO3hLXDRmOwn7c63o8WlUjEq Q+9tiEekATR8wWpQ5fULIoHp1JN1EnJne2eYaWDGv1Ty8kKip40TxcTkFfcH2Gmv ti51nv/KwuAK+LMeMJKiCPEC2X1yaZsHzG+QI+W/TfBtLzpBtKte1RkoAKp5azcz MBzscy581iP1bCl5wz3ahHC+8/eg2Si0gqD3zpEZGjFotG7nNIXX/k0czAmKbZfu +p7v/OrN4dCvX/8sPHMrLdB4KBUm1phOdRu8KuTBBQH5ezpgcbLPTLsCTVv2Yn+C /B0RsQ+SxI3zbdieHbqFeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707399386; x= 1707485786; bh=iz9arsqfrc9ziBrC6+kAi/2oIWzz2QofaKMYVahg4tA=; b=j n/SEdN/rNH6CWBtYN+3E7+g8yG28Y5EZj8jiJeL14rNlD38q88lc+UhRVyTNHdxZ IF08zlucZ+ltB/B58YrjJrkqDHTnc/Uz+iGMsre5B8BZP6JMvhA3iI3QtJh0sGVn 186qcQyOsjaDGnIWV1f6wIK6Dt9hvG9BZrJDQWZoa6b7DOkJ12v37064ZG5w0pLn Sq118YMCvjb28SCHuag0fhYTsxO2eCc4E5vwH/qSWxZy21KXI0ITbAyywNQXLuIg MzfXJwzT7+6dVULQPCGR9PGPlNu2gMWNHWVMT1KYoA+JtOGSWwEUvLiYM9hqVY1d BVxazDWsCn38eENBTxBJQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrtdeggdehudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuhffvvehfjggtgfesthekredttddvjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpedvleeijeevkeejleffgeduiedujeffhfevudduffdvveetkeegveffjefgffel ueenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 8 Feb 2024 08:36:24 -0500 (EST) Content-Language: en-US In-Reply-To: <2786f0a4-0740-44b9-a853-d8db85ceed16@gutov.dev> Received-SPF: pass client-ip=64.147.123.24; envelope-from=dmitry@gutov.dev; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:316030 Archived-At: On 08/02/2024 15:27, Dmitry Gutov wrote: > On 08/02/2024 15:25, Po Lu wrote: >> Dmitry Gutov  writes: >> >>> +  if (echo_keystrokes_help) >>> +    { >>> +      AUTO_STRING (help, " (\\`C-h' for help)"); >>> +      kset_echo_string (current_kboard, >>> +            concat2 (KVAR (current_kboard, echo_string), >>> +                 calln (Qsubstitute_command_keys, help))); >>> +    } >> Just for the record, calling functions defined in Lisp with automatic >> variables as arguments will give rise to mysterious crashes down the >> line.  Strings constructed by AUTO_STRING must never be returned, >> provided to Lisp, or referenced after moving out of scope, as its name >> suggests. > > It was used with 'concat' here to construct a new string. > > Is that still a problem? Ah, I passed it to Lisp function first. Gotcha. Thanks.