unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>
Cc: visuweshm@gmail.com, justin@burkett.cc, philipk@posteo.net,
	luangruo@yahoo.com, jb@jeremybryant.net, emacs-devel@gnu.org
Subject: Re: discoverability, better defaults and which-key in Emacs
Date: Thu, 8 Feb 2024 15:36:43 +0200	[thread overview]
Message-ID: <e457c310-5136-4930-9c31-6f962a518d85@gutov.dev> (raw)
In-Reply-To: <86r0hnw1l1.fsf@gnu.org>

On 08/02/2024 15:02, Eli Zaretskii wrote:
>> Date: Thu, 8 Feb 2024 14:18:34 +0200
>> Cc: justin@burkett.cc, philipk@posteo.net, luangruo@yahoo.com,
>>   jb@jeremybryant.net, emacs-devel@gnu.org
>> From: Dmitry Gutov <dmitry@gutov.dev>
>>
>> On 08/02/2024 08:59, Eli Zaretskii wrote:
>>> But
>>> I added F1 to that text, which should help if someone did change
>>> help-char.
>>
>> Whether help-char is changed, or 'C-h' is rebound anyway, can all be
>> detected at runtime. <f1> can also have a different binding in the
>> current prefix map--then the new message would be doubly incorrect.
> 
> How frequently do people rebind F1?  IME, never.

Sure, likewise with C-h. That's why the original patch was probably okay 
as-is.

> But I don't object to adding runtime detection of the help keys.

Good.

>> I'd rather we picked one (preferably correct) suggestion and printed that.
> 
> Most people will never rebind C-h.  Those who do could rebind it to a
> character that cannot be used in this situation because it is already
> bound in various prefix maps.  Having two alternatives there increases
> the probability that one of them will work.

If we consider the situations where C-h or f1 is rebound, having 
misleading text in the message (with bindings that don't work) should 
concern us as well. Even if one of the suggestions is likely to work 
anyway (while the other doesn't).

>> For context: I customize echo-keystrokes to a very low value and
>> currently see this help message quite often.
> 
> If the message annoys you, you can disable it.

Sure - this is not a deal-breaker. But the more features I disable the 
less problems I could find while dogfooding. Until now I've been running 
with it, and it seemed unobtrusive enough.

Runtime detection might even make it occasionally helpful in odd 
contexts where something shadows the binding.



  reply	other threads:[~2024-02-08 13:36 UTC|newest]

Thread overview: 78+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31 23:23 discoverability, better defaults and which-key in Emacs Jeremy Bryant
2024-02-01  2:45 ` Po Lu
2024-02-03 13:40   ` Philip Kaludercic
2024-02-04 22:03     ` Dmitry Gutov
2024-02-05  7:11       ` Philip Kaludercic
2024-02-05 15:38         ` Dmitry Gutov
2024-02-05 18:47           ` Philip Kaludercic
2024-02-05 19:17             ` Dmitry Gutov
2024-02-05 19:33               ` Justin Burkett
2024-02-05 23:05                 ` Dmitry Gutov
2024-02-06  2:49                   ` Justin Burkett
2024-02-06 23:12                     ` Dmitry Gutov
2024-02-07 12:35                       ` Eli Zaretskii
2024-02-07 18:31                         ` Dmitry Gutov
2024-02-07 19:13                           ` Eli Zaretskii
2024-02-07 19:51                             ` Dmitry Gutov
2024-02-08  1:46                           ` Visuwesh
2024-02-08  6:59                             ` Eli Zaretskii
2024-02-08 12:18                               ` Dmitry Gutov
2024-02-08 13:02                                 ` Eli Zaretskii
2024-02-08 13:36                                   ` Dmitry Gutov [this message]
2024-02-08 13:52                                     ` Eli Zaretskii
2024-02-08 14:43                                       ` Dmitry Gutov
2024-02-08 16:12                                         ` Dmitry Gutov
2024-02-11  2:17                                           ` Dmitry Gutov
2024-02-11  2:39                                             ` Po Lu
2024-02-11 12:30                                               ` Dmitry Gutov
2024-02-11  6:49                                             ` Eli Zaretskii
2024-02-11 12:26                                               ` Dmitry Gutov
2024-02-11 15:00                                                 ` Eli Zaretskii
2024-02-11 20:36                                                   ` Dmitry Gutov
2024-02-08 16:50                                         ` Eli Zaretskii
2024-02-08 13:41                                   ` Dmitry Gutov
2024-02-08 13:51                                   ` Rebinding Fn [Re: discoverability, better defaults and which-key in Emacs] Alan Mackenzie
2024-02-08 13:55                                     ` Eli Zaretskii
2024-02-08 14:04                                       ` Alan Mackenzie
2024-02-08 13:25                           ` discoverability, better defaults and which-key in Emacs Po Lu
2024-02-08 13:27                             ` Dmitry Gutov
2024-02-08 13:36                               ` Dmitry Gutov
2024-02-01  7:35 ` Eli Zaretskii
2024-02-01 21:16   ` Jeremy Bryant
2024-02-02  6:43     ` Eli Zaretskii
2024-02-02  7:00       ` Emanuel Berg
2024-02-02  7:43         ` Eli Zaretskii
2024-02-02 15:25           ` [External] : " Drew Adams
2024-02-02 15:53             ` Emanuel Berg
2024-02-02 16:04             ` Emanuel Berg
2024-02-03 11:46             ` Jeremy Bryant
2024-02-03 11:39           ` Jeremy Bryant
2024-02-03 12:12             ` Eli Zaretskii
2024-02-03 14:07               ` Jeremy Bryant
2024-02-03 15:15                 ` Eli Zaretskii
2024-02-04 22:18                   ` Jeremy Bryant
2024-02-05 12:41                     ` Eli Zaretskii
2024-02-03 11:30       ` Jeremy Bryant
2024-02-03 11:36       ` Moving which-key ELPA package into core - " Jeremy Bryant
2024-02-03 16:34         ` Stefan Monnier
2024-02-04 22:12           ` Jeremy Bryant
2024-02-04 23:06             ` Stefan Monnier
2024-02-01 21:17   ` orzodk
2024-02-01 22:24     ` Jeremy Bryant
2024-02-01 23:49       ` orzodk
2024-02-02  6:31     ` Eli Zaretskii
2024-02-02 16:00   ` Howard Melman
2024-02-02 19:24     ` Eli Zaretskii
2024-02-02 19:32       ` tomas
2024-02-02 20:16         ` Howard Melman
2024-02-03  7:25           ` Emanuel Berg
2024-02-03  8:49           ` Eli Zaretskii
2024-02-03 16:58             ` [External] : " Drew Adams
2024-02-04 22:25               ` Jeremy Bryant
2024-02-04 22:55                 ` Emanuel Berg
2024-02-05  3:40                   ` Emanuel Berg
2024-02-04 23:47                 ` Drew Adams
2024-02-05  1:46                   ` Emanuel Berg
2024-02-05  3:52               ` Divya Ranjan
2024-02-05 15:04                 ` Drew Adams
2024-02-04 18:34             ` Howard Melman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e457c310-5136-4930-9c31-6f962a518d85@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jb@jeremybryant.net \
    --cc=justin@burkett.cc \
    --cc=luangruo@yahoo.com \
    --cc=philipk@posteo.net \
    --cc=visuweshm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).