* Re: [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing
[not found] ` <20190407230422.1469321115@vcs0.savannah.gnu.org>
@ 2019-04-08 1:02 ` Stefan Monnier
2019-04-08 15:43 ` Jackson Ray Hamilton
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2019-04-08 1:02 UTC (permalink / raw)
To: Jackson Ray Hamilton; +Cc: emacs-devel
> +(defconst js--name-start-re (concat "[a-zA-Z_$]")
> "Regexp matching the start of a JavaScript identifier, without grouping.")
BTW, my knowledge of Javascript is very limited, but IIUC its
identifiers are not limited to ASCII, so [[:alpha:]_$] is probably
a better regexp.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing
2019-04-08 1:02 ` [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing Stefan Monnier
@ 2019-04-08 15:43 ` Jackson Ray Hamilton
0 siblings, 0 replies; 2+ messages in thread
From: Jackson Ray Hamilton @ 2019-04-08 15:43 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Hi Stefan,
You’re right. I pushed “Permit non-ASCII identifiers in JS” to address
this.
Jackson
On 4/7/19 6:02 PM, Stefan Monnier wrote:
>> +(defconst js--name-start-re (concat "[a-zA-Z_$]")
>> "Regexp matching the start of a JavaScript identifier, without grouping.")
> BTW, my knowledge of Javascript is very limited, but IIUC its
> identifiers are not limited to ASCII, so [[:alpha:]_$] is probably
> a better regexp.
>
>
> Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-08 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190407230419.19711.9506@vcs0.savannah.gnu.org>
[not found] ` <20190407230422.1469321115@vcs0.savannah.gnu.org>
2019-04-08 1:02 ` [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing Stefan Monnier
2019-04-08 15:43 ` Jackson Ray Hamilton
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).