From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Jackson Ray Hamilton Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] feature/jsx 9e65e4b 3/3: Improve whitespace and unary keyword parsing Date: Mon, 8 Apr 2019 08:43:12 -0700 Message-ID: <444e64b8-0897-0942-14ca-d6652569250a@jacksonrayhamilton.com> References: <20190407230419.19711.9506@vcs0.savannah.gnu.org> <20190407230422.1469321115@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="95448"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 08 17:44:05 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hDWRJ-000Ohm-Jm for ged-emacs-devel@m.gmane.org; Mon, 08 Apr 2019 17:44:05 +0200 Original-Received: from localhost ([127.0.0.1]:55119 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDWRI-0004wl-Ey for ged-emacs-devel@m.gmane.org; Mon, 08 Apr 2019 11:44:04 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:47790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hDWQb-0004wg-Gw for emacs-devel@gnu.org; Mon, 08 Apr 2019 11:43:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hDWQa-0005hx-7k for emacs-devel@gnu.org; Mon, 08 Apr 2019 11:43:21 -0400 Original-Received: from mta-06-3.privateemail.com ([198.54.127.59]:44693) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hDWQZ-0005ew-QV for emacs-devel@gnu.org; Mon, 08 Apr 2019 11:43:20 -0400 Original-Received: from MTA-06.privateemail.com (localhost [127.0.0.1]) by MTA-06.privateemail.com (Postfix) with ESMTP id E8D1D60051; Mon, 8 Apr 2019 11:43:16 -0400 (EDT) Original-Received: from [192.168.88.227] (unknown [10.20.151.226]) by MTA-06.privateemail.com (Postfix) with ESMTPA id B6BD160043; Mon, 8 Apr 2019 15:43:16 +0000 (UTC) In-Reply-To: Content-Language: en-US X-Virus-Scanned: ClamAV using ClamSMTP X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 198.54.127.59 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235117 Archived-At: Hi Stefan, You=E2=80=99re right.=C2=A0 I pushed =E2=80=9CPermit non-ASCII identifier= s in JS=E2=80=9D to address=20 this. Jackson On 4/7/19 6:02 PM, Stefan Monnier wrote: >> +(defconst js--name-start-re (concat "[a-zA-Z_$]") >> "Regexp matching the start of a JavaScript identifier, without gro= uping.") > BTW, my knowledge of Javascript is very limited, but IIUC its > identifiers are not limited to ASCII, so [[:alpha:]_$] is probably > a better regexp. > > > Stefan