unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: Emacs pretest 25.0.93
  2016-04-23 16:55                 ` Achim Gratz
  2016-04-23 17:23                   ` Michael Heerdegen
@ 2016-04-23 17:39                   ` Glenn Morris
  2016-04-23 17:54                     ` Achim Gratz
  2016-04-23 18:46                     ` Glenn Morris
  1 sibling, 2 replies; 32+ messages in thread
From: Glenn Morris @ 2016-04-23 17:39 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-devel

Achim Gratz wrote:

> The reason for why there was no proper timestamp on these entries was
> that during my last build on 3rd of April I built also an EMacs from
> master and that build destroys trhe time-stamps that emacs-25 so
> desperately needs. Really, if there's something wrong with a file the
> build can re-create, it should not error out. Plus, there really needs
> to be some Makefile target to really clean up (no, 'make distclean'
> didn't do it). Plus, the fact that the lisp directory is shared
> between different builds and doesn't contain just the sources doesn't
> really help, either.

Ie, you switched in place from master to the release branch without
cleaning up first. You can't expect this to work. An older branch cannot
reliably clean-up for a newer branch.

Please take the emacs-announce keyword out of the subject (future
announcements should use Keyword: instead to avoid this), since this
whole chain is not an announcement. It's not even related to the
pretest, since you built from git, not the pretest.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-23 17:39                   ` Glenn Morris
@ 2016-04-23 17:54                     ` Achim Gratz
  2016-04-23 18:46                     ` Glenn Morris
  1 sibling, 0 replies; 32+ messages in thread
From: Achim Gratz @ 2016-04-23 17:54 UTC (permalink / raw)
  To: emacs-devel

Glenn Morris writes:
> Ie, you switched in place from master to the release branch without
> cleaning up first. You can't expect this to work. An older branch cannot
> reliably clean-up for a newer branch.

If Emacs had proper out-of-tree build it would.  With the current state
of affairs it might be better not to pretend that out-of-tree builds are
supposed to work because they don't.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds




^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-23 17:39                   ` Glenn Morris
  2016-04-23 17:54                     ` Achim Gratz
@ 2016-04-23 18:46                     ` Glenn Morris
  1 sibling, 0 replies; 32+ messages in thread
From: Glenn Morris @ 2016-04-23 18:46 UTC (permalink / raw)
  To: Achim Gratz; +Cc: emacs-devel


Anyway, sounds like using a dummy timestamp like (0 0 0 0) instead of t
might be better.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-24  5:56                         ` Eli Zaretskii
@ 2016-04-24  6:22                           ` Achim Gratz
  0 siblings, 0 replies; 32+ messages in thread
From: Achim Gratz @ 2016-04-24  6:22 UTC (permalink / raw)
  To: emacs-devel

Eli Zaretskii writes:
> I don't think this can be done reliably without completely cleaning
> your Git clone (with Git commands), in addition to "make distclean"
> etc.

No, you can't do that since .gitignore tells Fit to leave those files
alone. As I said before, the only command that removes those files is
"make extraclean".

> Emacs branches diverge too quickly for this to work (like it
> does with some other projects); it's why I use two separate directory
> trees to track both branches simultaneously.

Yes, that's what I'm using now and what I'd recommend to anyone with a
new enough Git to have "git worktree".  Don't bother with out-of-tree
builds, they just don't work the way you would expect them to.


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Wavetables for the Terratec KOMPLEXER:
http://Synth.Stromeko.net/Downloads.html#KomplexerWaves




^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-22 17:26 [emacs-announce] " Nicolas Petton
  2016-04-23 11:41 ` Achim Gratz
@ 2016-04-25 10:09 ` Phillip Lord
  2016-04-25 10:21   ` Eli Zaretskii
  1 sibling, 1 reply; 32+ messages in thread
From: Phillip Lord @ 2016-04-25 10:09 UTC (permalink / raw)
  To: emacs-devel


I've build the windows binaries for this pre-test.

One think I notice is that the splash screen is now in italics. Was this
deliberate?

Phil



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-25 10:09 ` Phillip Lord
@ 2016-04-25 10:21   ` Eli Zaretskii
  2016-04-25 13:25     ` Chris Zheng
  2016-04-25 22:30     ` Phillip Lord
  0 siblings, 2 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-25 10:21 UTC (permalink / raw)
  To: Phillip Lord; +Cc: emacs-devel

> From: phillip.lord@russet.org.uk (Phillip Lord)
> Date: Mon, 25 Apr 2016 11:09:12 +0100
> 
> I've build the windows binaries for this pre-test.

Thanks.

> One think I notice is that the splash screen is now in italics.

It isn't here.  Can you show a screenshot?



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-25 10:21   ` Eli Zaretskii
@ 2016-04-25 13:25     ` Chris Zheng
  2016-04-26  5:45       ` Eli Zaretskii
  2016-04-25 22:30     ` Phillip Lord
  1 sibling, 1 reply; 32+ messages in thread
From: Chris Zheng @ 2016-04-25 13:25 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel@gnu.org


[-- Attachment #1.1: Type: text/plain, Size: 424 bytes --]

Hi Eli,

The attached is the screenshot running with `emacs -Q'.



On Mon, Apr 25, 2016 at 6:21 PM, Eli Zaretskii <eliz@gnu.org> wrote:

> > From: phillip.lord@russet.org.uk (Phillip Lord)
> > Date: Mon, 25 Apr 2016 11:09:12 +0100
> >
> > I've build the windows binaries for this pre-test.
>
> Thanks.
>
> > One think I notice is that the splash screen is now in italics.
>
> It isn't here.  Can you show a screenshot?
>
>

[-- Attachment #1.2: Type: text/html, Size: 904 bytes --]

[-- Attachment #2: splash.png --]
[-- Type: image/png, Size: 61040 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-25 10:21   ` Eli Zaretskii
  2016-04-25 13:25     ` Chris Zheng
@ 2016-04-25 22:30     ` Phillip Lord
  2016-04-26 13:43       ` Eli Zaretskii
  1 sibling, 1 reply; 32+ messages in thread
From: Phillip Lord @ 2016-04-25 22:30 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

>> From: phillip.lord@russet.org.uk (Phillip Lord)
>> Date: Mon, 25 Apr 2016 11:09:12 +0100
>> 
>> I've build the windows binaries for this pre-test.
>
> Thanks.
>
>> One think I notice is that the splash screen is now in italics.
>
> It isn't here.  Can you show a screenshot?

Do you mean, your build isn't in italics, or my build isn't in italics?

The screen by Chris is exactly what I am getting. I don't see the same
thing with previous pretests.

Phil



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-25 13:25     ` Chris Zheng
@ 2016-04-26  5:45       ` Eli Zaretskii
  2016-04-26 16:49         ` Phillip Lord
  0 siblings, 1 reply; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-26  5:45 UTC (permalink / raw)
  To: Chris Zheng; +Cc: emacs-devel

> Date: Mon, 25 Apr 2016 21:25:59 +0800
> From: Chris Zheng <chriszheng99@gmail.com>
> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
> 
> The attached is the screenshot running with `emacs -Q'.

Unbelievable!

AFAICT, the font used is actually bold-italic, not just italic, right?
When you click S-mouse-1 and select "Change Buffer Font" from the menu
that pops up, which font is shown as the current one?

Anyway, I have no idea what could cause this, it certainly doesn't
happen to me with the binary of the same tarball I built myself.  Does
anyone else see that with 25.0.93 pretest (or the latest emacs-25
branch)?  If not, I guess Phillip will have to see how this build was
different from the previous one he did.

Thanks.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-25 22:30     ` Phillip Lord
@ 2016-04-26 13:43       ` Eli Zaretskii
  2016-04-26 13:57         ` Kaushal Modi
  0 siblings, 1 reply; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-26 13:43 UTC (permalink / raw)
  To: Phillip Lord; +Cc: emacs-devel

> From: phillip.lord@russet.org.uk (Phillip Lord)
> Cc: emacs-devel@gnu.org
> Date: Mon, 25 Apr 2016 23:30:39 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: phillip.lord@russet.org.uk (Phillip Lord)
> >> Date: Mon, 25 Apr 2016 11:09:12 +0100
> >> 
> >> I've build the windows binaries for this pre-test.
> >
> > Thanks.
> >
> >> One think I notice is that the splash screen is now in italics.
> >
> > It isn't here.  Can you show a screenshot?
> 
> Do you mean, your build isn't in italics, or my build isn't in italics?

The former, of course.

> The screen by Chris is exactly what I am getting. I don't see the same
> thing with previous pretests.

And I don't see this with the current pretest (or any of the previous
ones), and not with the current emacs-25 branch.  It is something in
the way you built this pretest, I presume.  Or maybe I'm missing
something.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 13:43       ` Eli Zaretskii
@ 2016-04-26 13:57         ` Kaushal Modi
  0 siblings, 0 replies; 32+ messages in thread
From: Kaushal Modi @ 2016-04-26 13:57 UTC (permalink / raw)
  To: Eli Zaretskii, Phillip Lord; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 1234 bytes --]

In the *About GNU Emacs* buffer (C-h C-a), I see those bold italics from
Chris Zheng's build (as he sees the same too, of course).
I don't see that on my latest build of emacs-25 as of yesterday on RHEL 6.6.

On Tue, Apr 26, 2016 at 9:43 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: phillip.lord@russet.org.uk (Phillip Lord)
> > Cc: emacs-devel@gnu.org
> > Date: Mon, 25 Apr 2016 23:30:39 +0100
> >
> > Eli Zaretskii <eliz@gnu.org> writes:
> >
> > >> From: phillip.lord@russet.org.uk (Phillip Lord)
> > >> Date: Mon, 25 Apr 2016 11:09:12 +0100
> > >>
> > >> I've build the windows binaries for this pre-test.
> > >
> > > Thanks.
> > >
> > >> One think I notice is that the splash screen is now in italics.
> > >
> > > It isn't here.  Can you show a screenshot?
> >
> > Do you mean, your build isn't in italics, or my build isn't in italics?
>
> The former, of course.
>
> > The screen by Chris is exactly what I am getting. I don't see the same
> > thing with previous pretests.
>
> And I don't see this with the current pretest (or any of the previous
> ones), and not with the current emacs-25 branch.  It is something in
> the way you built this pretest, I presume.  Or maybe I'm missing
> something.
>
> --

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1999 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
@ 2016-04-26 14:26 Angelo Graziosi
  2016-04-26 16:06 ` Kaushal Modi
                   ` (2 more replies)
  0 siblings, 3 replies; 32+ messages in thread
From: Angelo Graziosi @ 2016-04-26 14:26 UTC (permalink / raw)
  To: Emacs developers; +Cc: eliz

Eli Zaretskii wrote:
> Unbelievable!
>
> AFAICT, the font used is actually bold-italic, not just italic, right?

I see that on master too...

Not only the About Emacs buffer is in bold-italic but also the tooltips..

It is some time (about a month) I see this, but only with Windows 
(MSYS2/MINGW64) builds.

I didn't flag this because I thought it was a deliberate choice (maybe 
it still is for master)..

   Angelo



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 14:26 Emacs pretest 25.0.93 Angelo Graziosi
@ 2016-04-26 16:06 ` Kaushal Modi
  2016-04-26 16:23 ` Eli Zaretskii
  2016-04-26 16:31 ` Eli Zaretskii
  2 siblings, 0 replies; 32+ messages in thread
From: Kaushal Modi @ 2016-04-26 16:06 UTC (permalink / raw)
  To: Angelo Graziosi, Emacs developers; +Cc: eliz

[-- Attachment #1: Type: text/plain, Size: 766 bytes --]

This seems to be the only Windows fonts related commit in the past month or
so (to my unexperienced eye):

http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-25&id=7eba90c12227d86636aaa3da8d68b0c213fb3910

On Tue, Apr 26, 2016 at 10:26 AM Angelo Graziosi <angelo.graziosi@alice.it>
wrote:

> Eli Zaretskii wrote:
> > Unbelievable!
> >
> > AFAICT, the font used is actually bold-italic, not just italic, right?
>
> I see that on master too...
>
> Not only the About Emacs buffer is in bold-italic but also the tooltips..
>
> It is some time (about a month) I see this, but only with Windows
> (MSYS2/MINGW64) builds.
>
> I didn't flag this because I thought it was a deliberate choice (maybe
> it still is for master)..
>
>    Angelo
>
> --

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1283 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 14:26 Emacs pretest 25.0.93 Angelo Graziosi
  2016-04-26 16:06 ` Kaushal Modi
@ 2016-04-26 16:23 ` Eli Zaretskii
  2016-04-26 16:31 ` Eli Zaretskii
  2 siblings, 0 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-26 16:23 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: emacs-devel

> Cc: eliz@gnu.org
> From: Angelo Graziosi <angelo.graziosi@alice.it>
> Date: Tue, 26 Apr 2016 16:26:44 +0200
> 
> > AFAICT, the font used is actually bold-italic, not just italic, right?
> 
> I see that on master too...
> 
> Not only the About Emacs buffer is in bold-italic but also the tooltips..
> 
> It is some time (about a month) I see this, but only with Windows 
> (MSYS2/MINGW64) builds.
> 
> I didn't flag this because I thought it was a deliberate choice (maybe 
> it still is for master)..

No, it is not deliberate.

I hope someone who sees this could bisect this.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 14:26 Emacs pretest 25.0.93 Angelo Graziosi
  2016-04-26 16:06 ` Kaushal Modi
  2016-04-26 16:23 ` Eli Zaretskii
@ 2016-04-26 16:31 ` Eli Zaretskii
  2016-04-26 16:44   ` Eli Zaretskii
  2016-04-26 19:54   ` Angelo Graziosi
  2 siblings, 2 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-26 16:31 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: emacs-devel

> From: Angelo Graziosi <angelo.graziosi@alice.it>
> Date: Tue, 26 Apr 2016 16:26:44 +0200
> Cc: eliz@gnu.org
> 
> I see that on master too...
> 
> Not only the About Emacs buffer is in bold-italic but also the tooltips..
> 
> It is some time (about a month) I see this, but only with Windows 
> (MSYS2/MINGW64) builds.
> 
> I didn't flag this because I thought it was a deliberate choice (maybe 
> it still is for master)..

What font do you see in *scratch*, after dismissing the splash screen?
Is it also bold-italic, or is it the normal default?



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 16:31 ` Eli Zaretskii
@ 2016-04-26 16:44   ` Eli Zaretskii
  2016-04-26 16:49     ` Kaushal Modi
  2016-04-27  8:52     ` Angelo Graziosi
  2016-04-26 19:54   ` Angelo Graziosi
  1 sibling, 2 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-26 16:44 UTC (permalink / raw)
  To: angelo.graziosi; +Cc: emacs-devel

> Date: Tue, 26 Apr 2016 19:31:14 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: emacs-devel@gnu.org
> 
> What font do you see in *scratch*, after dismissing the splash screen?
> Is it also bold-italic, or is it the normal default?

Also, what do you see in the display produced by
"M-x list-faces-display RET", under "variable-pitch"?

Is it the same bold-italic font that you see on the
splash screen?



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 16:44   ` Eli Zaretskii
@ 2016-04-26 16:49     ` Kaushal Modi
  2016-04-27  8:52     ` Angelo Graziosi
  1 sibling, 0 replies; 32+ messages in thread
From: Kaushal Modi @ 2016-04-26 16:49 UTC (permalink / raw)
  To: Eli Zaretskii, angelo.graziosi; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 681 bytes --]

Yes, this screen cap is from Chris Zheng's build:
http://i.imgur.com/vpQJ4qj.png
It's with my config loaded, but I see the same bold italics in emacs -Q too.

On Tue, Apr 26, 2016 at 12:44 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Tue, 26 Apr 2016 19:31:14 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: emacs-devel@gnu.org
> >
> > What font do you see in *scratch*, after dismissing the splash screen?
> > Is it also bold-italic, or is it the normal default?
>
> Also, what do you see in the display produced by
> "M-x list-faces-display RET", under "variable-pitch"?
>
> Is it the same bold-italic font that you see on the
> splash screen?
>
> --

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1215 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26  5:45       ` Eli Zaretskii
@ 2016-04-26 16:49         ` Phillip Lord
  2016-04-26 17:26           ` Eli Zaretskii
  0 siblings, 1 reply; 32+ messages in thread
From: Phillip Lord @ 2016-04-26 16:49 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: Chris Zheng, emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Mon, 25 Apr 2016 21:25:59 +0800
>> From: Chris Zheng <chriszheng99@gmail.com>
>> Cc: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
>> 
>> The attached is the screenshot running with `emacs -Q'.
>
> Unbelievable!
>
> AFAICT, the font used is actually bold-italic, not just italic, right?
> When you click S-mouse-1 and select "Change Buffer Font" from the menu
> that pops up, which font is shown as the current one?
>
> Anyway, I have no idea what could cause this, it certainly doesn't
> happen to me with the binary of the same tarball I built myself.  Does
> anyone else see that with 25.0.93 pretest (or the latest emacs-25
> branch)?  If not, I guess Phillip will have to see how this build was
> different from the previous one he did.

AFAICT, I did nothing different.

I had a go at bisecting this, and the results are so surprising, that I
need to replicate them on a different machine....


git bisect start
# bad: [5c587fdff164e8b90beb47f6da64b4884290e40a] Bump version to 25.0.93
git bisect bad 5c587fdff164e8b90beb47f6da64b4884290e40a
# good: [6287381da495ac5cc2a2a4acb7f49825677a44c8] ; Auto-commit of loaddefs files.
git bisect good 6287381da495ac5cc2a2a4acb7f49825677a44c8
# bad: [45577d548d3abfe504d3f936b3c9b997d0cf7f9c] Avoid GTK 3 crash with icons and masks
git bisect bad 45577d548d3abfe504d3f936b3c9b997d0cf7f9c
# good: [26b56dc739460bfd35bd12b4aca7434d381d9ef5] Fix some single quotes in documentation
git bisect good 26b56dc739460bfd35bd12b4aca7434d381d9ef5
# good: [9094304a9c109495bf2212a713df1b07270d15cd] * lisp/progmodes/xref.el (xref-buffer-name, xref--window): Move definitions before use.
git bisect good 9094304a9c109495bf2212a713df1b07270d15cd
# good: [d8b2ce5f8a6a849e55b48699dfa0e769a4b9a3f6] Ignore invalid base64 encoded embedded images
git bisect good d8b2ce5f8a6a849e55b48699dfa0e769a4b9a3f6
# good: [c0165ea4d6ecf81db6728782c7322c311ee0a783] Resurrect GNUS-NEWS autogeneration
git bisect good c0165ea4d6ecf81db6728782c7322c311ee0a783
# bad: [7eba90c12227d86636aaa3da8d68b0c213fb3910] Improve font selection by family on MS-Windows
git bisect bad 7eba90c12227d86636aaa3da8d68b0c213fb3910
# good: [9524ec5e4e3c7c3036f2640b2595d3755894c1b3] Ignore more merges when generating ChangeLog
git bisect good 9524ec5e4e3c7c3036f2640b2595d3755894c1b3
# bad: [73d213f2816876fe9c6c429e75a3be5454a42b34] Comint, term, and compile now set EMACS
git bisect bad 73d213f2816876fe9c6c429e75a3be5454a42b34
# first bad commit: [73d213f2816876fe9c6c429e75a3be5454a42b34] Comint, term, and compile now set EMACS


So, it's *that* commit again, setting EMACS=t. And here is the irony;
that commit has largely been reverted on current emacs-25.

I probably wont be able to test this on another machine today, so, I'm
sending this in case anyone has time to try the last two commits in the
bisect.

Phil



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 16:49         ` Phillip Lord
@ 2016-04-26 17:26           ` Eli Zaretskii
  2016-04-26 17:45             ` Phillip Lord
  2016-04-26 18:29             ` Eli Zaretskii
  0 siblings, 2 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-26 17:26 UTC (permalink / raw)
  To: Phillip Lord; +Cc: chriszheng99, emacs-devel

> From: phillip.lord@russet.org.uk (Phillip Lord)
> Cc: Chris Zheng <chriszheng99@gmail.com>,  emacs-devel@gnu.org
> Date: Tue, 26 Apr 2016 17:49:45 +0100
> 
> I had a go at bisecting this, and the results are so surprising, that I
> need to replicate them on a different machine....

I don't know what happened with your bisecting, because the culprit is
indeed 7eba90c12227d86636aaa3da8d68b0c213fb3910.  What happens is that
the variable-pitch face picks up a bold-italic font.  This is why
tooltips also display in that font: they use variable-pitch.

The strange thing is, I cannot see the problem on my main development
system. only on another box.  Maybe it has something to do with font
setup, I don't know.

I cannot just revert that commit, because it fixed a problem that is
no less serious.  Ideas welcome.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 17:26           ` Eli Zaretskii
@ 2016-04-26 17:45             ` Phillip Lord
  2016-04-26 18:29             ` Eli Zaretskii
  1 sibling, 0 replies; 32+ messages in thread
From: Phillip Lord @ 2016-04-26 17:45 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: chriszheng99, emacs-devel, Phillip Lord

On Tue, April 26, 2016 6:26 pm, Eli Zaretskii wrote:
>> From: phillip.lord@russet.org.uk (Phillip Lord)
>> Cc: Chris Zheng <chriszheng99@gmail.com>,  emacs-devel@gnu.org
>> Date: Tue, 26 Apr 2016 17:49:45 +0100
>>
>>
>> I had a go at bisecting this, and the results are so surprising, that I
>>  need to replicate them on a different machine....
>
> I don't know what happened with your bisecting, because the culprit is
> indeed 7eba90c12227d86636aaa3da8d68b0c213fb3910.

I'm terrible at manual bisects:-)

Ah, well, I thought my result was odd indeed.





^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 17:26           ` Eli Zaretskii
  2016-04-26 17:45             ` Phillip Lord
@ 2016-04-26 18:29             ` Eli Zaretskii
  2016-04-26 19:09               ` Kaushal Modi
  2016-04-26 19:32               ` Stephen Leake
  1 sibling, 2 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-26 18:29 UTC (permalink / raw)
  To: phillip.lord, chriszheng99; +Cc: emacs-devel

> Date: Tue, 26 Apr 2016 20:26:41 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: chriszheng99@gmail.com, emacs-devel@gnu.org
> 
> I cannot just revert that commit, because it fixed a problem that is
> no less serious.  Ideas welcome.

Could people who are affected please try this kludgey workaround, and
see if it gives good results?  Thanks.

(Of course, if someone has got a better idea, please speak up.)

diff --git a/lisp/faces.el b/lisp/faces.el
index 612bd16..3d3adaa 100644
--- a/lisp/faces.el
+++ b/lisp/faces.el
@@ -2281,7 +2281,9 @@ fixed-pitch
   :group 'basic-faces)
 
 (defface variable-pitch
-  '((t :family "Sans Serif"))
+  '((((type w32))
+     :font "-outline-Arial-normal-normal-normal-sans-*-*-*-*-p-*-iso8859-1")
+    (t :family "Sans Serif"))
   "The basic variable-pitch face."
   :group 'basic-faces)
 



^ permalink raw reply related	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 18:29             ` Eli Zaretskii
@ 2016-04-26 19:09               ` Kaushal Modi
  2016-04-26 19:14                 ` Eli Zaretskii
  2016-04-26 19:32               ` Stephen Leake
  1 sibling, 1 reply; 32+ messages in thread
From: Kaushal Modi @ 2016-04-26 19:09 UTC (permalink / raw)
  To: Eli Zaretskii, phillip.lord, chriszheng99; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 1583 bytes --]

I don't have the setup to build emacs on Windows. So I tried applying your
patch just to <emacs extracted dir>/share/emacs/25.0.93/lisp/faces.el,
recompiling faces.elc and restarting emacs. But the variable-pitch is still
"Sans Serif" family instead of being set to Arial.

On my windows, C-h v system-type gives windows-nt. So I replaced w32 with
windows-nt, recompiled faces.elc, restarted emacs, and still nothing
happened.

I am not sure I any of my previous emails were received, but FWIW, I cannot
figure out if edits to that faces.el are being effective on Windows, or if
that patch is working for me.

On Tue, Apr 26, 2016 at 2:30 PM Eli Zaretskii <eliz@gnu.org> wrote:

> > Date: Tue, 26 Apr 2016 20:26:41 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: chriszheng99@gmail.com, emacs-devel@gnu.org
> >
> > I cannot just revert that commit, because it fixed a problem that is
> > no less serious.  Ideas welcome.
>
> Could people who are affected please try this kludgey workaround, and
> see if it gives good results?  Thanks.
>
> (Of course, if someone has got a better idea, please speak up.)
>
> diff --git a/lisp/faces.el b/lisp/faces.el
> index 612bd16..3d3adaa 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -2281,7 +2281,9 @@ fixed-pitch
>    :group 'basic-faces)
>
>  (defface variable-pitch
> -  '((t :family "Sans Serif"))
> +  '((((type w32))
> +     :font
> "-outline-Arial-normal-normal-normal-sans-*-*-*-*-p-*-iso8859-1")
> +    (t :family "Sans Serif"))
>    "The basic variable-pitch face."
>    :group 'basic-faces)
>
>
> --

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2281 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 19:09               ` Kaushal Modi
@ 2016-04-26 19:14                 ` Eli Zaretskii
  2016-04-26 19:28                   ` Kaushal Modi
  0 siblings, 1 reply; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-26 19:14 UTC (permalink / raw)
  To: Kaushal Modi; +Cc: chriszheng99, emacs-devel, phillip.lord

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Tue, 26 Apr 2016 19:09:18 +0000
> Cc: emacs-devel@gnu.org
> 
> I don't have the setup to build emacs on Windows. So I tried applying your patch just to <emacs extracted
> dir>/share/emacs/25.0.93/lisp/faces.el, recompiling faces.elc and restarting emacs. But the variable-pitch is
> still "Sans Serif" family instead of being set to Arial. 

No, it's not Sans Serif, it's Arial, just the bold-italic variant of
it.  Try this:

  M-: (face-font 'variable-pitch) RET

What do you see?

> On my windows, C-h v system-type gives windows-nt. So I replaced w32 with windows-nt, recompiled
> faces.elc, restarted emacs, and still nothing happened.

faces is preloaded, so it's not enough to recompile it.  And w32 is
correct, since it should name the frame type (a.k.a. 'window-system')
value, not the system type.

> I am not sure I any of my previous emails were received, but FWIW, I cannot figure out if edits to that faces.el
> are being effective on Windows, or if that patch is working for me.

You need to dump Emacs after byte-compiling faces.el.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 19:14                 ` Eli Zaretskii
@ 2016-04-26 19:28                   ` Kaushal Modi
  0 siblings, 0 replies; 32+ messages in thread
From: Kaushal Modi @ 2016-04-26 19:28 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: chriszheng99, phillip.lord, emacs-devel

[-- Attachment #1: Type: text/plain, Size: 762 bytes --]

>
> No, it's not Sans Serif, it's Arial, just the bold-italic variant of
> it.  Try this:
>
>   M-: (face-font 'variable-pitch) RET
>
> What do you see?
>

Correct, variable-pitch face is set to bold-italic variant of Arial; I get

"-outline-Arial-bold-italic-normal-sans-17-*-*-*-p-*-ascii-0"

I tried applying your patch but that was futile (I get the same result) as
I cannot build emacs on Windows.

faces is preloaded, so it's not enough to recompile it.  And w32 is
> correct, since it should name the frame type (a.k.a. 'window-system')
> value, not the system type.
>


> You need to dump Emacs after byte-compiling faces.el.
>

Thanks for that info. Some one who can build emacs on Windows should be
then able to verify the patch.
-- 

-- 
Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1391 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 18:29             ` Eli Zaretskii
  2016-04-26 19:09               ` Kaushal Modi
@ 2016-04-26 19:32               ` Stephen Leake
  2016-04-26 19:40                 ` Eli Zaretskii
  1 sibling, 1 reply; 32+ messages in thread
From: Stephen Leake @ 2016-04-26 19:32 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: chriszheng99, emacs-devel, phillip.lord

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Tue, 26 Apr 2016 20:26:41 +0300
>> From: Eli Zaretskii <eliz@gnu.org>
>> Cc: chriszheng99@gmail.com, emacs-devel@gnu.org
>> 
>> I cannot just revert that commit, because it fixed a problem that is
>> no less serious.  Ideas welcome.
>
> Could people who are affected please try this kludgey workaround, and
> see if it gives good results?  Thanks.

Fixes the problem for me, for both splash screen and tooltips.

>
>
> (Of course, if someone has got a better idea, please speak up.)
>
> diff --git a/lisp/faces.el b/lisp/faces.el
> index 612bd16..3d3adaa 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -2281,7 +2281,9 @@ fixed-pitch
>    :group 'basic-faces)
>  
>  (defface variable-pitch
> -  '((t :family "Sans Serif"))
> +  '((((type w32))
> +     :font "-outline-Arial-normal-normal-normal-sans-*-*-*-*-p-*-iso8859-1")
> +    (t :family "Sans Serif"))
>    "The basic variable-pitch face."
>    :group 'basic-faces)
>  
>
>

-- 
-- Stephe



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 19:32               ` Stephen Leake
@ 2016-04-26 19:40                 ` Eli Zaretskii
  2016-04-26 22:32                   ` Phillip Lord
  2016-04-30  9:57                   ` Eli Zaretskii
  0 siblings, 2 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-26 19:40 UTC (permalink / raw)
  To: Stephen Leake; +Cc: chriszheng99, emacs-devel, phillip.lord

> From: Stephen Leake <stephen_leake@stephe-leake.org>
> Cc: phillip.lord@russet.org.uk,  chriszheng99@gmail.com,  emacs-devel@gnu.org
> Date: Tue, 26 Apr 2016 14:32:38 -0500
> 
> > Could people who are affected please try this kludgey workaround, and
> > see if it gives good results?  Thanks.
> 
> Fixes the problem for me, for both splash screen and tooltips.

Thanks.

I will wait a few days for more feedback (and hopefully better ideas),
and commit after that, if nothing bad comes out.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 16:31 ` Eli Zaretskii
  2016-04-26 16:44   ` Eli Zaretskii
@ 2016-04-26 19:54   ` Angelo Graziosi
  1 sibling, 0 replies; 32+ messages in thread
From: Angelo Graziosi @ 2016-04-26 19:54 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel



Il 26/04/2016 18:31, Eli Zaretskii ha scritto:
>
> What font do you see in *scratch*, after dismissing the splash screen?
> Is it also bold-italic, or is it the normal default?
>

The normal font.

> Also, what do you see in the display produced by
> "M-x list-faces-display RET", under "variable-pitch"?
>
> Is it the same bold-italic font that you see on the
> splash screen?

Yes, it is bold-italic, the same of About..


   Angelo



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 19:40                 ` Eli Zaretskii
@ 2016-04-26 22:32                   ` Phillip Lord
  2016-04-27  7:25                     ` Eli Zaretskii
  2016-04-30  9:57                   ` Eli Zaretskii
  1 sibling, 1 reply; 32+ messages in thread
From: Phillip Lord @ 2016-04-26 22:32 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: chriszheng99, phillip.lord, Stephen Leake, emacs-devel

On Tue, April 26, 2016 8:40 pm, Eli Zaretskii wrote:
>> From: Stephen Leake <stephen_leake@stephe-leake.org>
>> Cc: phillip.lord@russet.org.uk,  chriszheng99@gmail.com,
>> emacs-devel@gnu.org Date: Tue, 26 Apr 2016 14:32:38 -0500
>>
>>
>>> Could people who are affected please try this kludgey workaround, and
>>>  see if it gives good results?  Thanks.
>>
>> Fixes the problem for me, for both splash screen and tooltips.
>>
>
> Thanks.
>
>
> I will wait a few days for more feedback (and hopefully better ideas),
> and commit after that, if nothing bad comes out.


Also, it works for me.




^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 22:32                   ` Phillip Lord
@ 2016-04-27  7:25                     ` Eli Zaretskii
  0 siblings, 0 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-27  7:25 UTC (permalink / raw)
  To: Phillip Lord; +Cc: chriszheng99, phillip.lord, stephen_leake, emacs-devel

> Date: Tue, 26 Apr 2016 23:32:45 +0100
> From: "Phillip Lord" <phillip.lord@russet.org.uk>
> Cc: "Stephen Leake" <stephen_leake@stephe-leake.org>,
>  chriszheng99@gmail.com,
>  emacs-devel@gnu.org,
>  phillip.lord@russet.org.uk
> 
> > I will wait a few days for more feedback (and hopefully better ideas),
> > and commit after that, if nothing bad comes out.
> 
> Also, it works for me.

Thanks.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 16:44   ` Eli Zaretskii
  2016-04-26 16:49     ` Kaushal Modi
@ 2016-04-27  8:52     ` Angelo Graziosi
  2016-04-27  9:21       ` Eli Zaretskii
  1 sibling, 1 reply; 32+ messages in thread
From: Angelo Graziosi @ 2016-04-27  8:52 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

Eli Zaretskii wrote:
> diff --git a/lisp/faces.el b/lisp/faces.el
> index 612bd16..3d3adaa 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -2281,7 +2281,9 @@ fixed-pitch
>    :group 'basic-faces)
>
>  (defface variable-pitch
> -  '((t :family "Sans Serif"))
> +  '((((type w32))
> +     :font "-outline-Arial-normal-normal-normal-sans-*-*-*-*-p-*-iso8859-1")
> +    (t :family "Sans Serif"))
>    "The basic variable-pitch face."
>    :group 'basic-faces



Your patch seems to work. Attached is the result.

  Angelo

[-- Attachment #2: Immagine.png --]
[-- Type: image/png, Size: 50397 bytes --]

^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-27  8:52     ` Angelo Graziosi
@ 2016-04-27  9:21       ` Eli Zaretskii
  0 siblings, 0 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-27  9:21 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: emacs-devel

> Cc: emacs-devel@gnu.org
> From: Angelo Graziosi <angelo.graziosi@alice.it>
> Date: Wed, 27 Apr 2016 10:52:58 +0200
> 
> Your patch seems to work. Attached is the result.

Thanks for the feedback.



^ permalink raw reply	[flat|nested] 32+ messages in thread

* Re: Emacs pretest 25.0.93
  2016-04-26 19:40                 ` Eli Zaretskii
  2016-04-26 22:32                   ` Phillip Lord
@ 2016-04-30  9:57                   ` Eli Zaretskii
  1 sibling, 0 replies; 32+ messages in thread
From: Eli Zaretskii @ 2016-04-30  9:57 UTC (permalink / raw)
  To: stephen_leake, chriszheng99, emacs-devel, phillip.lord

> Date: Tue, 26 Apr 2016 22:40:11 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: chriszheng99@gmail.com, emacs-devel@gnu.org, phillip.lord@russet.org.uk
> 
> > From: Stephen Leake <stephen_leake@stephe-leake.org>
> > Cc: phillip.lord@russet.org.uk,  chriszheng99@gmail.com,  emacs-devel@gnu.org
> > Date: Tue, 26 Apr 2016 14:32:38 -0500
> > 
> > > Could people who are affected please try this kludgey workaround, and
> > > see if it gives good results?  Thanks.
> > 
> > Fixes the problem for me, for both splash screen and tooltips.
> 
> Thanks.
> 
> I will wait a few days for more feedback (and hopefully better ideas),
> and commit after that, if nothing bad comes out.

Done.



^ permalink raw reply	[flat|nested] 32+ messages in thread

end of thread, other threads:[~2016-04-30  9:57 UTC | newest]

Thread overview: 32+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-26 14:26 Emacs pretest 25.0.93 Angelo Graziosi
2016-04-26 16:06 ` Kaushal Modi
2016-04-26 16:23 ` Eli Zaretskii
2016-04-26 16:31 ` Eli Zaretskii
2016-04-26 16:44   ` Eli Zaretskii
2016-04-26 16:49     ` Kaushal Modi
2016-04-27  8:52     ` Angelo Graziosi
2016-04-27  9:21       ` Eli Zaretskii
2016-04-26 19:54   ` Angelo Graziosi
  -- strict thread matches above, loose matches on Subject: below --
2016-04-22 17:26 [emacs-announce] " Nicolas Petton
2016-04-23 11:41 ` Achim Gratz
2016-04-23 12:05   ` Eli Zaretskii
2016-04-23 12:28     ` Achim Gratz
2016-04-23 12:37       ` Achim Gratz
2016-04-23 12:51         ` Eli Zaretskii
2016-04-23 13:29           ` Achim Gratz
2016-04-23 13:48             ` Eli Zaretskii
2016-04-23 15:20               ` Michael Heerdegen
2016-04-23 16:55                 ` Achim Gratz
2016-04-23 17:23                   ` Michael Heerdegen
2016-04-23 17:59                     ` Eli Zaretskii
2016-04-23 22:19                       ` Michael Heerdegen
2016-04-24  5:56                         ` Eli Zaretskii
2016-04-24  6:22                           ` Achim Gratz
2016-04-23 17:39                   ` Glenn Morris
2016-04-23 17:54                     ` Achim Gratz
2016-04-23 18:46                     ` Glenn Morris
2016-04-25 10:09 ` Phillip Lord
2016-04-25 10:21   ` Eli Zaretskii
2016-04-25 13:25     ` Chris Zheng
2016-04-26  5:45       ` Eli Zaretskii
2016-04-26 16:49         ` Phillip Lord
2016-04-26 17:26           ` Eli Zaretskii
2016-04-26 17:45             ` Phillip Lord
2016-04-26 18:29             ` Eli Zaretskii
2016-04-26 19:09               ` Kaushal Modi
2016-04-26 19:14                 ` Eli Zaretskii
2016-04-26 19:28                   ` Kaushal Modi
2016-04-26 19:32               ` Stephen Leake
2016-04-26 19:40                 ` Eli Zaretskii
2016-04-26 22:32                   ` Phillip Lord
2016-04-27  7:25                     ` Eli Zaretskii
2016-04-30  9:57                   ` Eli Zaretskii
2016-04-25 22:30     ` Phillip Lord
2016-04-26 13:43       ` Eli Zaretskii
2016-04-26 13:57         ` Kaushal Modi

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).