[lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[Richard M. Stallman]

Would someone like to fix this bug?

------- Start of forwarded message -------
Date: Wed, 23 Nov 2005 16:41:12 +0100
From: Lennart Borgman <lennart.borgman.073@student.lu.se>
X-Accept-Language: en-us, en
To: emacs-pretest-bug@gnu.org
Subject: Keys bound to [t] does not give any help
Sender: emacs-pretest-bug-bounces+rms=gnu.org@gnu.org
X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on monty-python
X-Spam-Level: 
X-Spam-Status: No, hits=0.9 required=5.0 tests=FROM_ENDS_IN_NUMS autolearn=no 
	version=2.63

If you bind default keyboard keys like this

    (define-key bw-keymap [t]  'bw-exit-resize-mode)

then

    C-h k

says that the key "is undefined".


In GNU Emacs 22.0.50.1 (i386-mingw-nt5.0.2195)
 of 2005-11-22



_______________________________________________
emacs-pretest-bug mailing list
emacs-pretest-bug@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-pretest-bug
------- End of forwarded message -------

Re: [lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[Chong Yidong]

> If you bind default keyboard keys like this
>
>     (define-key bw-keymap [t]  'bw-exit-resize-mode)
>
> then
>
>     C-h k
>
> says that the key "is undefined".

I don't get it.  What is the intended behavior of binding [t]?

Re: [lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[Lennart Borgman]

Chong Yidong wrote:

>>If you bind default keyboard keys like this
>>
>>    (define-key bw-keymap [t]  'bw-exit-resize-mode)
>>
>>then
>>
>>    C-h k
>>
>>says that the key "is undefined".
>>    
>>
>
>I don't get it.  What is the intended behavior of binding [t]?
>  
>
This sets a default binding in the keymap which is used when there is no 
binding for a key. It is different from binding to nil which is 
transparent so that the binding in the next keymap is used instead.

Re: [lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[Chong Yidong]

Lennart Borgman <lennart.borgman.073@student.lu.se> writes:

>>>If you bind default keyboard keys like this
>>>    (define-key bw-keymap [t]  'bw-exit-resize-mode)
>>>then
>>>    C-h k
>>>says that the key "is undefined".
>>
>>I don't get it.  What is the intended behavior of binding [t]?
>>  
> This sets a default binding in the keymap which is used when there is
> no binding for a key. It is different from binding to nil which is
> transparent so that the binding in the next keymap is used instead.

OK, now I get it.  But wouldn't C-h be overwritten when you bind [t]?
How did you get C-h to work?

Re: [lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[LENNART BORGMAN]

From: Chong Yidong <cyd@stupidchicken.com>

> >>>If you bind default keyboard keys like this
> >>>    (define-key bw-keymap [t]  'bw-exit-resize-mode)
> >>>then
> >>>    C-h k
> >>>says that the key "is undefined".
> >>
> >>I don't get it.  What is the intended behavior of binding [t]?
> >>  
> > This sets a default binding in the keymap which is used when 
> there is
> > no binding for a key. It is different from binding to nil which is
> > transparent so that the binding in the next keymap is used instead.
> 
> OK, now I get it.  But wouldn't C-h be overwritten when you bind [t]?
> How did you get C-h to work?

I have bount it in `bw-keymap' only.

Re: [lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[Chong Yidong]

LENNART BORGMAN <lennart.borgman.073@student.lu.se> writes:

>> >>> If you bind default keyboard keys like this
>> >>>    (define-key bw-keymap [t]  'bw-exit-resize-mode)
>> >>> then
>> >>>    C-h k
>> >>> says that the key "is undefined".
>> >>
>> OK, now I get it.  But wouldn't C-h be overwritten when you bind [t]?
>> How did you get C-h to work?
>
> I have bount it in `bw-keymap' only.

Does this change do what you want?

*** emacs/lisp/help.el.~1.287.~	2005-11-28 22:26:04.000000000 -0500
--- emacs/lisp/help.el	2005-11-28 22:22:13.000000000 -0500
***************
*** 635,641 ****
        (when (windowp window)
  	    (set-buffer (window-buffer window))
  	(goto-char position))
!       (let ((defn (or (string-key-binding key) (key-binding key))))
  	(if (or (null defn) (integerp defn) (equal defn 'undefined))
  	    (message "%s is undefined" (help-key-description key untranslated))
  	  (help-setup-xref (list #'describe-function defn) (interactive-p))
--- 635,641 ----
        (when (windowp window)
  	    (set-buffer (window-buffer window))
  	(goto-char position))
!       (let ((defn (or (string-key-binding key) (key-binding key t))))
  	(if (or (null defn) (integerp defn) (equal defn 'undefined))
  	    (message "%s is undefined" (help-key-description key untranslated))
  	  (help-setup-xref (list #'describe-function defn) (interactive-p))

Re: [lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[Lennart Borgman]

Chong Yidong wrote:

>LENNART BORGMAN <lennart.borgman.073@student.lu.se> writes:
>
>  
>
>>>>>>If you bind default keyboard keys like this
>>>>>>   (define-key bw-keymap [t]  'bw-exit-resize-mode)
>>>>>>then
>>>>>>   C-h k
>>>>>>says that the key "is undefined".
>>>>>>            
>>>>>>
>>>OK, now I get it.  But wouldn't C-h be overwritten when you bind [t]?
>>>How did you get C-h to work?
>>>      
>>>
>>I have bount it in `bw-keymap' only.
>>    
>>
>
>Does this change do what you want?
>
>*** emacs/lisp/help.el.~1.287.~	2005-11-28 22:26:04.000000000 -0500
>--- emacs/lisp/help.el	2005-11-28 22:22:13.000000000 -0500
>***************
>*** 635,641 ****
>        (when (windowp window)
>  	    (set-buffer (window-buffer window))
>  	(goto-char position))
>!       (let ((defn (or (string-key-binding key) (key-binding key))))
>  	(if (or (null defn) (integerp defn) (equal defn 'undefined))
>  	    (message "%s is undefined" (help-key-description key untranslated))
>  	  (help-setup-xref (list #'describe-function defn) (interactive-p))
>--- 635,641 ----
>        (when (windowp window)
>  	    (set-buffer (window-buffer window))
>  	(goto-char position))
>!       (let ((defn (or (string-key-binding key) (key-binding key t))))
>  	(if (or (null defn) (integerp defn) (equal defn 'undefined))
>  	    (message "%s is undefined" (help-key-description key untranslated))
>  	  (help-setup-xref (list #'describe-function defn) (interactive-p))
>
>  
>
Yes and no. It gives the correct answer for "C-h k" I believe, but not 
for "C-h c".

BTW I just saw that C-h c gives a bit different results when using [t]:

     C-h c a: a runs the command self-insert-command
     C-h c RET: <return> is undefined

Re: [lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[Chong Yidong]

> Yes and no. It gives the correct answer for "C-h k" I believe, but not
> for "C-h c".
>
> BTW I just saw that C-h c gives a bit different results when using [t]:
>
>      C-h c a: a runs the command self-insert-command
>      C-h c RET: <return> is undefined

OK, I just committed a fix for both describe-key and describe-key-briefly.

Re: [lennart.borgman.073@student.lu.se: Keys bound to [t] does not give any help]

[Lennart Borgman]

Chong Yidong wrote:

>>Yes and no. It gives the correct answer for "C-h k" I believe, but not
>>for "C-h c".
>>
>>BTW I just saw that C-h c gives a bit different results when using [t]:
>>
>>     C-h c a: a runs the command self-insert-command
>>     C-h c RET: <return> is undefined
>>    
>>
>
>OK, I just committed a fix for both describe-key and describe-key-briefly.
>  
>
And it works. Thanks.