From: Lars Hansen <larsh@math.ku.dk>
Cc: emacs-devel@gnu.org
Subject: Re: No GCPRO in directory-files and directory-files-and-attributes
Date: Wed, 10 Dec 2003 19:45:56 +0100 [thread overview]
Message-ID: <3FD769E4.5080402@math.ku.dk> (raw)
In-Reply-To: <E1ATpjm-0000NV-Mz@fencepost.gnu.org>
>
>
>Calling call1 etc. does not GCPRO the variables from which the
>argument values are obtained, any more than calling Ffuncall does.
>
Well, I don't know much about these things, but these lines are from call1:
args[0] = fn;
args[1] = arg1;
GCPRO1 (args[0]);
gcpro1.nvars = 2;
RETURN_UNGCPRO (Ffuncall (2, args));
To me it looks as the arguments are protcted.
>I don't think there is a bug. Those values will never be used again,
>so they don't need to be GCPRO'd.
>
>
In eval.c there is the following comment:
/* NOTE!!! Every function that can call EVAL must protect its args
and temporaries from garbage collection while it needs them.
The definition of `For' shows what you have to do. */
When directory-files and directory-files-and-attributes call file name
handlers I think eval may be called.
So to me it still looks like a bug. Am I missing something?
next prev parent reply other threads:[~2003-12-10 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-01 22:32 No GCPRO in directory-files and directory-files-and-attributes Lars Hansen
2003-12-09 21:49 ` Richard Stallman
2003-12-10 18:45 ` Lars Hansen [this message]
2003-12-22 4:08 ` Richard Stallman
2003-12-22 7:22 ` Lars Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FD769E4.5080402@math.ku.dk \
--to=larsh@math.ku.dk \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).