From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Lars Hansen Newsgroups: gmane.emacs.devel Subject: Re: No GCPRO in directory-files and directory-files-and-attributes Date: Wed, 10 Dec 2003 19:45:56 +0100 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <3FD769E4.5080402@math.ku.dk> References: <3FCBC193.2080509@math.ku.dk> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1071082494 27464 80.91.224.253 (10 Dec 2003 18:54:54 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 10 Dec 2003 18:54:54 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Wed Dec 10 19:54:48 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AU9U0-0002g4-00 for ; Wed, 10 Dec 2003 19:54:48 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AU9Tz-0005zf-00 for ; Wed, 10 Dec 2003 19:54:47 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AUAM1-0007bv-9l for emacs-devel@quimby.gnus.org; Wed, 10 Dec 2003 14:50:37 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AUAJt-00053B-HV for emacs-devel@gnu.org; Wed, 10 Dec 2003 14:48:25 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AUAJ5-0003fg-PA for emacs-devel@gnu.org; Wed, 10 Dec 2003 14:48:08 -0500 Original-Received: from [62.84.220.10] (helo=post.kabelnettet.dk) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AUAJ4-0003Zu-Dg; Wed, 10 Dec 2003 14:47:34 -0500 Original-Received: from math.ku.dk [62.84.220.219] by post.kabelnettet.dk with ESMTP (SMTPD32-8.03) id AA2516002C0; Wed, 10 Dec 2003 19:47:01 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: da, en-us, en Original-To: rms@gnu.org In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:18625 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:18625 > > >Calling call1 etc. does not GCPRO the variables from which the >argument values are obtained, any more than calling Ffuncall does. > Well, I don't know much about these things, but these lines are from call1: args[0] = fn; args[1] = arg1; GCPRO1 (args[0]); gcpro1.nvars = 2; RETURN_UNGCPRO (Ffuncall (2, args)); To me it looks as the arguments are protcted. >I don't think there is a bug. Those values will never be used again, >so they don't need to be GCPRO'd. > > In eval.c there is the following comment: /* NOTE!!! Every function that can call EVAL must protect its args and temporaries from garbage collection while it needs them. The definition of `For' shows what you have to do. */ When directory-files and directory-files-and-attributes call file name handlers I think eval may be called. So to me it still looks like a bug. Am I missing something?