unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* make bootstrap error
@ 2003-05-04 17:42 Vinicius Jose Latorre
  0 siblings, 0 replies; 19+ messages in thread
From: Vinicius Jose Latorre @ 2003-05-04 17:42 UTC (permalink / raw)


Hi folks,

I've just downloaded Emacs sources (cvs -z3 update -dPA) and got the 
following error (make bootstrap):

(cd lisp; make  bootstrap EMACS=../src/bootstrap-emacs)
make[1]: Entering directory `/home/vinicius/work/emacs/lisp'
wd=/home/vinicius/work/emacs/lisp; subdirs=`find $wd -type d -print`; 
for file in $subdirs; do case $file in */Old | */RCS | */CVS | */CVS/* | 
*/=* ) ;; *) wins="$wins $file" ;; esac; done; \
for file in $wins; do \
   /home/vinicius/work/emacs/lisp/../update-subdirs $file; \
done;
wd=/home/vinicius/work/emacs/lisp; subdirs=`find $wd -type d -print`; 
for file in $subdirs; do case $file in */Old | */RCS | */CVS | */CVS/* | 
*/=* ) ;; *) wins="$wins $file" ;; esac; done; \
echo Directories: $wins; \
../src/bootstrap-emacs -batch --no-site-file --multibyte -l autoload 
--eval '(setq generated-autoload-file 
"/home/vinicius/work/emacs/lisp/loaddefs.el")' -f batch-update-autoloads 
$wins
Directories: /home/vinicius/work/emacs/lisp 
/home/vinicius/work/emacs/lisp/calc /home/vinicius/work/emacs/lisp/gnus 
/home/vinicius/work/emacs/lisp/calendar 
/home/vinicius/work/emacs/lisp/emacs-lisp 
/home/vinicius/work/emacs/lisp/emulation 
/home/vinicius/work/emacs/lisp/eshell 
/home/vinicius/work/emacs/lisp/international 
/home/vinicius/work/emacs/lisp/language 
/home/vinicius/work/emacs/lisp/mail /home/vinicius/work/emacs/lisp/mh-e 
/home/vinicius/work/emacs/lisp/net 
/home/vinicius/work/emacs/lisp/obsolete 
/home/vinicius/work/emacs/lisp/play 
/home/vinicius/work/emacs/lisp/progmodes 
/home/vinicius/work/emacs/lisp/term 
/home/vinicius/work/emacs/lisp/textmodes 
/home/vinicius/work/emacs/lisp/toolbar
Autoloading failed to define function update-autoloads-from-directories
make[1]: *** [autoloads] Error 255
make[1]: Leaving directory `/home/vinicius/work/emacs/lisp'
make: *** [bootstrap] Error 2

^ permalink raw reply	[flat|nested] 19+ messages in thread

* make bootstrap error
@ 2003-05-18  2:20 Vinicius Jose Latorre
  2003-05-18  2:32 ` Stefan Monnier
  0 siblings, 1 reply; 19+ messages in thread
From: Vinicius Jose Latorre @ 2003-05-18  2:20 UTC (permalink / raw)


Hi Folks,

I've just update my GNU Emacs copy (cvs -z3 update -dPA) and got the 
following error (make bootstrap):

./temacs --batch --load loadup bootstrap
Loading loadup.el (source)...
Using load-path (/home/vinicius/work/emacs/lisp 
/home/vinicius/work/emacs/lisp/emacs-lisp 
/home/vinicius/work/emacs/lisp/language 
/home/vinicius/work/emacs/lisp/international 
/home/vinicius/work/emacs/lisp/textmodes)
Loading byte-run (source)...
Loading emacs-lisp/backquote (source)...
Loading subr (source)...
Symbol's function definition is void: dolist
make[1]: *** [bootstrap-emacs] Error 255
make[1]: Leaving directory `/home/vinicius/work/emacs/src'
make: *** [bootstrap] Error 2


Regards,


Vinicius

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2003-05-18  2:20 Vinicius Jose Latorre
@ 2003-05-18  2:32 ` Stefan Monnier
  0 siblings, 0 replies; 19+ messages in thread
From: Stefan Monnier @ 2003-05-18  2:32 UTC (permalink / raw)
  Cc: emacs-devel

> I've just updated my GNU Emacs copy (cvs -z3 update -dPA) and got the 
> following error (make bootstrap):
> 
> ./temacs --batch --load loadup bootstrap
> Loading loadup.el (source)...
> Using load-path (/home/vinicius/work/emacs/lisp 
> /home/vinicius/work/emacs/lisp/emacs-lisp 
> /home/vinicius/work/emacs/lisp/language 
> /home/vinicius/work/emacs/lisp/international 
> /home/vinicius/work/emacs/lisp/textmodes)
> Loading byte-run (source)...
> Loading emacs-lisp/backquote (source)...
> Loading subr (source)...
> Symbol's function definition is void: dolist
> make[1]: *** [bootstrap-emacs] Error 255
> make[1]: Leaving directory `/home/vinicius/work/emacs/src'
> make: *** [bootstrap] Error 2

Oops, should be fixed now,


	Stefan

^ permalink raw reply	[flat|nested] 19+ messages in thread

* make bootstrap error
@ 2003-06-28  2:51 Vinicius Jose Latorre
  0 siblings, 0 replies; 19+ messages in thread
From: Vinicius Jose Latorre @ 2003-06-28  2:51 UTC (permalink / raw)


Hi,

Well, I've got the following error when I "make bootstrap":

........
Loading simple (source)...
Loading help (source)...
Loading international/mule-cmds (source)...
Symbol's value as variable is void: menu-bar-options-menu
make[1]: *** [bootstrap-emacs] Error 255
make[1]: Leaving directory `/home/vinicius/work/emacs/src'
make: *** [bootstrap] Error 2


Vinicius

^ permalink raw reply	[flat|nested] 19+ messages in thread

* make bootstrap error
@ 2017-07-30  4:20 Masaru Nomiya
  2017-07-30  5:11 ` Tino Calancha
  0 siblings, 1 reply; 19+ messages in thread
From: Masaru Nomiya @ 2017-07-30  4:20 UTC (permalink / raw)
  To: emacs-devel

Hello,

With the very latest git, I got 'make bootstrap error';

[...]
make[4]: Leaving directory '/tmp/mas/emacs/leim'
Directories for loaddefs: . ./calc ./calendar ./cedet ./cedet/ede ./cedet/semantic ./cedet/semantic/analyze ./cedet/semantic/bovine ./cedet/semantic/decorate ./cedet/semantic/symref ./cedet/semantic/wisent ./cedet/srecode ./emacs-lisp ./emulation ./erc ./eshell ./gnus ./image ./international ./language ./leim ./leim/ja-dic ./leim/quail ./mail ./mh-e ./net ./nxml ./org ./play ./progmodes ./textmodes ./url ./vc
  GEN      loaddefs.el
Not registering prefix "lo" from completion.  Affects: ("locate-completion-entry" "locate-completion-entry-retry" "locate-completion-db-error" "load-completions-from-file")
Not registering prefix "*" from ielm.  Affects: ("*" "**" "***" "*1" "*2" "*3")
Not registering prefix "is" from ind-util.  Affects: ("is13194-default-repertory" "is13194-repertory-to-ucs-script" "is13194-to-ucs-devanagari-hashtbl" "is13194-to-ucs-devanagari-regexp" "is13194-to-ucs-bengali-hashtbl" "is13194-to-ucs-bengali-regexp" "is13194-to-ucs-assamese-hashtbl" "is13194-to-ucs-assamese-regexp" "is13194-to-ucs-gurmukhi-hashtbl" "is13194-to-ucs-gurmukhi-regexp" "is13194-to-ucs-gujarati-hashtbl" "is13194-to-ucs-gujarati-regexp" "is13194-to-ucs-oriya-hashtbl" "is13194-to-ucs-oriya-regexp" "is13194-to-ucs-tamil-hashtbl" "is13194-to-ucs-tamil-regexp" "is13194-to-ucs-telugu-hashtbl" "is13194-to-ucs-telugu-regexp" "is13194-to-ucs-malayalam-hashtbl" "is13194-to-ucs-malayalam-regexp" "is13194-to-ucs-kannada-hashtbl" "is13194-to-ucs-kannada-regexp" "iscii-to-ucs-region")
Not registering prefix "se" from page-ext.  Affects: ("search-pages" "set-page-delimiter")
make[3]: Leaving directory '/tmp/mas/emacs/lisp'
make[2]: Leaving directory '/tmp/mas/emacs/src'
Makefile:416: recipe for target 'src' failed
make[1]: *** [src] Error 2
make[1]: Leaving directory '/tmp/mas/emacs'
Makefile:1097: recipe for target 'bootstrap' failed
make: *** [bootstrap] Error 2

Thansk,

---
M. Nomiya



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-07-30  4:20 Masaru Nomiya
@ 2017-07-30  5:11 ` Tino Calancha
  2017-07-30 11:35   ` Tino Calancha
  0 siblings, 1 reply; 19+ messages in thread
From: Tino Calancha @ 2017-07-30  5:11 UTC (permalink / raw)
  To: Masaru Nomiya; +Cc: rgm, eliz, Emacs developers



On Sun, 30 Jul 2017, Masaru Nomiya wrote:

> Hello,
>
> With the very latest git, I got 'make bootstrap error';
After commit 6f6639d6ed6c6314b2643f6c22498fc2e23d34c7
ls-lisp.el requires 'em-glob.  When eshell package is
compiled, teh following file is generated:
esh-groups.el

but ls-lisp.el is compiled _before_ eshell, so that
esh-groups.el doesn't exist yet.

Any idea what is the best approach to work around this issue?

Tino



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-07-30  5:11 ` Tino Calancha
@ 2017-07-30 11:35   ` Tino Calancha
  2017-07-30 12:42     ` Masaru Nomiya
  2017-07-30 14:11     ` Eli Zaretskii
  0 siblings, 2 replies; 19+ messages in thread
From: Tino Calancha @ 2017-07-30 11:35 UTC (permalink / raw)
  To: Masaru Nomiya; +Cc: rgm, eliz, Emacs developers



On Sun, 30 Jul 2017, Tino Calancha wrote:

>
>
> On Sun, 30 Jul 2017, Masaru Nomiya wrote:
>
>> Hello,
>> 
>> With the very latest git, I got 'make bootstrap error';
> After commit 6f6639d6ed6c6314b2643f6c22498fc2e23d34c7
> ls-lisp.el requires 'em-glob.  When eshell package is
> compiled, teh following file is generated:
> esh-groups.el
>
> but ls-lisp.el is compiled _before_ eshell, so that
> esh-groups.el doesn't exist yet.

I moved the "(require 'em-glob)" inside `ls-lisp--dired'
to not break the build.
Commit c8f44e4b53c40dfea1c83ad0ff3bd653e72c4f4e
(ls-lisp: Do not require em-glob at top of the file ...)

It works for my in Debian GNU/Linux 9.



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-07-30 11:35   ` Tino Calancha
@ 2017-07-30 12:42     ` Masaru Nomiya
  2017-07-30 12:56       ` Tino Calancha
  2017-07-30 14:11     ` Eli Zaretskii
  1 sibling, 1 reply; 19+ messages in thread
From: Masaru Nomiya @ 2017-07-30 12:42 UTC (permalink / raw)
  To: tino.calancha; +Cc: rgm, eliz, emacs-devel

Hello,

In the Message; 

  Subject    : Re: make bootstrap error
  Message-ID : <alpine.DEB.2.20.1707302032280.26649@calancha-pc>
  Date & Time: Sun, 30 Jul 2017 20:35:06 +0900 (JST)

Tino Calancha <tino.calancha@gmail.com> has written:

> On Sun, 30 Jul 2017, Tino Calancha wrote:

> > 
> > 
> > On Sun, 30 Jul 2017, Masaru Nomiya wrote:
> > 
> >> Hello,
> >> 
> >> With the very latest git, I got 'make bootstrap error';
> > After commit 6f6639d6ed6c6314b2643f6c22498fc2e23d34c7
> > ls-lisp.el requires 'em-glob.  When eshell package is
> > compiled, teh following file is generated:
> > esh-groups.el
> > 
> > but ls-lisp.el is compiled _before_ eshell, so that
> > esh-groups.el doesn't exist yet.

> I moved the "(require 'em-glob)" inside `ls-lisp--dired'
> to not break the build.
> Commit c8f44e4b53c40dfea1c83ad0ff3bd653e72c4f4e
> (ls-lisp: Do not require em-glob at top of the file ...)

> It works for my in Debian GNU/Linux 9.

Confirmed.

Thanks,

----
M. Nomiya



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-07-30 12:42     ` Masaru Nomiya
@ 2017-07-30 12:56       ` Tino Calancha
  0 siblings, 0 replies; 19+ messages in thread
From: Tino Calancha @ 2017-07-30 12:56 UTC (permalink / raw)
  To: Masaru Nomiya; +Cc: Emacs developers, Tino Calancha



On Sun, 30 Jul 2017, Masaru Nomiya wrote:

>> I moved the "(require 'em-glob)" inside `ls-lisp--dired'
>> to not break the build.
>> Commit c8f44e4b53c40dfea1c83ad0ff3bd653e72c4f4e
>> (ls-lisp: Do not require em-glob at top of the file ...)
>
>> It works for my in Debian GNU/Linux 9.
>
> Confirmed.
> ----
> M. Nomiya
Very good! Sorry for the trouble... it's too hot summer :-S
Tino



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-07-30 11:35   ` Tino Calancha
  2017-07-30 12:42     ` Masaru Nomiya
@ 2017-07-30 14:11     ` Eli Zaretskii
  2017-07-30 15:36       ` Tino Calancha
  1 sibling, 1 reply; 19+ messages in thread
From: Eli Zaretskii @ 2017-07-30 14:11 UTC (permalink / raw)
  To: Tino Calancha; +Cc: rgm, nomiya, emacs-devel

> From: Tino Calancha <tino.calancha@gmail.com>
> Date: Sun, 30 Jul 2017 20:35:06 +0900 (JST)
> cc: rgm@gnu.org, eliz@gnu.org, Emacs developers <emacs-devel@gnu.org>
> 
> > After commit 6f6639d6ed6c6314b2643f6c22498fc2e23d34c7
> > ls-lisp.el requires 'em-glob.  When eshell package is
> > compiled, teh following file is generated:
> > esh-groups.el
> >
> > but ls-lisp.el is compiled _before_ eshell, so that
> > esh-groups.el doesn't exist yet.
> 
> I moved the "(require 'em-glob)" inside `ls-lisp--dired'
> to not break the build.

Thanks, but I think this is still a bit fragile: it assumes that
ls-lisp--dired will never be called before Eshell files are compiled,
which might one day become false.

How about simply adding to ls-lisp.el an autoload form for em-glob,
instead of requiring it (with a suitable comment explaining why it is
there)?



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-07-30 14:11     ` Eli Zaretskii
@ 2017-07-30 15:36       ` Tino Calancha
  2017-07-30 15:55         ` Eli Zaretskii
  0 siblings, 1 reply; 19+ messages in thread
From: Tino Calancha @ 2017-07-30 15:36 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: rgm, tino.calancha, nomiya, emacs-devel

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Tino Calancha <tino.calancha@gmail.com>
>> Date: Sun, 30 Jul 2017 20:35:06 +0900 (JST)
>> cc: rgm@gnu.org, eliz@gnu.org, Emacs developers <emacs-devel@gnu.org>
>> 
>> > After commit 6f6639d6ed6c6314b2643f6c22498fc2e23d34c7
>> > ls-lisp.el requires 'em-glob.  When eshell package is
>> > compiled, teh following file is generated:
>> > esh-groups.el
>> >
>> > but ls-lisp.el is compiled _before_ eshell, so that
>> > esh-groups.el doesn't exist yet.
>> 
>> I moved the "(require 'em-glob)" inside `ls-lisp--dired'
>> to not break the build.
>
> Thanks, but I think this is still a bit fragile: it assumes that
> ls-lisp--dired will never be called before Eshell files are compiled,
> which might one day become false.
>
> How about simply adding to ls-lisp.el an autoload form for em-glob,
> instead of requiring it (with a suitable comment explaining why it is
> there)?
Thanks for the suggestion.
Proposed patch below:
--8<-----------------------------cut here---------------start------------->8---
commit 7bbc5990c05839520bae0deb407cba17f89b002e
Author: Tino Calancha <tino.calancha@gmail.com>
Date:   Mon Jul 31 00:33:33 2017 +0900

    ls-lisp: Autoload call instead of cookie
    
    * lisp/ls-lisp.el (eshell-extended-glob): autoload call instead of cookie.

diff --git a/lisp/ls-lisp.el b/lisp/ls-lisp.el
index 2f723ca8ac..9a4fc19744 100644
--- a/lisp/ls-lisp.el
+++ b/lisp/ls-lisp.el
@@ -479,14 +479,19 @@ ls-lisp-insert-directory
 	(message "%s: doesn't exist or is inaccessible" file)
 	(ding) (sit-for 2)))))		; to show user the message!
 
-
-(declare-function eshell-extended-glob "em-glob" (glob))
+;; We cannot require 'em-glob' in the top of the file:
+;; ls-lisp is compiled before than eshell, and esh-groups.el
+;; wouldn't be created yet.  If we require 'em-glob' inside
+;; `ls-lisp--dired', then this function cannot be called
+;; before eshell is compiled.
+;; So instead we add an autoload call here.
+;; (https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg01083.html).
+(autoload 'eshell-extended-glob "em-glob")
 (declare-function dired-read-dir-and-switches "dired" (str))
 (declare-function dired-goto-next-file "dired" ())
 
 (defun ls-lisp--dired (orig-fun dir-or-list &optional switches)
   (interactive (dired-read-dir-and-switches ""))
-  (require 'em-glob)
   (if (consp dir-or-list)
       (funcall orig-fun dir-or-list switches)
     (let ((dir-wildcard (insert-directory-wildcard-in-dir-p

--8<-----------------------------cut here---------------end--------------->8---
In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2017-07-30
Repository revision: c8f44e4b53c40dfea1c83ad0ff3bd653e72c4f4e



^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-07-30 15:36       ` Tino Calancha
@ 2017-07-30 15:55         ` Eli Zaretskii
  2017-08-02  9:13           ` Tino Calancha
  0 siblings, 1 reply; 19+ messages in thread
From: Eli Zaretskii @ 2017-07-30 15:55 UTC (permalink / raw)
  To: Tino Calancha; +Cc: rgm, nomiya, emacs-devel

> From: Tino Calancha <tino.calancha@gmail.com>
> Cc: rgm@gnu.org,  nomiya@galaxy.dti.ne.jp,  emacs-devel@gnu.org, tino.calancha@gmail.com
> Date: Mon, 31 Jul 2017 00:36:50 +0900
> 
> > How about simply adding to ls-lisp.el an autoload form for em-glob,
> > instead of requiring it (with a suitable comment explaining why it is
> > there)?
> Thanks for the suggestion.
> Proposed patch below:

Fine with me (obviously).  Let's wait for a couple of days for more
comments, and if no one objects, please push.

Thanks.



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-07-30 15:55         ` Eli Zaretskii
@ 2017-08-02  9:13           ` Tino Calancha
  0 siblings, 0 replies; 19+ messages in thread
From: Tino Calancha @ 2017-08-02  9:13 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: rgm, emacs-devel, nomiya, Tino Calancha



On Sun, 30 Jul 2017, Eli Zaretskii wrote:

>> From: Tino Calancha <tino.calancha@gmail.com>
>> Cc: rgm@gnu.org,  nomiya@galaxy.dti.ne.jp,  emacs-devel@gnu.org, tino.calancha@gmail.com
>> Date: Mon, 31 Jul 2017 00:36:50 +0900
>>
>>> How about simply adding to ls-lisp.el an autoload form for em-glob,
>>> instead of requiring it (with a suitable comment explaining why it is
>>> there)?
>> Thanks for the suggestion.
>> Proposed patch below:
>
> Fine with me (obviously).  Let's wait for a couple of days for more
> comments, and if no one objects, please push.
Pushed ino master branch as commit 
cf1da46761675f1886e54765fa213c7bd7d93437
(ls-lisp: Autoload call instead of cookie)




^ permalink raw reply	[flat|nested] 19+ messages in thread

* make bootstrap error
@ 2017-09-14  4:16 M.Nomiya
  2017-09-14 12:00 ` Ken Brown
  0 siblings, 1 reply; 19+ messages in thread
From: M.Nomiya @ 2017-09-14  4:16 UTC (permalink / raw)
  To: emacs-devel

Hello,

I got the error when running 'make bootstrap' for 3days;

[...]
  CC       lastfile.o
  CC       widget.o
  CCLD     temacs
sysdep.o: In function `renameat_noreplace':
/tmp/tes/emacs/src/sysdep.c:2693: undefined reference to `renameat2'
collect2: error: ld returned 1 exit status
Makefile:600: recipe for target 'temacs' failed
make[2]: *** [temacs] Error 1
make[2]: Leaving directory '/tmp/tes/emacs/src'
Makefile:416: recipe for target 'src' failed
make[1]: *** [src] Error 2
make[1]: Leaving directory '/tmp/tes/emacs'
Makefile:1096: recipe for target 'bootstrap' failed
make: *** [bootstrap] Error 2

---
M. Nomiya





^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-09-14  4:16 M.Nomiya
@ 2017-09-14 12:00 ` Ken Brown
  2017-09-14 12:11   ` M. Nomiya
  0 siblings, 1 reply; 19+ messages in thread
From: Ken Brown @ 2017-09-14 12:00 UTC (permalink / raw)
  To: M.Nomiya, emacs-devel; +Cc: Paul Eggert

On 9/14/2017 12:16 AM, M.Nomiya wrote:
> Hello,
> 
> I got the error when running 'make bootstrap' for 3days;
> 
> [...]
>    CC       lastfile.o
>    CC       widget.o
>    CCLD     temacs
> sysdep.o: In function `renameat_noreplace':
> /tmp/tes/emacs/src/sysdep.c:2693: undefined reference to `renameat2'

What platform are you building on?  It must be one on which 
RENAME_NOREPLACE is defined but SYS_renameat2 isn't.

Ken




^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-09-14 12:00 ` Ken Brown
@ 2017-09-14 12:11   ` M. Nomiya
  2017-09-14 12:22     ` Ken Brown
  0 siblings, 1 reply; 19+ messages in thread
From: M. Nomiya @ 2017-09-14 12:11 UTC (permalink / raw)
  To: kbrown; +Cc: eggert, emacs-devel

Hello,

In the Message; 

  Subject    : Re: make bootstrap error
  Message-ID : <8aee1f7e-5c40-509d-b918-e7247e5eb7e7@cornell.edu>
  Date & Time: Thu, 14 Sep 2017 08:00:47 -0400

Ken Brown <kbrown@cornell.edu> has written:

> On 9/14/2017 12:16 AM, M.Nomiya wrote:
> > Hello,
> > 
> > I got the error when running 'make bootstrap' for 3days;
> > 
> > [...]
> >    CC       lastfile.o
> >    CC       widget.o
> >    CCLD     temacs
> > sysdep.o: In function `renameat_noreplace':
> > /tmp/tes/emacs/src/sysdep.c:2693: undefined reference to `renameat2'

> What platform are you building on?

On linux, that is, openSUSE 12.3 x86_64.

> It must be one on which RENAME_NOREPLACE is
> defined but SYS_renameat2 isn't.

Is it?

What the matter, I wonder.....

---
 M. Nomiya



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-09-14 12:11   ` M. Nomiya
@ 2017-09-14 12:22     ` Ken Brown
  2017-09-14 14:26       ` Paul Eggert
  0 siblings, 1 reply; 19+ messages in thread
From: Ken Brown @ 2017-09-14 12:22 UTC (permalink / raw)
  To: M. Nomiya; +Cc: eggert, emacs-devel

On 9/14/2017 8:11 AM, M. Nomiya wrote:
> Hello,
> 
> In the Message;
> 
>    Subject    : Re: make bootstrap error
>    Message-ID : <8aee1f7e-5c40-509d-b918-e7247e5eb7e7@cornell.edu>
>    Date & Time: Thu, 14 Sep 2017 08:00:47 -0400
> 
> Ken Brown <kbrown@cornell.edu> has written:
> 
>> On 9/14/2017 12:16 AM, M.Nomiya wrote:
>>> Hello,
>>>
>>> I got the error when running 'make bootstrap' for 3days;
>>>
>>> [...]
>>>     CC       lastfile.o
>>>     CC       widget.o
>>>     CCLD     temacs
>>> sysdep.o: In function `renameat_noreplace':
>>> /tmp/tes/emacs/src/sysdep.c:2693: undefined reference to `renameat2'
> 
>> What platform are you building on?
> 
> On linux, that is, openSUSE 12.3 x86_64.
> 
>> It must be one on which RENAME_NOREPLACE is
>> defined but SYS_renameat2 isn't.
> 
> Is it?
> 
> What the matter, I wonder.....

Paul, any idea why SYS_renameat2 would be undefined on openSUSE 12.3 x86_64?

Ken



^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-09-14 12:22     ` Ken Brown
@ 2017-09-14 14:26       ` Paul Eggert
  2017-09-14 22:12         ` M. Nomiya
  0 siblings, 1 reply; 19+ messages in thread
From: Paul Eggert @ 2017-09-14 14:26 UTC (permalink / raw)
  To: Ken Brown, M. Nomiya; +Cc: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

Ken Brown wrote:
> Paul, any idea why SYS_renameat2 would be undefined on openSUSE 12.3 x86_64?

Haven't a clue, but the workaround should be easy enough. I installed the 
attached; please give it a try. If some platform other than Cygwin starts 
supporting renameat2 we can put a test into configure.ac and change "defined 
CYGWIN" to "HAVE_RENAME2".

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Port-renameat_noreplace-to-openSUSE-12.3.patch --]
[-- Type: text/x-patch; name="0001-Port-renameat_noreplace-to-openSUSE-12.3.patch", Size: 1090 bytes --]

From bc5485edeff0ccb3fbcc7fe6b6f13c666699e959 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 14 Sep 2017 07:23:13 -0700
Subject: [PATCH] Port renameat_noreplace to openSUSE 12.3

Problem reported by M. Nomiya in:
http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00363.html
* src/sysdep.c (renameat_noreplace):
Call renameat2 only if CYGWIN.
---
 src/sysdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/sysdep.c b/src/sysdep.c
index 318d4eb..1e6e0d0 100644
--- a/src/sysdep.c
+++ b/src/sysdep.c
@@ -2689,7 +2689,7 @@ renameat_noreplace (int srcfd, char const *src, int dstfd, char const *dst)
 {
 #if defined SYS_renameat2 && defined RENAME_NOREPLACE
   return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);
-#elif defined RENAME_NOREPLACE	/* Cygwin >= 2.9.0. */
+#elif defined CYGWIN && defined RENAME_NOREPLACE
   return renameat2 (srcfd, src, dstfd, dst, RENAME_NOREPLACE);
 #elif defined RENAME_EXCL
   return renameatx_np (srcfd, src, dstfd, dst, RENAME_EXCL);
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: make bootstrap error
  2017-09-14 14:26       ` Paul Eggert
@ 2017-09-14 22:12         ` M. Nomiya
  0 siblings, 0 replies; 19+ messages in thread
From: M. Nomiya @ 2017-09-14 22:12 UTC (permalink / raw)
  To: eggert; +Cc: kbrown, emacs-devel

Hello,

In the Message; 

  Subject    : Re: make bootstrap error
  Message-ID : <ac0dd945-94ae-1657-9c86-e5440b4e71a6@cs.ucla.edu>
  Date & Time: Thu, 14 Sep 2017 07:26:24 -0700

Paul Eggert <eggert@cs.ucla.edu> has written:

> [1  <text/plain; utf-8 (quoted-printable)>]
> Ken Brown wrote:
> > Paul, any idea why SYS_renameat2 would be undefined on openSUSE 12.3 x86_64?

> Haven't a clue, but the workaround should be easy enough. I installed the
> attached; please give it a try. If some platform other than Cygwin starts
> supporting renameat2 we can put a test into configure.ac and change "defined
> CYGWIN" to "HAVE_RENAME2".
> [2 0001-Port-renameat_noreplace-to-openSUSE-12.3.patch <text/x-patch (quoted-printable)>]
> From bc5485edeff0ccb3fbcc7fe6b6f13c666699e959 Mon Sep 17 00:00:00 2001
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Thu, 14 Sep 2017 07:23:13 -0700
> Subject: [PATCH] Port renameat_noreplace to openSUSE 12.3

> Problem reported by M. Nomiya in:
> http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00363.html
> * src/sysdep.c (renameat_noreplace):
> Call renameat2 only if CYGWIN.
> ---
>  src/sysdep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/src/sysdep.c b/src/sysdep.c
> index 318d4eb..1e6e0d0 100644
> --- a/src/sysdep.c
> +++ b/src/sysdep.c
> @@ -2689,7 +2689,7 @@ renameat_noreplace (int srcfd, char const *src, int dstfd, char const *dst)
>  {
>  #if defined SYS_renameat2 && defined RENAME_NOREPLACE
>    return syscall (SYS_renameat2, srcfd, src, dstfd, dst, RENAME_NOREPLACE);
> -#elif defined RENAME_NOREPLACE	/* Cygwin >= 2.9.0. */
> +#elif defined CYGWIN && defined RENAME_NOREPLACE
>    return renameat2 (srcfd, src, dstfd, dst, RENAME_NOREPLACE);
>  #elif defined RENAME_EXCL
>    return renameatx_np (srcfd, src, dstfd, dst, RENAME_EXCL);
> -- 
> 2.7.4

I could compile.

Thanks a lot.

Regards,

----
M. Nomiya



^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2017-09-14 22:12 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-05-04 17:42 make bootstrap error Vinicius Jose Latorre
  -- strict thread matches above, loose matches on Subject: below --
2003-05-18  2:20 Vinicius Jose Latorre
2003-05-18  2:32 ` Stefan Monnier
2003-06-28  2:51 Vinicius Jose Latorre
2017-07-30  4:20 Masaru Nomiya
2017-07-30  5:11 ` Tino Calancha
2017-07-30 11:35   ` Tino Calancha
2017-07-30 12:42     ` Masaru Nomiya
2017-07-30 12:56       ` Tino Calancha
2017-07-30 14:11     ` Eli Zaretskii
2017-07-30 15:36       ` Tino Calancha
2017-07-30 15:55         ` Eli Zaretskii
2017-08-02  9:13           ` Tino Calancha
2017-09-14  4:16 M.Nomiya
2017-09-14 12:00 ` Ken Brown
2017-09-14 12:11   ` M. Nomiya
2017-09-14 12:22     ` Ken Brown
2017-09-14 14:26       ` Paul Eggert
2017-09-14 22:12         ` M. Nomiya

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).