From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: make bootstrap error Date: Sun, 30 Jul 2017 17:11:39 +0300 Message-ID: <83379e2ew4.fsf@gnu.org> References: <877eyqh7xv.wl-nomiya@galaxy.dti.ne.jp> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1501423924 27469 195.159.176.226 (30 Jul 2017 14:12:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 30 Jul 2017 14:12:04 +0000 (UTC) Cc: rgm@gnu.org, nomiya@galaxy.dti.ne.jp, emacs-devel@gnu.org To: Tino Calancha Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 30 16:12:00 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbowm-0006ZD-2x for ged-emacs-devel@m.gmane.org; Sun, 30 Jul 2017 16:11:56 +0200 Original-Received: from localhost ([::1]:55468 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbowq-0007nU-AF for ged-emacs-devel@m.gmane.org; Sun, 30 Jul 2017 10:12:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54068) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbowi-0007nD-Kp for emacs-devel@gnu.org; Sun, 30 Jul 2017 10:11:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbowf-0005m0-Fq for emacs-devel@gnu.org; Sun, 30 Jul 2017 10:11:52 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbowf-0005lu-C4; Sun, 30 Jul 2017 10:11:49 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2033 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dbowe-0005rH-7A; Sun, 30 Jul 2017 10:11:48 -0400 In-reply-to: (message from Tino Calancha on Sun, 30 Jul 2017 20:35:06 +0900 (JST)) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217159 Archived-At: > From: Tino Calancha > Date: Sun, 30 Jul 2017 20:35:06 +0900 (JST) > cc: rgm@gnu.org, eliz@gnu.org, Emacs developers > > > After commit 6f6639d6ed6c6314b2643f6c22498fc2e23d34c7 > > ls-lisp.el requires 'em-glob. When eshell package is > > compiled, teh following file is generated: > > esh-groups.el > > > > but ls-lisp.el is compiled _before_ eshell, so that > > esh-groups.el doesn't exist yet. > > I moved the "(require 'em-glob)" inside `ls-lisp--dired' > to not break the build. Thanks, but I think this is still a bit fragile: it assumes that ls-lisp--dired will never be called before Eshell files are compiled, which might one day become false. How about simply adding to ls-lisp.el an autoload form for em-glob, instead of requiring it (with a suitable comment explaining why it is there)?