From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Code quality of some -ts-mode major modes Date: Fri, 17 Mar 2023 23:45:00 +0200 Message-ID: <34e4a26f-3830-9b8c-a5e0-861a63f5f8bc@yandex.ru> References: <87fsa3g05n.fsf@posteo.net> <87bkkrft9n.fsf@posteo.net> <83a60beb5a.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16283"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Cc: ruijie@netyu.xyz, casouri@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii , Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Mar 17 22:46:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pdHtf-00046N-ID for ged-emacs-devel@m.gmane-mx.org; Fri, 17 Mar 2023 22:45:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdHst-0006kP-3c; Fri, 17 Mar 2023 17:45:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdHsq-0006id-JV for emacs-devel@gnu.org; Fri, 17 Mar 2023 17:45:09 -0400 Original-Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pdHso-0002fr-13; Fri, 17 Mar 2023 17:45:08 -0400 Original-Received: by mail-wm1-x32c.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso5914966wmb.0; Fri, 17 Mar 2023 14:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679089503; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=zKQvj26Kj1XjfN5jj4MqYmwd4H1wWMuKC9tuiaqHhKk=; b=nC6J5sFQAmlnqtyTXxot+kKg+98mC6PmKfC4K2TqecAkVsdThJUCDEsByGNu3+RZi9 Cdk8t0VUlPXPpv9QPjhJLxSUT8P5WV41vQKJ4omhXeYBfVb8FK8xoUcz3m5GeGGXqeoM qnP3eyAnf8rwzKSLip+R6xIYYSjm0epglM5WoOmou2075WtOCIol5y8X15BjfrsebyBd 0Y/D+oOskQ6sKF/qKzKWr5xfs4hjR08boeBRP+9Bl43czPjGB57+uMq5IfQ5+rdCibPw cUcXqFQFMNrauQj7KCY+bDPP9yldAw9UEU9V87WcMxHoyYzd2xkkshfxlf7/2aNX1eal J1KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679089503; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=zKQvj26Kj1XjfN5jj4MqYmwd4H1wWMuKC9tuiaqHhKk=; b=JGokrY9Jeh+JtXf+zNQZYsNRiRMLzUPZwz8yDKwMNl30Th6mOcQAa5kUKfvSn3oQ/6 sAKO8YzBHNGyH17hl0dYHK3eygG9X8TH4mSTW7Ku8kPFIeG5RFhzY/kQC9Ou9QklRlDP 3q4+PoeMRmHMoLDYRk/lv7CKsHryKMCflBsnj23EmJcQ7EhMPXRKYchgShU95OOO3Sdu 6QZ1uusHQU2e2zOtMYZtzz5bFkM9s+sQHnIUu0B3GyIGxYWcu9Le1Gw/argDc6ZYRDmc Qv5RIjMLnBKNWNgMAYEaCwO6BvpAOfhfvkeqNw31KRWsA7EHfusFuDkVGO8fSR0zkQWY KbEQ== X-Gm-Message-State: AO0yUKXV8HAPQ3uzIKec3Y4maU1uT8dJYdWR0cLviMgrHINkubMO02EX Lt+uh8GOwXcKmRaF3FrCs8C+iGaNo64= X-Google-Smtp-Source: AK7set/h2VyL8o7lFQ5k6gfjPRkMddzbWur8ER2TOyZh28nPMIhUkRs+bCXCb2ovt7qg+9HLmFt4pw== X-Received: by 2002:a05:600c:2052:b0:3de:a525:1d05 with SMTP id p18-20020a05600c205200b003dea5251d05mr3633706wmg.8.1679089503200; Fri, 17 Mar 2023 14:45:03 -0700 (PDT) Original-Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id k18-20020a05600c1c9200b003dc434b39c7sm16698894wms.0.2023.03.17.14.45.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Mar 2023 14:45:02 -0700 (PDT) Content-Language: en-US In-Reply-To: <83a60beb5a.fsf@gnu.org> Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=raaahh@gmail.com; helo=mail-wm1-x32c.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:304559 Archived-At: On 17/03/2023 15:54, Eli Zaretskii wrote: >> I repeat my question from above, if we are ready to link to the >> grammars, wouldn't it make sense to populate the variable >> `treesit-language-source-alist' directly? > No, I don't want to do that, see above for the reasons. (We had this > discussion about 2 months ago, when the command was added to Emacs.) FWIW, I had no problems with that conclusion, but then I noticed that we keep a separate list of sources inside admin/notes/tree-sitter, which basically contains the same info, as well as all 6 known exceptions to the general scenario (where in the usual case we can determine everything just from the name of the language). If we're going to keep it updated (and we apparently are), why not move that info to treesit-language-source-alist instead. We can make it a defcustom, to emphasize that people should update it whenever they see the data is old.