From: "Colin Woodbury" <colin@fosskers.ca>
To: "Michael Albinus" <michael.albinus@gmx.de>
Cc: "Mattias Engdegård" <mattiase@acm.org>,
Philipp <p.stephani2@gmail.com>,
emacs-devel@gnu.org
Subject: Re: [PATCH] lisp/files.el: Add `file-name-set-extension`
Date: Tue, 15 Jun 2021 18:15:26 -0700 [thread overview]
Message-ID: <2a71e97f-e994-431f-9794-c8c80807f968@www.fastmail.com> (raw)
In-Reply-To: <03440815-be36-42c3-ae57-cc4d7ffd7a0e@www.fastmail.com>
[-- Attachment #1: Type: text/plain, Size: 799 bytes --]
The copyright assignment process was finalized for me today, so this should be good-to-go.
Thanks!
Colin
On Thu, 10 Jun 2021, at 07:40, Colin Woodbury wrote:
> Good catch Michael, thank you, I had completely forgotten about Windows. I've updated the patch.
>
> Cheers,
> Colin
>
> On Thu, 10 Jun 2021, at 00:46, Michael Albinus wrote:
>> "Colin Woodbury" <colin@fosskers.ca <mailto:colin%40fosskers.ca>> writes:
>>
>> > Hi all,
>>
>> Hi Colin,
>>
>> > + ((equal ?/ (string-to-char (substring file -1))) (error "Filename is a directory: %s" filename))
>>
>> This shall be (directory-name-p file) . You cannot assume that ?/ is
>> always the directory separator, for example on MS Windows.
>>
>> Best regards, Michael.
>>
>
>
> *Attachments:*
> * file-name-with-extension.patch
[-- Attachment #2: Type: text/html, Size: 1493 bytes --]
next prev parent reply other threads:[~2021-06-16 1:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 15:50 [PATCH] lisp/files.el: Add `file-name-set-extension` Colin Woodbury
2021-05-25 17:48 ` Andreas Schwab
2021-05-25 19:42 ` Colin Woodbury
2021-05-25 18:00 ` Basil L. Contovounesios
2021-05-25 19:45 ` Colin Woodbury
2021-05-25 20:25 ` Stefan Monnier
2021-05-25 21:21 ` Colin Woodbury
2021-05-25 21:29 ` Stefan Monnier
2021-05-25 21:44 ` Colin Woodbury
2021-05-26 7:34 ` Andreas Schwab
2021-05-26 16:31 ` Colin Woodbury
2021-05-26 17:39 ` Andreas Schwab
2021-05-31 1:16 ` Colin Woodbury
2021-06-04 13:08 ` Philipp
[not found] ` <26B660D9-AC76-4AFC-9FFD-2F5D4DCA16C1@acm.org>
2021-06-09 20:54 ` Colin Woodbury
2021-06-09 23:05 ` Stefan Monnier
2021-06-10 0:42 ` Colin Woodbury
2021-06-10 2:45 ` Colin Woodbury
2021-06-10 7:46 ` Michael Albinus
2021-06-10 14:40 ` Colin Woodbury
2021-06-16 1:15 ` Colin Woodbury [this message]
2021-06-19 9:16 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a71e97f-e994-431f-9794-c8c80807f968@www.fastmail.com \
--to=colin@fosskers.ca \
--cc=emacs-devel@gnu.org \
--cc=mattiase@acm.org \
--cc=michael.albinus@gmx.de \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).