Re: [PATCH] lisp/files.el: Add `file-name-set-extension`

["Colin Woodbury" <colin@fosskers.ca>]

[-- Attachment #1.1: Type: text/plain, Size: 492 bytes --]

Thank you, you're right. I've tested the old and revised code, and the double backslash wasn't neccesary.

I've attached the revised patch.

On Tue, 25 May 2021, at 11:00, Basil L. Contovounesios wrote:
> "Colin Woodbury" <colin@fosskers.ca <mailto:colin%40fosskers.ca>> writes:
> 
> > +    (let* ((patt "[ \\t\\n\\r.]+") ; Borrowed from `string-trim'.
> 
> Those backslashes need escaping only in string-trim's docstring, not in
> the literal regexp string.
> 
> Thanks,
> 
> -- 
> Basil
> 

[-- Attachment #1.2: Type: text/html, Size: 954 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: file-name-set-extension.patch --]
[-- Type: text/x-patch; name="file-name-set-extension.patch", Size: 1045 bytes --]

diff --git a/lisp/files.el b/lisp/files.el
index 62e1702fdf..18a54b3ec7 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -4889,6 +4889,20 @@ extension, the value is \"\"."
         (if period
             "")))))
 
+(defun file-name-set-extension (filename extension)
+  "Change the extension of a FILENAME to EXTENSION.
+Sanitizes the input to consolidate leading/trailing dots.
+
+Returns `nil' if either of the FILENAME or EXTENSION are `nil'
+before sanitizing, or empty afterwards."
+  (when (and filename extension)
+    (let* ((patt "[ \t\n\r.]+") ; Inspired by `string-trim'.
+           (filename (string-trim-right filename patt))
+           (extension (string-trim-left extension patt)))
+      (unless (or (string-empty-p filename)
+                  (string-empty-p extension))
+        (concat (file-name-sans-extension filename) "." extension)))))
+
 (defun file-name-base (&optional filename)
   "Return the base name of the FILENAME: no directory, no extension."
   (declare (advertised-calling-convention (filename) "27.1"))